Skip to content

fix: Bugbot finding from promotion PR #284 - #285

Merged
saadqbal merged 2 commits into
developfrom
fix/bugbot-stale-bootstrap-cli
Jul 1, 2026
Merged

fix: Bugbot finding from promotion PR #284#285
saadqbal merged 2 commits into
developfrom
fix/bugbot-stale-bootstrap-cli

Conversation

@shujaatTracebloc

@shujaatTraceblocshujaatTracebloc commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Resolves the Cursor Bugbot finding surfaced on the client promotion PR (#284, develop → main).

Fix

  • Stale bootstrap skips CLI install — CLI installation now lives only inside provision_client, which the orchestrator calls only when provision.sh was fetched. A stale bootstrap that fetched install-cli.sh but notprovision.sh would finish without ever installing the CLI, unlike the previous post-Helm Step 5. Added an elif fallback: when provision_client is absent but install_tracebloc_cli is defined, call it (non-fatal) so the CLI still gets installed for tracebloc data ingest; provisioning then falls through to the dual-mode credential path inside install_client_helm. (chore(release): promote develop → main (week of 2026-06-29) #284 (comment))

Lands on develop; the promotion PR head picks it up on the next sync and Bugbot re-reviews.

🤖 Generated with Claude Code


Note

Low Risk
Small installer orchestration fallback for edge-case stale bootstrap bundles; no auth or cluster logic changes beyond when the CLI install runs.

Overview
Fixes a regression where stale bootstraps that fetch install-cli.sh but not provision.sh would complete without installing the tracebloc CLI, after CLI install was folded into provision_client only.

install-k8s.sh now adds an elif branch: if provision_client is undefined but install_tracebloc_cli exists, it calls install_tracebloc_cli (non-fatal, restoring the old post-Helm Step 5 behavior for tracebloc data ingest). Client provisioning still falls through to the dual-mode credential path in install_client_helm.

scripts/manifest.sha256 is updated for the changed install-k8s.sh.

Reviewed by Cursor Bugbot for commit 57a0d31. Bugbot is set up for automated code reviews on this repo. Configure here.

Bugbot (promotion PR #284): CLI installation now runs only inside
provision_client, but the orchestrator only calls it when provision.sh was
fetched. A stale bootstrap that fetched install-cli.sh but not provision.sh
completes without ever installing the CLI (unlike the old post-Helm Step 5).
Add an elif fallback that calls install_tracebloc_cli (non-fatal) when
provision_client is absent.
- Stale bootstrap skips CLI install (scripts/install-k8s.sh:121)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@shujaatTraceblocshujaatTracebloc self-assigned this Jun 26, 2026
The supply-chain manifest pins the digest of every script the bootstrap
fetches; editing install-k8s.sh changed its hash.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@saadqbal
saadqbal merged commit 311a950 into developJul 1, 2026
23 checks passed
@saadqbal
saadqbal deleted the fix/bugbot-stale-bootstrap-cli branch July 1, 2026 08:10
saadqbal added a commit that referenced this pull request Jul 1, 2026
…sion reorder (#284)
Promotes #279 (installer reorder: sign-in + provision before Helm), #281 (R8 verified bootstrap + sign-installer-manifest release job), #285 (stale-bootstrap CLI install fix), #286 (jq-free one-client guard). Brings the R8 install.sh + the sign-installer-manifest job to main ahead of the signed installer release.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shujaatTracebloc@saadqbal@LukasWodka