Uh oh!
There was an error while loading. Please reload this page.
fix: Bugbot finding from promotion PR #284 - #285
Merged
Conversation
Bugbot (promotion PR #284): CLI installation now runs only inside provision_client, but the orchestrator only calls it when provision.sh was fetched. A stale bootstrap that fetched install-cli.sh but not provision.sh completes without ever installing the CLI (unlike the old post-Helm Step 5). Add an elif fallback that calls install_tracebloc_cli (non-fatal) when provision_client is absent. - Stale bootstrap skips CLI install (scripts/install-k8s.sh:121) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The supply-chain manifest pins the digest of every script the bootstrap fetches; editing install-k8s.sh changed its hash. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saadqbal
approved these changes
Jul 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
saadqbal added a commit
that referenced
this pull request
Jul 1, 2026
…sion reorder (#284) Promotes #279 (installer reorder: sign-in + provision before Helm), #281 (R8 verified bootstrap + sign-installer-manifest release job), #285 (stale-bootstrap CLI install fix), #286 (jq-free one-client guard). Brings the R8 install.sh + the sign-installer-manifest job to main ahead of the signed installer release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the Cursor Bugbot finding surfaced on the client promotion PR (#284, develop → main).
Fix
provision_client, which the orchestrator calls only whenprovision.shwas fetched. A stale bootstrap that fetchedinstall-cli.shbut notprovision.shwould finish without ever installing the CLI, unlike the previous post-Helm Step 5. Added aneliffallback: whenprovision_clientis absent butinstall_tracebloc_cliis defined, call it (non-fatal) so the CLI still gets installed fortracebloc data ingest; provisioning then falls through to the dual-mode credential path insideinstall_client_helm. (chore(release): promote develop → main (week of 2026-06-29) #284 (comment))Lands on
develop; the promotion PR head picks it up on the next sync and Bugbot re-reviews.🤖 Generated with Claude Code
Note
Low Risk
Small installer orchestration fallback for edge-case stale bootstrap bundles; no auth or cluster logic changes beyond when the CLI install runs.
Overview
Fixes a regression where stale bootstraps that fetch
install-cli.shbut notprovision.shwould complete without installing the tracebloc CLI, after CLI install was folded intoprovision_clientonly.install-k8s.shnow adds anelifbranch: ifprovision_clientis undefined butinstall_tracebloc_cliexists, it callsinstall_tracebloc_cli(non-fatal, restoring the old post-Helm Step 5 behavior fortracebloc data ingest). Client provisioning still falls through to the dual-mode credential path ininstall_client_helm.scripts/manifest.sha256is updated for the changedinstall-k8s.sh.Reviewed by Cursor Bugbot for commit 57a0d31. Bugbot is set up for automated code reviews on this repo. Configure here.