Uh oh!
There was an error while loading. Please reload this page.
fix(chart): inject proxyEnv into the resource-monitor DaemonSet - #312
Merged
Conversation
resource-monitor is the only backend-calling workload whose pod gets NO proxy env from the chart - jobs-manager, pods-monitor, requests-proxy, image-refresh, auto-upgrade and the egress check all include tracebloc.proxyEnv already. Behind a corporate egress proxy its api-token-auth and edge-device-heartbeat POSTs dial direct and fail, so proxied clusters show stale/no node resource data. One include, appended after the existing env list (the DaemonSet has a fixed env list - no .Values.env passthrough - so the jobs-manager-style exclusion dance does not apply). Renders nothing when HTTP_PROXY_HOST is unset; NO_PROXY carries the cluster-internal ranges and the kubernetes python client ignores ambient proxy env, so in-cluster API calls are unaffected. Companion to tracebloc/client-runtime#154 (shared ProxyConfig + resource_monitor threading the split-key settings); with this include alone, current images already work via requests' trust_env handling of the URL-form vars. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
saadqbal
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource-monitor is the only backend-calling workload whose pod gets no proxy env from the chart — jobs-manager, pods-monitor, requests-proxy, image-refresh, auto-upgrade and the egress-reachability check all include
tracebloc.proxyEnvalready. Behind a corporate egress proxy itsapi-token-authandedge-device-heartbeatPOSTs dial direct and fail, so proxied clusters show stale/no node resource data.One include, appended after the DaemonSet's fixed env list (no
.Values.envpassthrough here, so the jobs-manager-style exclusion dance from #238 does not apply).Verified
helm templatewithenv.HTTP_PROXY_HOSTset renders the URL-form sextet + cluster-safe NO_PROXY, correctly indented, directly afterCLIENT_PASSWORD.HTTP_PROXY_HOST: renders nothing — non-proxy installs byte-identical.helm lintclean.Companion
Code half: tracebloc/client-runtime#165 (shared ProxyConfig; resource_monitor threads split-key settings). With this include alone, current resource-monitor images already work behind a proxy via requests'
trust_envhandling of the URL-form vars — so this chart change is independently shippable and is the half that matters for existing clusters.Refs tracebloc/client-runtime#154.
🤖 Generated with Claude Code