Uh oh!
There was an error while loading. Please reload this page.
Conversation
- Improved the _cluster_exists function to utilize multiple detection methods for verifying cluster existence, ensuring compatibility across different distributions. - Updated _create_new_cluster function to handle existing clusters gracefully by checking for specific error messages and reusing the existing cluster if found.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| fi | ||
| cat "$create_out" >&2 | ||
| rm -f "$create_out" | ||
| exit "$create_rc" |
There was a problem hiding this comment.
create_rc always captures 0 due to negation
High Severity
In bash, if ! cmd; then means $? inside the then block is 0 (the result of the negation succeeding), not the original command's exit code. So create_rc=$? always captures 0, and exit "$create_rc" silently exits with success even when k3d fails with a real error. This masks cluster creation failures from callers.
| fi | ||
| # Executable but still failing (e.g. noexec mount or libs) | ||
| error "Helm could not be run. Try: sudo chmod 755 $helm_bin then re-run this script." | ||
| } |
There was a problem hiding this comment.
Duplicate helm executable check functions across files
Low Severity
Both _ensure_helm_runnable in install-client-helm.sh and _ensure_helm_executable in setup-linux.sh are newly added and serve the same purpose — detecting and fixing non-executable helm binaries via sudo chmod 755. Having two separate implementations of the same fix increases maintenance burden and risks divergent behavior.
Note
Medium Risk
Touches the bootstrap/installer flow around cluster creation and Helm execution, so failures could block installs on some environments. Changes are localized to shell scripts and primarily add fallbacks and clearer handling for common Linux edge cases.
Overview
Improves installer reliability across Linux distros by making
k3dcluster existence checks more robust (multiple output parsing strategies) and treating "already exists" create failures as a reuse/start-existing-cluster path.Adds safeguards to ensure
helmis runnable after install by fixing non-executable Helm binaries (viachmod/guidance) and documents a common Docker/k3d Docker-socket "permission denied" fix (newgrp docker/ re-login).Written by Cursor Bugbot for commit 6c4961c. This will update automatically on new commits. Configure here.