Skip to content

main -> Stop prompting for location during registration, auto-derive from timezone - #356

Merged
saadqbal merged 2 commits into
mainfrom
develop
Jul 16, 2026
Merged

main -> Stop prompting for location during registration, auto-derive from timezone#356
saadqbal merged 2 commits into
mainfrom
develop

Conversation

@saadqbal

@saadqbalsaadqbal commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

…rompt

feat(installer): stop prompting for location during register — auto-derive from timezone (#354)

Summary

Related

Type of change

  • Feature
  • Bug fix
  • Tech-debt / refactor
  • Docs
  • Security / hardening
  • Breaking change

Test plan

Screenshots / recordings

Deployment notes

Checklist

  • Tests added / updated and passing locally
  • Docs updated if behavior or config changed
  • No secrets / credentials in the diff
  • For security-sensitive paths: appropriate reviewer requested

Note

Low Risk
Installer UX and provisioning argument assembly only; no auth or credential handling changes beyond omitting optional --location.

Overview
Interactive registration no longer asks for a carbon zone — only the client name is prompted. Location comes from TRACEBLOC_CLIENT_LOCATION when set, otherwise silently from the machine timezone via _detect_location_zone; if detection finds nothing, client create runs without--location (optional CLI behavior per cli#137).

Invalid-zone errors are clearer:_report_create_failure takes a source flag (env vs auto) so hints either point at fixing TRACEBLOC_CLIENT_LOCATION or explain timezone auto-derivation and how to override.

Tests cover the no-prompt flows (#354) and rejected-zone messaging (Bugbot #356); scripts/manifest.sha256 is updated for provision.sh.

Reviewed by Cursor Bugbot for commit 684b98c. Bugbot is set up for automated code reviews on this repo. Configure here.

…rompt
feat(installer): stop prompting for location during register — auto-derive from timezone (#354)
@LukasWodka

Copy link
Copy Markdown
Contributor

👋 Heads-up — Code review queue is at 38 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a179e0c. Configure here.

Comment threadscripts/lib/provision.sh Outdated
#356) (#357)
* fix(installer): attribute rejected-zone hint to its real source (Bugbot #356)
The invalid-location failure branch always told the operator the zone was
auto-derived from the timezone and pointed them at TRACEBLOC_CLIENT_LOCATION
as the fix. When the rejected value actually came FROM that env override, the
hint read as "your override was ignored" — the opposite of what happened.
Track whether the location was pinned via TRACEBLOC_CLIENT_LOCATION ("env") or
timezone-derived ("auto") and pass the source into _report_create_failure so the
fix hint names the real origin. Defaults to "auto" when the caller omits it.
Adds three unit tests covering both sources plus the default.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* chore(installer): refresh manifest checksum for provision.sh (R8)
The rejected-zone-hint edit changed scripts/lib/provision.sh; regenerate
scripts/manifest.sha256 so the supply-chain "manifest is current" check passes.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@saadqbal@LukasWodka@shujaatTracebloc