Uh oh!
There was an error while loading. Please reload this page.
Conversation
…rompt feat(installer): stop prompting for location during register — auto-derive from timezone (#354)
LukasWodka
commented
Jul 16, 2026
Contributor
👋 Heads-up — Code review queue is at 38 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a179e0c. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
#356) (#357) * fix(installer): attribute rejected-zone hint to its real source (Bugbot #356) The invalid-location failure branch always told the operator the zone was auto-derived from the timezone and pointed them at TRACEBLOC_CLIENT_LOCATION as the fix. When the rejected value actually came FROM that env override, the hint read as "your override was ignored" — the opposite of what happened. Track whether the location was pinned via TRACEBLOC_CLIENT_LOCATION ("env") or timezone-derived ("auto") and pass the source into _report_create_failure so the fix hint names the real origin. Defaults to "auto" when the caller omits it. Adds three unit tests covering both sources plus the default. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(installer): refresh manifest checksum for provision.sh (R8) The rejected-zone-hint edit changed scripts/lib/provision.sh; regenerate scripts/manifest.sha256 so the supply-chain "manifest is current" check passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
shujaatTracebloc
approved these changes
Jul 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…rompt
feat(installer): stop prompting for location during register — auto-derive from timezone (#354)
Summary
Related
Type of change
Test plan
Screenshots / recordings
Deployment notes
Checklist
Note
Low Risk
Installer UX and provisioning argument assembly only; no auth or credential handling changes beyond omitting optional
--location.Overview
Interactive registration no longer asks for a carbon zone — only the client name is prompted. Location comes from
TRACEBLOC_CLIENT_LOCATIONwhen set, otherwise silently from the machine timezone via_detect_location_zone; if detection finds nothing,client createruns without--location(optional CLI behavior per cli#137).Invalid-zone errors are clearer:
_report_create_failuretakes a source flag (envvsauto) so hints either point at fixingTRACEBLOC_CLIENT_LOCATIONor explain timezone auto-derivation and how to override.Tests cover the no-prompt flows (#354) and rejected-zone messaging (Bugbot #356);
scripts/manifest.sha256is updated forprovision.sh.Reviewed by Cursor Bugbot for commit 684b98c. Bugbot is set up for automated code reviews on this repo. Configure here.