fix: Bugbot findings from promotion PR #383 (helm probe timeout + node-local reuse)

[shujaatTracebloc]

Resolves two Cursor Bugbot findings on the client promotion PR (#383, develop → main).

Fixes:

• Ungated Helm in client probe (Medium) — Get-InstalledClientInfo (scripts/install-k8s.ps1) ran helm list -A / helm get values with no bounded probe. Helm has no request timeout, so a wedged API server hung Step 4 (after browser sign-in) and Step 5's one-client guard indefinitely. Added a small shared Test-ApiReachable helper (a 5s-bounded kubectl probe, mirroring the gate Get-TrainingResources already uses) and gated the enumeration behind it — an unreachable API now degrades to the existing ListUnknown shape instead of hanging. (Release develop → main #383 (comment))
• Reuse ignores node-local data (Medium) — the leftover-data guard (scripts/lib/cluster.sh) offered "[r] reuse — keep and adopt the existing data" and logged adoption, but under TB_STORAGE_MODE=node-local there is no /tracebloc host bind-mount, so the data is stranded and the cluster starts empty. Made the prompt option label and the reuse branch honest under node-local (data left on disk, not adopted; guidance to re-ingest or switch to hostpath). Hostpath behavior is unchanged. (Release develop → main #383 (comment))

Coverage: Pester tests for Test-ApiReachable and Get-InstalledClientInfo degrading on an unreachable API without calling helm; bats tests for node-local reuse (non-interactive + interactive) staying honest while hostpath reuse is unchanged. scripts/manifest.sha256 refreshed for the cluster.sh + install-k8s.ps1 changes. No golden impact (the interactive prompt/reuse copy isn't captured in the copy-catalog goldens).

Lands on develop; the promotion PR head picks these up on the next develop sync and Bugbot re-reviews.

🤖 Generated with Claude Code

---

Note

Low Risk
Installer UX and fail-closed behavior only; no auth or runtime changes. Hostpath paths unchanged; Windows change degrades to existing ListUnknown instead of hanging.

Overview
Addresses two Bugbot findings from the promotion PR: Windows installer hangs and misleading node-local “reuse”.

On Windows (install-k8s.ps1), adds Test-ApiReachable (5s kubectl get --raw=/readyz) and runs it at the start of Get-InstalledClientInfo before any helm list / helm get values. If the API is down, the function returns ListUnknown and skips helm so Steps 4–5 fail closed instead of freezing indefinitely.

On bash (cluster.shguard_leftover_data), when TB_STORAGE_MODE=node-local, the leftover prompt no longer claims “reuse = adopt”: it offers [r] keep (data left on disk, cluster starts empty), accepts keep/k as well as r/reuse (any case), warns on the reuse branch, and updates non-interactive --reuse-data help to say data is NOT adopted. Hostpath reuse behavior is unchanged.

Pester and bats cover the probe, helm gating, and node-local vs hostpath paths; scripts/manifest.sha256 is refreshed for the touched scripts.

^{Reviewed by Cursor Bugbot for commit a22c784. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ce98e6c. Configure here.}