Uh oh!
There was an error while loading. Please reload this page.
ci(release): tag/chart-version guard + strict stability rule (release train) - #460
Merged
Conversation
…#1301 Q5) The tag's base X.Y.Z must equal client/Chart.yaml's version (train-cut or manual), and any non-plain-semver tag must be a PRE-release -- otherwise it would become 'latest' (the installer bootstrap) and enter the helm index as stable. Tag passed via env per R8 (backend#889). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
The guard lived only inside the release job; sign-installer-manifest has
no needs and kept stamping + attaching installers for a bad release --
which, left marked stable, already IS 'latest' (what the bootstrap
resolves). Restructured: a dedicated verify job gates both jobs. And
instead of fail-and-strand, an unmarked non-final tag is DEMOTED to
prerelease ('latest' snaps back to the previous stable) and publishing
continues as a proper pre-release. Chart-version mismatch stays a hard
fail -- nothing to auto-fix without a bump.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c61982c. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
A release that is BOTH mis-marked stable AND chart-version-mismatched hit the exit 1 before the demotion ran, stranding it as 'latest' with no assets (404ing bootstrap). Demotion now runs first -- it is safe in isolation and must not be skippable by any other failure. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saadqbal
approved these changes
Jul 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What (backend#1301, Q5 — approved by Lukas)
Two guards in
release-helm-chart.yaml, running before lint/package on every published release:X.Y.Zmust equalclient/Chart.yaml'sversion— train-cut or manual — so the chart version can never go silently stale after an out-of-train release.v1.9.7-rc.1, or a malformedv1.9.7rc1) must be marked pre-release — otherwise it would becomelatest(what the installer bootstrap resolves) and enter the helm index as stable.Tag reaches the script via env, never interpolated (R8, backend#889).
Context
client is joining the release train: staging hop → train creates pre-release
v1.X.Y-rc.N(rc numbering strictly numeric) → FR from the rc's own stamped installer; prod hop → stablev1.X.Y. The stamped-installer flow needs zero changes — the fail-closed guard is placeholder-based, so rc-stamped installers verify at their own tag as-is. Helm-side safety:helm installexcludes pre-release chart versions unless--devel/explicit--version.Test plan
releases/lateststill points at the last stable, andhelm search repo tracebloc -l --develshows the rc🤖 Generated with Claude Code
Note
Medium Risk
Changes release automation and can edit GitHub release metadata (prerelease demotion) and block publishing on mismatch; it does not alter runtime app code but affects what becomes
latestand what ships on publish.Overview
Adds a
verifyjob that runs before Helm packaging and installer manifest signing on every published release, so bad releases no longer get charts or stamped installers attached.The guard compares the release tag’s base X.Y.Z to
client/Chart.yamlversionand fails the workflow if they differ (chart must be bumped first). For tags that are not plainvX.Y.Zbut were published as stable, it demotes the GitHub release to prerelease first solatest(installer bootstrap) does not point at an RC or malformed tag; demotion runs before the version check so a doubly-broken release still loseslatest. The tag is passed only via env, not shell interpolation.releaseandsign-installer-manifestnowneeds: verify.Reviewed by Cursor Bugbot for commit a134974. Bugbot is set up for automated code reviews on this repo. Configure here.