Skip to content

fix(installer): silence the PS 5.1 progress throttle in install-k8s.ps1 downloads - #471

Merged
LukasWodka merged 4 commits into
developfrom
fix/468-k8s-download-throttle
Jul 29, 2026
Merged

fix(installer): silence the PS 5.1 progress throttle in install-k8s.ps1 downloads#471
LukasWodka merged 4 commits into
developfrom
fix/468-k8s-download-throttle

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Follow-up to #469, which fixed the PS 5.1 progress-overlay throttle (10–50× slowdown + hang-looking modal) in the bootstrap's fetch helpers. The main installer still ran all its large Invoke-WebRequest downloads under the same overlay — worst of all the Docker Desktop fallback, which is a measured 613 MB. One function-local $ProgressPreference = 'SilentlyContinue' in Invoke-WithRetry covers every fetch scriptblock it drives (PowerShell dynamic scoping — the winget msixbundle, Docker Desktop fallback, kubectl, k3d, helm, the GPU device-plugin yaml, and both version resolvers), and honest expectation lines name each big wait before it goes quiet.

What changed

  1. Invoke-WithRetry: function-local progress silencing (auto-reverts on return), same comment wording as fix(installer): honest cosign bootstrap download + translated DISM failures #469's helpers.
  2. Expectation lines before the cold-path downloads, with sizes measured today via HEAD requests (not guessed): Docker Desktop ~600 MB ("the biggest download of this install; several minutes is normal"), winget ~200 MB, kubectl ~60 MB, k3d ~25 MB, helm ~20 MB. All sit inside the if (-not (Has …)) guards — warm re-runs print nothing new.
  3. 4 new Pester invariants locking the silencing + the expectation lines in place.

Not touched (out of scope, tiny/non-download): the auth POST and the preflight HEAD probe; the two version-resolver IWRs are covered dynamically via Invoke-WithRetry.

Related

Refs #468 (the bootstrap half closed by #469; this is the install-k8s.ps1 half flagged there as follow-up)

Merge-order note:#469 also touches scripts/install-k8s.ps1 + scripts/manifest.sha256. Suggest merging #469 first; I'll then merge develop into this branch and re-run scripts/gen-manifest.sh (the only conflict is the regenerated digest line).

Type of change

  • Bug fix

Test plan

  • Invoke-Pester scripts/tests205 passed / 0 failed (pwsh 7.5.2, Pester 5.7.1), incl. the 4 new invariants.
  • Invoke-ScriptAnalyzer on both entrypoints: 0 errors. bash scripts/check-style.sh: clean.
  • scripts/gen-manifest.sh regenerated (install-k8s.ps1 digest changed).
  • Download sizes verified against the live URLs today (winget 207 MB, Docker 613 MB, kubectl v1.36.3 58 MB, k3d v5.9.0 25 MB, helm v4.2.3 19 MB).

Deployment notes

None — ships with the next client release.

Checklist

  • Tests added / updated and passing locally
  • Docs updated if behavior or config changed
  • No secrets / credentials in the diff
  • For security-sensitive paths: appropriate reviewer requested (CODEOWNERS: @saadqbal)
  • Terminal output follows STYLE.md — tone helpers, ASCII punctuation; bash scripts/check-style.sh passes
  • Cross-repo issues use Fixes tracebloc/<repo>#N — same-repo Refs #468 used deliberately (must not close; fix(installer): honest cosign bootstrap download + translated DISM failures #469 closes it)

🤖 Generated with Claude Code


Note

Low Risk
Installer-only UX and download performance on Windows; no changes to cluster provisioning, credentials, or install logic beyond messaging and progress preference.

Overview
Fixes slow/hang-looking Windows installer downloads on PowerShell 5.1 by applying the same #468 treatment already used in the bootstrap: Invoke-WithRetry now sets $ProgressPreference = 'SilentlyContinue' for every Invoke-WebRequest it runs (winget, Docker fallback, kubectl/k3d/helm binaries, checksums, version lookups, GPU plugin YAML).

Because silencing the progress overlay makes long fetches look idle, the PR adds Info lines before the large cold-path downloads (~200 MB winget, ~600 MB Docker Desktop, ~60/25/20 MB kubectl/k3d/helm), only when those tools are actually being fetched.

Tests & integrity: four Pester checks lock in the silencing and message strings; scripts/manifest.sha256 is updated for install-k8s.ps1.

Reviewed by Cursor Bugbot for commit 0e101cb. Bugbot is set up for automated code reviews on this repo. Configure here.

…s1 downloads (#468 follow-up)
Same class as the bootstrap fix in #469: PS 5.1's progress overlay
throttles Invoke-WebRequest 10-50x and reads like a hang. One
function-local $ProgressPreference in Invoke-WithRetry covers every
fetch scriptblock it drives (dynamic scoping) - winget msixbundle,
Docker Desktop fallback, kubectl, k3d, helm, GPU plugin yaml, and the
version resolvers.
Honest-progress expectation lines (sizes measured today via HEAD):
Docker Desktop ~600 MB, winget ~200 MB, kubectl ~60 MB, k3d ~25 MB,
helm ~20 MB - all cold-path only, silent on warm re-runs.
Pester: 205 passed / 0 failed locally. PSSA: 0 errors.
manifest.sha256 regenerated.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@LukasWodkaLukasWodka self-assigned this Jul 29, 2026
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

bugbot run

@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

👋 Heads-up — Code review queue is at 34 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit bc0800b. Configure here.

shujaatTracebloc
shujaatTracebloc previously approved these changes Jul 29, 2026

@shujaatTraceblocshujaatTracebloc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code + logic, CI, and manifest — LGTM. ✅

Correctness

  • The core mechanism is sound: the function-local $ProgressPreference = 'SilentlyContinue' in Invoke-WithRetry (line 171) is inherited by every & $ScriptBlock it drives via PowerShell's dynamic scope chain, and reverts on return. Same idiom already shipping in #469's bootstrap helpers.
  • Verified every heavy download runs inside an Invoke-WithRetry scriptblock, so all get silenced: winget msixbundle (574), Docker Desktop fallback (600), kubectl.exe (845), k3d.exe (952), helm zip (1011), GPU device-plugin yaml (1492). The kubectl version resolver (stable.txt, 839) is wrapped too.
  • All the expectation Info lines sit inside the if (-not (Has …)) cold-path guards, so warm re-runs stay quiet. 👍

Verified

  • scripts/manifest.sha256 digest for install-k8s.ps1 recomputed and matches the branch file (7852f47a…).
  • 30+ CI checks green (Pester incl. windows-latest, ScriptAnalyzer, source-of-truth drift, shellcheck); Cursor Bugbot clean, no open review threads.
  • Branch is current with develop (ahead 1 / behind 0).

Non-blocking nits (fine to leave):

  • The PR body says both version resolvers are covered via Invoke-WithRetry, but Get-LatestGitHubTag (890, k3d) and the helm-latest lookup (1004) aren't wrapped. Immaterial — one is a -Method Head and the other returns a tiny string, so no meaningful progress overlay either way.
  • kubectl now prints both a Log and an Info "Downloading kubectl …" line (slight redundancy).

Merge-order note from the description holds: whichever of #469/#471 merges second will need gen-manifest.sh re-run for the install-k8s.ps1 digest line.

Conflicts: manifest.sha256 (regenerated via gen-manifest.sh) and the
two EOF-appended test blocks in install-k8s.Tests.ps1 (kept both;
restored the closing braces the conflict hunk swallowed).
Merged suite: 216 passed / 0 failed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

bugbot run

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 724295b. Configure here.

Only conflict: manifest.sha256 -- regenerated via gen-manifest.sh.
Merged suite: 227 passed / 0 failed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

bugbot run

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit da2677c. Configure here.

@shujaatTraceblocshujaatTracebloc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. ✅

Correctness (re-verified on 0e101cb)

  • Mechanism is sound: function-local `$ProgressPreference = 'SilentlyContinue'` at the top of `Invoke-WithRetry` (install-k8s.ps1:171) is inherited by every `& $ScriptBlock` via PowerShell dynamic scope and reverts on return — same idiom as #469.
  • Enumerated every `Invoke-WebRequest`: all six heavy downloads (winget, Docker Desktop fallback, kubectl, k3d, helm, GPU device-plugin YAML) run inside `Invoke-WithRetry` and are preceded by an `Info` size line, all under `if (-not (Has …))` cold-path guards — warm re-runs stay quiet.
  • Pester locally: 203 passed / 0 failed (8 Windows-only DISM skipped off-macOS), incl. the 4 new invariants.

Housekeeping

  • Merged `develop` (was behind 1 — #458, which also touches manifest.sha256). Manifest auto-merged cleanly; `gen-manifest.sh` shows zero drift. Pushed as 0e101cb.
  • 32 CI checks green, Cursor Bugbot clean, no open review threads.

Non-blocking nit (fine to leave): the PR body says both version resolvers are covered by `Invoke-WithRetry`, but `Get-LatestGitHubTag` (:923, a HEAD probe) and the helm-latest lookup (:1037, a tiny string) are not wrapped. Immaterial for the progress overlay — the kubectl resolver that matters is wrapped.

Merge-order note from the description still holds: whichever of #469/#471 merges last needs `gen-manifest.sh` re-run for the install-k8s.ps1 digest line (already handled here).

@LukasWodka
LukasWodka merged commit 6c48d9b into developJul 29, 2026
35 checks passed
@LukasWodka
LukasWodka deleted the fix/468-k8s-download-throttle branch July 29, 2026 13:03
shujaatTracebloc added a commit that referenced this pull request Jul 30, 2026
…ws installer (#422) (#477)
* chore(#422): honest step labels + per-tool heartbeat/progress in the PS installer
Step 1/5 "Checking system requirements" actually installed ~700 MB of tools,
nearly all console-silent (downloads with the progress overlay off since #471,
plus silent winget/Add-AppxPackage/installer invocations), which reads as a hang.
The k3d start path also streamed raw INFO[...] lines past the style system.
- Split Step 1 into "Checking system requirements" (preflight/GPU/virtualisation)
and a dedicated "Installing system tools" step; renumber to /6.
- Invoke-WithHeartbeat: run a blocking op in a background job with a live spinner
(built on the existing Wait-JobWithProgress) so no op sits silent >10s. Wired
into every tool download (kubectl/k3d/helm/winget/Docker Desktop), the winget
installs, Add-AppxPackage, and the Docker Desktop installer.
- Get-ToolSummaryLine: one honest line per tool (name, version, size, elapsed),
printed as each tool becomes ready.
- Route `k3d cluster start` through Invoke-WithHeartbeat: capture its raw output
to the log + show a styled heartbeat instead of streaming INFO[...] lines
(and fail loudly if start fails, instead of always reporting "started").
- Tests: Pester for Get-ToolSummaryLine, Invoke-WithHeartbeat, and source guards
for the 6-step split + no-raw-k3d-output.
The copy catalog is bash-driven and the bash installer already splits check
(step a) from install (step b) with real progress, so its golden is unaffected.
Closes#422
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#422): job-runspace TLS 1.2 floor + k3d start exit-code check (Bugbot)
Two High-severity findings from moving work into Start-Job via Invoke-WithHeartbeat:
- TLS 1.2 doesn't carry into job runspaces (PS 5.1 defaults to TLS 1.0/1.1), so
in-job HTTPS downloads (kubectl/k3d/helm/winget/Docker Desktop) could fail
SSL/TLS on hosts that need the explicit floor. Re-apply Tls12 in $script:JobInit
(OR-in, don't clobber), which every job runs before its scriptblock.
- A native `k3d cluster start` non-zero exit leaves the job state 'Completed', so
Invoke-WithHeartbeat never threw and the installer reported "Compute environment
started." on a stopped cluster. The start scriptblock now checks $LASTEXITCODE
and throws its captured output, so the existing catch surfaces a real Err.
Adds a functional in-job-TLS test and a source guard for the exit-code throw.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#422): surface heartbeat failure detail + fail loudly on Docker install (Bugbot)
Two follow-on findings from the Start-Job/heartbeat design:
- Invoke-WithHeartbeat threw a generic 'Failed while: ...' and swallowed the
job's real error (Receive-Job -ErrorAction SilentlyContinue), so the k3d-start
detail never reached the log/Err. Now capture output+error (2>&1) and the job's
terminating reason, and include it in the throw; the k3d-start catch passes it
as Err detail too.
- The Docker Desktop installer Start-Process had no -ErrorAction Stop and no exit
check, so a spawn/install failure completed the job as success and Step 2
continued. Now -ErrorAction Stop + PassThru + exit-code throw, wrapped so it
Errs cleanly with the real detail.
Adds a heartbeat failure-detail test + a Docker-installer source guard.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#422): print k3d/helm summary only after the execute-gate (Bugbot)
k3d and helm printed their green Get-ToolSummaryLine 'ready' line inside the
download branch, before Assert-ToolRuns — so a corrupt/wrong-arch binary showed
as ready and then failed the gate (kubectl already gates first). Compute the
summary at download time (correct elapsed) but defer the Ok until after the
execute-gate passes. Adds a source guard.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#422): winget Docker install falls back + fails loudly (Bugbot)
The winget Docker path soft-logged failures, never checked $LASTEXITCODE, and
had no direct-download fallback when winget was present — so a failed winget
install let Step 2 continue and only surfaced as the 10-minute Docker-wait
timeout later. Now: the winget scriptblock throws on a non-zero exit; if winget
is absent OR didn't land the exe, fall through to the direct download (parity
with k3d/helm); and a final Test-Path guard Errs immediately if neither path
installed Docker. Adds a source guard.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#422): run installers as killable processes, not orphan-prone jobs (Bugbot)
Start-Process -Wait / winget install inside Invoke-WithHeartbeat (a background
job) leaks the child process on timeout: Stop-Job ends the job runspace but the
installer keeps running, and the winget path could time out then fall through to
a second concurrent install. Switch the Docker Desktop installer + all winget
installs (Docker, k3d, helm) to Start-Process -PassThru + Wait-ProcessWithDeadline,
which shows the spinner AND kills the actual process on timeout, then checks the
exit code. Downloads (Invoke-WebRequest) stay on Invoke-WithHeartbeat — no child
process to orphan. Updates the Docker source guards accordingly.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#422): run k3d cluster start as a killable process too (Bugbot)
Same orphan hazard as the installers: k3d cluster start ran inside
Invoke-WithHeartbeat (a job), so Stop-Job on timeout left the native k3d child
running. Switch it to Start-Process -PassThru + Wait-ProcessWithDeadline (kills
on timeout), redirecting its raw INFO[...] to temp files for the log; check both
the deadline and the exit code so a failed/stuck start Errs with the real reason
instead of a false 'started'. Now every process-spawning op is killable; only
in-runspace downloads + Add-AppxPackage remain on the job-based heartbeat.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
LukasWodka added a commit that referenced this pull request Jul 30, 2026
* chore(chart): close values-schema gaps + drop dead override/code/docs (#963) (#457)
* chore(chart): close values-schema gaps + drop dead override/code/docs (#963)
Contract fixes for the client Helm chart (re-verified against develop at
chart v1.9.6; the #963 audit was taken at v1.8.4):
- values.schema.json: add the six live-but-unvalidated keys so bad values
fail `helm lint` instead of silently passing —
egressReachabilityCheck.enabled, ingestionAuthz.{allowed,serviceAccountName},
networkPolicy.training.enforcementProbeTimeoutSeconds, podTokenSigningSecret,
podTokenTtlSeconds. Types/defaults/constraints taken from values.yaml and
the templates that consume them. helm lint passes.
- ingestor subchart: remove the dead `image.repository` key — no template
ever rendered it (jobs-manager spawns from the parent chart's
images.ingestor.repository). Kept image.digest (live). README's air-gapped
override rows now point at the authoritative parent-chart path.
- README: drop the hardcoded chart version (said v1.3.5 while Chart.yaml is
1.9.6) and point to Chart.yaml / the releases page, so it can't drift again.
- Delete the unwired check_docker_arch_mac function + its bats test (no call
sites) and the orphaned docs/eks.md (referenced nowhere).
Part of tracebloc/backend#963.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* chore(installer): regenerate manifest after common.sh trim + develop merge
The #963 chart-contract cleanup dropped 48 dead lines from
scripts/lib/common.sh, changing its sha; the installer manifest wasn't
regenerated, so the Static analysis gate (gen-manifest.sh --check) failed.
Merging develop also refreshed preflight.sh/install-k8s.ps1 hashes.
Regenerate scripts/manifest.sha256 to match the working tree.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Syed Saqlain <syedsaqlain@MacBook-Pro.local>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* fix(release): package charts as the tag version + pre-releases skip gh-pages (#467)
* fix(release): package charts AS the tag version + pre-releases skip gh-pages
Incident 2026-07-29: the v1.9.7-rc.1 pre-release packaged the client chart
from Chart.yaml's plain 1.9.7 and pushed it into the public helm index as
a STABLE version -- customers running helm upgrade would have received
staging content (removed from the index by hand, tgz deleted). Two layers
now prevent it: (1) helm package --version/--app-version from the release
tag, so rc charts carry the -rc.N suffix helm's pre-release rules key on;
(2) pre-releases never run the gh-pages index steps at all -- FR consumes
the release assets (stamped installer / chart tgz), the index is a
customer surface reserved for finals.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix: gh-pages gates key on verify's tag-derived prerelease, not the frozen event (Bugbot)
github.event.release.prerelease is an event-time snapshot: after verify
demotes a mis-marked release, it still reads false, so the demoted rc
would have entered the public index anyway. verify now outputs effective
prerelease-ness derived from the tag shape (the same strict rule the
demotion uses) and all three gh-pages steps gate on that output.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* feat: post-publish index-invariant job (manual leak catch -> CI)
After every release run: the public index must contain only stable-shaped
versions, and a prerelease run must not have indexed its own version.
Fails loudly; would have caught the 1.9.7 leak within a minute of it
happening instead of during manual FR.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* feat(install): rootless Docker core + Tier-1 routing (opt-in) (#1219) (#452)
* feat(install): rootless Docker core + Tier-1 routing (opt-in)
Add install_rootless_docker() and a Tier-1 early-branch in install_linux
so a modern-kernel host with no runtime and no root can install entirely
in user space (RFC 0001 Tier 1 — the RFC's primary path). Gated behind
opt-in TB_TIER1_ROOTLESS=1; with the flag unset a Tier-1 host falls
through to the legacy privileged flow unchanged (validated default).
- install_rootless_docker: uidmap-helper precondition (defers to
prepare-host #1178 when absent — never self-sudo), no-sudo install via
dockerd-rootless-setuptool.sh or get.docker.com/rootless, user-scoped
systemctl --user + loginctl enable-linger, DOCKER_HOST export with
XDG_RUNTIME_DIR fallback, single docker-info verify (no retry loop).
- Tier-1 branch mirrors the Tier-0 early-return. Tools still install via
sudo here (_set_tools_target keys no-sudo off Tier 0 only) — tightening
that for rootless Tier 1 is deferred to slice 3 (#1221).
- 6 bats cases; scripts/manifest.sha256 regenerated (R8).
Closestracebloc/backend#1219
Part of tracebloc/backend#1177 · Epic tracebloc/backend#1168
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: address Bugbot review on rootless Docker core (#452)
- Prepend ~/bin to PATH after the rootless install so this run's docker
info verify + later k3d/docker calls resolve the CLI the
get.docker.com/rootless fallback installs there (High).
- Bound the rootless `docker info` verify with a new shared _bounded
helper (timeout/gtimeout, mirrors probe.sh) so a wedged user daemon
can't hang a headless install (Medium).
- Guard the user-systemd bring-up under set -e: `systemctl --user … ||
true` (the bounded verify is the real gate) and `loginctl
enable-linger … || warn` (optional; fails on polkit-locked hosts even
when the daemon is up) (Medium).
Adds 2 bats cases (~/bin on PATH; systemd/linger failure falls through
to the verify). Manifest regenerated (R8).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: correct the uidmap remedy message (Bugbot #452)
The missing-uidmap error claimed prepare-host would install the uidmap
helpers, but run_prepare_host only sets up privileged Docker + the docker
group — it never installs uidmap. Point at the two honest remedies
instead: install the `uidmap` package directly (rootless then works), or
run prepare-host to set up Docker so the researcher installs at Tier 0
(no rootless needed). #1220 folds this into the shared subuid/subgid gate
and teaches prepare-host to install uidmap for real.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* docs(install): TODO(#1221) — rootless daemon needs user-scoped proxy config
Bugbot on #452 flagged that install_rootless_docker never configures a
corporate proxy for the user-scoped dockerd (the #244 _configure_docker_proxy
is sudo/system-scoped and the Tier-1 early-return never reaches it), so k3d
pulls of rancher/k3s time out on proxy-only hosts. Deferred to #1221 (the
k3d-on-rootless-socket slice that owns the pulls); leaving a tracked TODO so
the follow-up adds the user-scoped drop-in.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: address Asad review nits on #452 — chmod no-op + misleading comment
- Drop the chmod +x on the rootless installer script: it runs via
`sh "$rootless_script"`, which ignores the exec bit.
- Reword the Tier-1 _install_userspace_tools comment: tools still
sudo-install on Tier 1 (only _persist_tools_on_path is no-sudo);
the comment previously implied otherwise.
The underlying _set_tools_target sudo-crash on no-sudo hosts and the
post-install DOCKER_HOST shell persistence are tracked to #1221.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: resolve user via id -un in install_rootless_docker (Saqlain review, #452)
$USER can be empty in headless / su / cron contexts (a Tier-1 target),
which would break `loginctl enable-linger` and the success line. Resolve
the user once via `id -un` (fallback $USER) and use it for the linger
call, its hint, and the success message. Matches the id-based robustness
DOCKER_HOST already uses. Happy-path bats now mocks `id -un` cleanly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* ci: add code-quality caller workflow (advisory) (#463)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* Add pre-commit hooks (Layer 0, lint-only) (#465)
* Add pre-commit config (Layer 0, lint-only)
Lint-only on purpose: scripts/manifest.sha256 must keep matching the bytes
under scripts/, so no hook may rewrite files.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Document pre-commit setup in README
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* docs: add Bugbot resolve-and-reply team norm to .cursor/BUGBOT.md (#464)
Part of tracebloc/backend#1308
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* ci: cover scripts/resolve-ingestor-digest.sh in CI shellcheck (#466)
* ci: lint scripts/resolve-ingestor-digest.sh in CI shellcheck (was never linted)
Both CI shellcheck invocations enumerate files explicitly and both omitted
this script. Verified clean against shellcheck --severity=error --shell=bash
0.11.0 before adding. The pre-commit hook from #465 already covers it
locally; this closes the same gap on the CI side.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* ci: lint scripts/resolve-ingestor-digest.sh in CI shellcheck (was never linted)
Both CI shellcheck invocations enumerate files explicitly and both omitted
this script. Verified clean against shellcheck --severity=error --shell=bash
0.11.0 before adding. The pre-commit hook from #465 already covers it
locally; this closes the same gap on the CI side.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): honest cosign bootstrap download + translated DISM failures (#468) (#469)
The v1.9.7-rc.1 FR killed a healthy install: PS 5.1's progress overlay
throttled the 17 MB pinned-cosign fetch to ~4.5 min of dead silence and
the window read as frozen.
- silence the PS 5.1 progress overlay in Get-WithRetry/Get-Optional
(function-local, auto-reverts) - the classic 10-50x IWR speedup
- run the cosign fetch in a background job with a dim liveness tick
(Wait-JobWithTicks / Get-OptionalWithTicks; cwd pinned per #409,
TLS 1.2 re-applied in the fresh process), expectation lines before,
elapsed + checksum-verified confirmation after
- ASCII-only string literals in both installers: the release asset is
served without a charset so PS 5.1's irm decodes UTF-8 source as
Latin-1 before iex, and BOM-less -File reads are ANSI - literal
em-dashes/ellipses reached customers as mojibake. Locked in by a
tokenizer-based Pester test (which also caught the -Help here-string).
- Enable-OneVirtFeature: translate DISM's raw COMException (feature
package absent on Server SKUs vs enable failure) and stop demanding
a reboot for a feature that never enabled (old code sent Server
users into a reboot->re-run->same-error loop)
Pester: 212 passed / 0 failed locally (pwsh 7.5, Pester 5.7.1).
PSScriptAnalyzer: 0 errors. manifest.sha256 regenerated.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(installer): trust the corporate MITM CA in the k3d nodes (#424) (#453)
* fix(installer): trust the corporate MITM CA in the k3d nodes (#424)
Proxy REACHABILITY reaches the nodes, but on a TLS-inspecting (break-and-
inspect) network the nodes still don't TRUST the corporate CA, so every in-node
containerd pull (rancher/k3s, ghcr.io, tracebloc images) fails x509 — then
masked (helm runs without --wait) into a root-cause-free "an image couldn't be
pulled." Enterprise/hospital archetype, all three OSes.
- Inject the CA at create time: when TRACEBLOC_CA_BUNDLE (or CURL_CA_BUNDLE) is
set, mount the bundle into every k3d node and write a registries.yaml pointing
containerd at it per-registry (docker.io, registry-1.docker.io, ghcr.io), via
the same --config/create path that already carries proxy env. Parity across
scripts/lib/cluster.sh (Linux/macOS) and install-k8s.ps1 (Windows). A CA var
set but unreadable fails loudly instead of silently skipping.
- Name the env var where the user hits the wall: the TLS-interception preflight
hint (both OSes), docs/INSTALL.md, and the PS -Help env-var list.
- CA-aware diagnosis: detect x509 / "certificate signed by unknown authority"
pull events and report a dedicated image_pull_ca state — "the cluster does not
trust your network's TLS-inspection CA" + the exact remedy — instead of the
generic pull error. Mirrored in summary.sh and Print-Summary.
- New check-drift.sh parity check (_drift_ca_trust) so neither installer can drop
the CA wiring for the other's OS.
Tests: +8 cluster.bats, +3 summary.bats, +2 check-drift.bats, +8 Pester.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): CA-trust hardening — no fail-open, bounded events, verify CA readable (Bugbot #424)
Three Bugbot findings on #424:
- _write_k3d_registries_config failed open: on mktemp failure it returned success
with no path, so create still mounted the CA and logged "nodes trust it" but
dropped --registry-config → containerd never got ca_file, x509 pulls still fail
while the operator thinks it's fixed. Now returns non-zero; the caller hard-errors
(CA was supplied, so we refuse to proceed without wiring it in).
- PS Get-NotReadyState `kubectl get events` had no --request-timeout (the bash path
does) — on a wedged/proxy-misrouted API, classification could hang. Added
--request-timeout=5s to match _diagnose_not_ready.
- PS Resolve-CaBundle only checked existence (Test-Path), not readability, so an
unreadable CA passed on Windows but bash (-r) hard-fails. Added an OpenRead probe
so both fail the same way, up front.
Tests: cluster.bats +mktemp-failure + unwritable-registries-hard-error;
install-k8s.Tests.ps1 +unreadable-CA (Unix) + events --request-timeout assertion.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): errexit-safe CA-resolve capture + drift check ignores comments (Bugbot #424 r2)
Two round-2 Bugbot findings:
- Under `set -euo pipefail`, `ca_bundle="$(_resolve_ca_bundle)"; ca_rc=$?` exited on
the rc-2 (unreadable/missing CA) BEFORE ca_rc/error ran — operators got a bare
exit instead of the "can't be read" guidance. Capture with `|| ca_rc=$?` so
errexit doesn't fire and the guidance prints.
- _drift_ca_trust whole-file grep matched tokens in comments (e.g. --registry-config
appears in a comment above the real line), so deleting the functional wiring could
still pass. Strip comment lines first (matches the execute-gate / preflight-host
checks), no grep -q under pipefail.
Tests: cluster.bats +errexit-safe-capture; check-drift.bats +comment-only-token drift.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): TLS-preflight hint names the right var per layer/OS (Bugbot #424 r3)
The hint claimed TRACEBLOC_CA_BUNDLE makes "the host AND the k3d nodes" trust the
CA, but the host connectivity checks use curl_secure / Invoke-WebRequest, which
read CURL_CA_BUNDLE / the system trust store — not TRACEBLOC_CA_BUNDLE (that var
only reaches the nodes via _resolve_ca_bundle). Following the hint literally left
host preflight TLS failures unchanged. Corrected, no behaviour change:
- bash: CURL_CA_BUNDLE fixes these host checks AND the nodes; TRACEBLOC_CA_BUNDLE
is nodes-only; or add the CA to the system trust store.
- Windows: import the CA into the cert store for the host checks (Invoke-WebRequest
uses the store, not an env var); TRACEBLOC_CA_BUNDLE/CURL_CA_BUNDLE cover the nodes.
(Reworded to avoid a bare lowercase `curl` that the curl_secure style guard flags.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): apply CA on cluster REUSE path — warn + recreate guidance (Bugbot #424 r4)
The image_pull_ca remedy said "set the CA and re-run", but CA trust is baked in
only at fresh create; a re-run reuses the existing cluster and never mounts the CA
or passes --registry-config, so the x509 pulls persisted. Mirror the existing
proxy handling (baked-at-create → warn on reuse):
- bash _check_existing_cluster_ca (called from _handle_existing_cluster): warns when
a CA bundle is set but the reused server container lacks the CA mount.
- ps1 New-K3dCluster reuse block: same check via docker inspect mounts.
- both image_pull_ca remedies now say to `k3d cluster delete <name>` first, then
re-run with the CA (CA, like proxy, can't be added to a running cluster).
Tests: cluster.bats +3 (no-CA no-op / CA-but-missing-mount warns / mount-present silent).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): add auth.docker.io to the CA registries config (Bugbot #424 r5)
The registries.yaml ca_file entries covered docker.io / registry-1.docker.io /
ghcr.io, but Docker Hub pulls also TLS-handshake with auth.docker.io for bearer
tokens — so on a break-and-inspect network containerd still rejected the
intercepted cert there even with the CA mounted. #416 already probes auth.docker.io
at preflight; the CA registries list now matches. Added to TB_CA_REGISTRIES and
$TbCaRegistries; registries.yaml test counts 3 -> 4.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#424): _resolve_ca_bundle rejects a directory, not just unreadable paths
A directory of PEMs is readable (-r) but would bind-mount over the single
node ca_file path and containerd can't read it — the silent 'looks applied
but still x509' case. Require a regular file (-f), mirroring the PS
Resolve-CaBundle -PathType Leaf check. Adds a directory-reject bats case.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#424): exact whole-line match for CA mount detection (Bugbot)
_check_existing_cluster_ca used a substring test on docker mount
destinations, so a longer path embedding /etc/ssl/certs/tracebloc-mitm-ca.crt
(e.g. …crt.bak) would be treated as the CA mount and skip the recreate
warning while containerd still x509-fails. Switch to grep -qxF (exact
whole-line), matching the PS anchored regex. Adds a substring-embed test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#424): scope x509 classification to the pull-failure event (Asad)
_diagnose_not_ready / Get-NotReadyState flagged image_pull_ca on ANY x509
event in the namespace, so a stale/unrelated x509 event (e.g. a FailedMount)
could misdirect the user into a needless delete+recreate. Filter events to
the image-pull failure lines (failed to pull / ErrImagePull) before testing
x509, in both bash and PS. Adds an unrelated-x509 test to each side.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* feat(chart): perIngestionTables — RFC-0003 D16 enablement knob (backend#1205) (#472)
* feat(chart): perIngestionTables — the RFC-0003 D16 enablement knob (backend#1204/#1205)
values.perIngestionTables (default false, schema-typed) renders
PER_INGESTION_TABLES=1 onto the jobs-manager, which forwards it into
every ingestion Job it spawns (client-runtime companion PR). Flip per
environment, dev first, only once that environment's backend + engine
images + jobs-manager carry the merged D-series. Default installs
render byte-identically (conditional block; unit tests pin both sides).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(values): own banner for perIngestionTables — it is not part of the authz section (review)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* chore: clear house-rules findings (#470)
Fix every finding the shared org checker (tracebloc/.github
scripts/house-rules.sh) reports at develop HEAD: missing curl
timeouts/TLS floors, plus (cli) a missing pipefail. Waivers only where
the finding is a documented false positive. Part of tracebloc/backend#1303.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(install): Tier-1 subuid/subgid gate + prepare-host remediation (#1220) (#458)
* feat(install): Tier-1 subuid/subgid gate + prepare-host remediation
RFC 0001 #1220. Detect the one privileged residue a modern rootless host may
still need — a subordinate UID/GID range + the setuid uidmap helpers — and
either proceed (present), hand off to prepare-host (unprivileged), or perform
one announced touch (sudo available). Never blanket sudo, never an opaque
mid-install crash inside dockerd-rootless-setuptool.sh.
- probe.sh: _probe_subid_ranges (PROBE_SUBID) + _probe_uidmap_helpers
(PROBE_UIDMAP), set in run_host_probes (Linux only), plus audit rows on
the Tier-1 path.
- common.sh: shared pure parsers _subid_has_entry + _next_subid_start, used
by both the probe and the remediation (no duplication).
- setup-linux.sh: _ensure_subid_ranges gate (present / hand-off / one
announced sudo touch) called before install_rootless_docker;
_provision_subid_ranges (idempotent, non-overlapping block, usermod
--add-subuids with file-append fallback, uidmap install) shared by the
installer and run_prepare_host. Folds in slice-1's minimal uidmap check.
- Tests: probe.bats + setup-linux.bats. Manifest regenerated (R8).
Closestracebloc/backend#1220
Part of tracebloc/backend#1177 · Epic tracebloc/backend#1168
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): address #458 review — subid gate/probe/hand-off robustness
Bugbot + @saadqbal + a self code-review on client#458, all in slice-2's code:
- id -un everywhere (gate, _provision default, probe): $USER diverges from the
rootless daemon's user under su/cron, which wedged detection/provisioning (#1).
- Re-verify the uidmap helpers are usable (present AND setuid|cap_setuid) after
install, and return non-zero + warn (NOT error/exit) so run_prepare_host stays
best-effort while the installer sudo-path hard-fails via `|| error` (#2 + self-review).
- _idmap_helper_ok (common.sh): accept the setuid bit OR a cap_setuid filecap, so
Arch's `shadow`/pacman path isn't false-rejected (#3).
- Hand-off + run_prepare_host fallback compute a non-overlapping start via
_next_subid_start (honoring TB_SUBUID_FILE/TB_SUBGID_FILE), not hardcoded 100000
(#4 + self-review path-override).
- Hand-off command names the researcher (TB_PREPARE_USER=) — bare prepare-host
provisions nothing, so it would have looped back to the same hand-off (#5).
- Capture `usermod --help` before grepping — pipefail-safe (#6).
bats: id -un mocks, filecaps accept/reject, gate hand-off (names user + computed
start), _provision re-verify best-effort, run_prepare_host best-effort. R8 regen.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(install): stub the subid gate in the Tier-1 rootless routing test
install_linux's Tier-1 branch now calls _ensure_subid_ranges (slice 2)
before install_rootless_docker; the routing test left it un-stubbed, so the
real gate hit the no-sudo hand-off and error()'d → install_linux returned
non-zero. Stub _ensure_subid_ranges (its own behavior is covered by the
dedicated gate tests) and assert it runs before daemon setup.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(install): scope set -o pipefail to a subshell (bats harness footgun)
Setting `set -o pipefail` in the @test body can leak into bats' own
post-test pipelines and fail the whole run with exit 1 even when every
test reports ok (no 'not ok'). Confine it to a subshell around the call
so the pipefail-safety assertion still holds without touching the harness.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): style guard — no bare curl in the prepare-host hint
The hand-off piped 'curl … | TB_PREPARE_USER=… bash', which breaks
check-style.sh's exemption for the canonical 'curl … | bash' one-liner
(the env var sits between the pipe and bash). Split into an 'export
TB_PREPARE_USER=…' line + the canonical piped one-liner — still names the
researcher, and passes the guard. Verified with scripts/check-style.sh.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): fix the #458 red bats + 2 Bugbot bugs (newgidmap cap, write-failure)
Root cause of the "540 ok but exit 1" bats red: the probe.bats uidmap tests set
PATH="$bin" in the test body to hide system helpers, which also hides `rm` — so
bats-core 1.10+ can't run its own per-test cleanup ("rm: command not found") and
fails the whole run even though every test passes. Scope the hermetic PATH to a
subshell so it can't leak into bats' machinery. (Why develop was green + this was
so hard to see: these tests are new in slice 2, and the symptom is a clean pass
list with a non-zero exit.)
Two real Bugbot findings in the slice's own code:
- _idmap_helper_ok checked cap_setuid for BOTH helpers; newgidmap carries
cap_setgid (Arch filecaps) -> false-rejected. Map name->cap; fix the test mock
that masked it + add a wrong-cap regression test.
- _provision_subid_ranges printed success/returned 0 even when the usermod/tee
write failed (callers run it with set -e off) -> installer proceeds with no
range. Guard every write; warn + return 1 on failure. + a test.
Verified: probe.bats + setup-linux.bats EXIT 0 (0 not-ok, 0 rm-not-found) in a
faithful ubuntu 24.04 + bats 1.10 + non-root container. Rebased onto develop.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): 2 more Bugbot findings on #458 (apt hang, false zero-root message)
- _install_uidmap_pkg ran a bare `sudo apt-get install -y uidmap` under the
spinner — no needrestart/DEBIAN_FRONTEND env, no DPkg::Lock::Timeout, no
apt_wait_for_lock — so a headless Tier-1 install can hang on Ubuntu needrestart
or an apt-daily lock (#210 class). Reuse the repo's hardened PM_INSTALL
(populate via setup_pm, which Tier 1 skips) + apt_wait_for_lock.
- install_rootless_docker always printed "no administrator rights were used",
even after _ensure_subid_ranges performed an announced sudo touch on the
root/sudo_nopw path. The gate now sets TB_ROOTLESS_ADMIN_TOUCH and the summary
is honest on both the zero-root and one-admin-touch paths.
Tests: hardened-install assertion (NEEDRESTART_MODE + DPkg::Lock::Timeout) + a
success-message honesty test. Verified EXIT 0 (0 not-ok, 0 rm-errors) in the
faithful ubuntu 24.04 + bats 1.10 + non-root container.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): refresh the package index in _install_uidmap_pkg (Bugbot #458)
Completing the prior apt-hardening: _install_uidmap_pkg populated PM_INSTALL and
waited for the dpkg lock but never ran PM_UPDATE. On the Tier-1 path this is the
first package op, so an empty/stale index can't locate uidmap/shadow and the
install hard-stops. Run $PM_UPDATE (best-effort) first, matching the repo's other
install paths (setup-linux.sh:335/543). Test asserts the index refresh.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(installer): silence the PS 5.1 progress throttle in install-k8s.ps1 downloads (#468 follow-up) (#471)
Same class as the bootstrap fix in #469: PS 5.1's progress overlay
throttles Invoke-WebRequest 10-50x and reads like a hang. One
function-local $ProgressPreference in Invoke-WithRetry covers every
fetch scriptblock it drives (dynamic scoping) - winget msixbundle,
Docker Desktop fallback, kubectl, k3d, helm, GPU plugin yaml, and the
version resolvers.
Honest-progress expectation lines (sizes measured today via HEAD):
Docker Desktop ~600 MB, winget ~200 MB, kubectl ~60 MB, k3d ~25 MB,
helm ~20 MB - all cold-path only, silent on warm re-runs.
Pester: 205 passed / 0 failed locally. PSSA: 0 errors.
manifest.sha256 regenerated.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: shujaat hasan <shujaat@tracebloc.io>
* fix(installer): trust the corporate CA in the Docker daemon for k3d runtime image pulls (#474) (#475)
* fix(#474): detect host Docker daemon x509 at cluster-create + document daemon CA trust
k3d pulls its own runtime images (rancher/k3s, k3d-tools, k3d-proxy) with the
HOST Docker daemon, which doesn't use the in-node CA trust from #424. On a
TLS-inspecting network that pull can x509-fail during 'k3d cluster create',
before any node boots — so the post-create diagnosis never classifies it.
- bash: _host_ca_create_hint() detects x509 in the k3d create output and prints
a platform-aware remedy (Linux system trust store vs Docker Desktop VM);
wired into _create_new_cluster's failure path.
- PS: Write-HostCaCreateHint() mirrors it (Windows Trusted Root store), wired
before the generic create failure.
- docs/INSTALL.md: document trusting the CA in the daemon itself (Linux /
Docker Desktop).
- check-drift.sh: enforce both installers keep the host-CA hint (parity).
- Tests: bats (Linux/macOS branches + silent-on-no-x509) + Pester + drift.
Closes#474
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#474): distro-aware Linux CA remedy + actionable Docker Desktop for Linux (Bugbot)
- Linux native-Docker remedy now covers both Debian/Ubuntu (update-ca-certificates)
and RHEL/Fedora (update-ca-trust), not just the Debian path — the installer
supports RHEL hosts where the Debian commands fail.
- Docker Desktop for Linux now has an actionable step (trust in the system store,
restart Docker Desktop) instead of a dangling reference to a step only printed
on the macOS branch.
- docs/INSTALL.md updated to match. bats Linux test asserts both distro paths.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#474): cover Colima runtime in the macOS host-CA remedy (Bugbot)
Headless macOS installs use Colima (_install_docker_colima), a Lima VM that
does not read the macOS keychain — so the 'trust it in the keychain + restart
Docker Desktop' remedy was wrong for those hosts. The macOS branch now also
gives the Colima path (add the CA inside the VM via 'colima ssh', then
'colima restart'). docs/INSTALL.md + macOS bats test updated to match.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test(#474): isolate drift negative fixtures so a missing new token can't mask them (Bugbot)
Adding _host_ca_create_hint / Write-HostCaCreateHint as required _drift_ca_trust
tokens meant the older negative fixtures (missing registry-config, comment-only
registry-config) could pass just because the new token was also absent — so the
comment-strip case no longer uniquely proved comment-stripping still works. Each
negative fixture now carries ALL other required tokens and omits/comments only
the one under test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#474): surface host-CA hint on the PS create-timeout path too (Bugbot parity)
The PowerShell create-timeout branch exited via Err without calling
Write-HostCaCreateHint (and deleted the k3d logs first), so a TLS-inspected
host pull that logs x509 then hangs to the deadline gave Windows operators a
raw timeout with no certlm.msc CA guidance — while bash runs _host_ca_create_hint
on its timeout fall-through. Capture the full create output before deleting the
logs and call the hint before the timeout Err. Adds a parity regression test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#474): use a herestring in _host_ca_create_hint to survive pipefail (Asad)
printf '%s' "$out" | grep -qiE ... could swallow the hint under set -o pipefail:
grep -q closes the pipe on first match, so for output past the ~64KB pipe buffer
(reachable on the timeout path, which passes the full logs) printf takes SIGPIPE,
the pipeline exits non-zero, and `|| return 0` bails even though x509 matched.
Feed grep via a herestring (no pipe, no SIGPIPE). Adds a >64KB-under-pipefail
regression test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* feat(install): Tier-1 k3d-on-rootless + cgroup delegation + autostart (#1221) (#478)
* feat(install): Tier-1 k3d-on-rootless + cgroup delegation + autostart (#1221)
Slice #1221 (RFC 0001 / #1177): make a rootless Tier-1 cluster actually usable,
all behind the opt-in TB_TIER1_ROOTLESS flag (default off until the spike's §5
host validation). With the flag unset every path below is a no-op and current
behavior is byte-for-byte unchanged.
- Shared _rootless_active predicate (common.sh) so cluster.sh + setup-linux.sh
can't drift on the flag pair.
- create_cluster targets the rootless socket (DOCKER_HOST); ensure_cluster_
autostart gets a user-scope branch (systemctl --user enable + loginctl
enable-linger, never `sudo systemctl enable docker`), and promises
reboot-survival only when BOTH succeed (honesty rule, #375/#458).
- cgroup v2 controller delegation drop-in (Delegate=cpu cpuset io memory pids):
privileged write + daemon-reload on root/sudo, or hand off to prepare-host
with the exact path+content when unprivileged. run_prepare_host writes it too
(system-wide -> covers the researcher).
- Carry-ins from #452/#458: scope-aware _configure_docker_proxy (user scope, no
sudo) so a proxy-only host's rootless daemon can pull rancher/k3s;
_set_tools_target installs user-space on rootless Tier 1 (no sudo-mv crash on
a true no-sudo host); persist DOCKER_HOST to the shell rc for new terminals.
14 new bats tests incl. flag-off regressions; shellcheck --severity=error clean;
manifest.sha256 regenerated (R8).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): address Bugbot on #478 — rootless autostart seed + admin-touch msg
- ensure_cluster_autostart: don't seed TB_DOCKER_AUTOSTART from the SYSTEM
docker.service is-enabled check on the rootless path. The cluster runs on the
per-user rootless socket, so a system unit that happens to be enabled would seed
a false reboot promise the rootless branch then can't honestly retract. On
rootless the user-scope enable+linger are now the sole authority (Bugbot medium).
- install_rootless_docker: the TB_ROOTLESS_ADMIN_TOUCH success line no longer
hardcodes "subuid/subgid range" — _ensure_cgroup_delegation can set that flag
too, so it now names "host prerequisites (subuid/subgid range and/or cgroup
delegation)" (Bugbot low).
- Test: rootless + system docker.service enabled + user-enable fails => flag stays
0 (pins the seed-guard). manifest regenerated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): address Asad + Saqlain review on #478
- _persist_docker_host: key idempotency off our own marker, not a bare
'DOCKER_HOST=' probe. The old probe also matched a user's own DOCKER_HOST
(remote/TCP), so we silently skipped persisting the rootless socket and new
shells kept hitting the wrong daemon. Now: our own line -> idempotent; a foreign
DOCKER_HOST -> left untouched + a warn to repoint it (Asad #2 + Bugbot #478, Medium).
- ensure_cluster_autostart: reset TB_DOCKER_AUTOSTART=0 in the rootless else-branch
(defensive; the is-enabled seed is already guarded off the rootless path) so the
honesty guarantee is local to the branch (Asad #1).
- install_rootless_docker: success line now reads "one or more one-time admin steps"
so it doesn't undercount when both the subuid and cgroup touches happen (Saqlain #1).
- Test: foreign DOCKER_HOST -> warns, no clobber, no double-write. manifest regen.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(installer): failures surface the real error + log path + support-bundle hint (#423) (#476)
* fix(#423): failures surface the real error + log path + support-bundle hint
Fatal errors printed a generic red line while the actionable detail (k3d/helm
stderr) went only to the transcript, and the log path itself was never shown on
screen. Now:
- Err gains an optional $Detail param; Get-ErrDetailLines (pure, unit-tested)
renders the last ~5 non-empty output lines + the log path + a '-Diagnose'
next-step hint, appended to EVERY fatal error.
- Cluster-create failure passes k3d's stdout/stderr so the real reason (image
pull / proxy / port / WSL) shows on screen — the motivating case.
- Helm repo-add / reconcile / install failures pass helm's output via $Detail
instead of embedding it (no more duplicated log-path text).
- Install log path is announced up front in the banner (was log-only before).
Closes#423
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#423): force array enumeration of Err detail lines (Bugbot, defensive)
Bugbot flagged that a single-line Get-ErrDetailLines return (no detail + no
LOG_FILE, e.g. a Confirm-Config failure before Start-InstallLog) unwraps to a
scalar string. The foreach statement already iterates a scalar once (verified:
it prints the whole line, not per-character), so the reported char-splitting
does not reproduce -- but wrap the enumeration in @(...) to make that
unambiguous and future-proof. Adds a regression test asserting the single-line
case stays one intact line.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#423): strip PS 5.1 ErrorRecord chrome from the failure excerpt (Bugbot)
helm failures arrive as `native 2>&1 | Out-String`; on Windows PowerShell 5.1
that wraps stderr in ErrorRecord chrome (the `At <file>:<n> char:<n>` position
line plus the `+ ...` / `+ CategoryInfo` / `+ FullyQualifiedErrorId` block).
Get-ErrDetailLines kept only the last 5 non-empty lines, so the excerpt was all
chrome and the real `Error:` line dropped out -- a regression from the previous
full-message dump. Filter those chrome lines before taking the window so the
actual error survives. Adds a regression test simulating the 5.1 rendering.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#423): drop duplicate inline log-path hints (Bugbot)
Err now always prints the log path via Get-ErrDetailLines, so the k3d
spawn-failure and create-timeout paths that still Hint "Full log:" right before
Err printed it twice. Remove those inline hints; Err is the single source. Adds
a guard test asserting no inline 'Full log:' hints remain in the installer.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#423): put stderr last in the create-failure Err detail (Asad)
Get-ErrDetailLines keeps the LAST 5 non-empty lines, so with detail ordered
stderr-then-stdout any k3d stdout tail could crowd the real stderr reason
(FATA/x509/port) out of the excerpt. Order it stdout-then-stderr so the stderr
tail survives the window; also matches the Write-HostCaCreateHint order just
above.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Syed Is Saqlain <saqlain.syed007@gmail.com>
Co-authored-by: Syed Saqlain <syedsaqlain@MacBook-Pro.local>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Arturo Peroni <arturo@tracebloc.io>
Co-authored-by: shujaat_tracebloc <153823837+shujaatTracebloc@users.noreply.github.com>
Co-authored-by: shujaat hasan <shujaat@tracebloc.io>
Co-authored-by: tracebloc-release-train[bot] <309815517+tracebloc-release-train[bot]@users.noreply.github.com>
LukasWodka added a commit that referenced this pull request Aug 15, 2026
…pying it (#723)
* release-train: staging -> main (#495)
* chore(chart): close values-schema gaps + drop dead override/code/docs (#963) (#457)
* chore(chart): close values-schema gaps + drop dead override/code/docs (#963)
Contract fixes for the client Helm chart (re-verified against develop at
chart v1.9.6; the #963 audit was taken at v1.8.4):
- values.schema.json: add the six live-but-unvalidated keys so bad values
fail `helm lint` instead of silently passing —
egressReachabilityCheck.enabled, ingestionAuthz.{allowed,serviceAccountName},
networkPolicy.training.enforcementProbeTimeoutSeconds, podTokenSigningSecret,
podTokenTtlSeconds. Types/defaults/constraints taken from values.yaml and
the templates that consume them. helm lint passes.
- ingestor subchart: remove the dead `image.repository` key — no template
ever rendered it (jobs-manager spawns from the parent chart's
images.ingestor.repository). Kept image.digest (live). README's air-gapped
override rows now point at the authoritative parent-chart path.
- README: drop the hardcoded chart version (said v1.3.5 while Chart.yaml is
1.9.6) and point to Chart.yaml / the releases page, so it can't drift again.
- Delete the unwired check_docker_arch_mac function + its bats test (no call
sites) and the orphaned docs/eks.md (referenced nowhere).
Part of tracebloc/backend#963.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* chore(installer): regenerate manifest after common.sh trim + develop merge
The #963 chart-contract cleanup dropped 48 dead lines from
scripts/lib/common.sh, changing its sha; the installer manifest wasn't
regenerated, so the Static analysis gate (gen-manifest.sh --check) failed.
Merging develop also refreshed preflight.sh/install-k8s.ps1 hashes.
Regenerate scripts/manifest.sha256 to match the working tree.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Syed Saqlain <syedsaqlain@MacBook-Pro.local>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* fix(release): package charts as the tag version + pre-releases skip gh-pages (#467)
* fix(release): package charts AS the tag version + pre-releases skip gh-pages
Incident 2026-07-29: the v1.9.7-rc.1 pre-release packaged the client chart
from Chart.yaml's plain 1.9.7 and pushed it into the public helm index as
a STABLE version -- customers running helm upgrade would have received
staging content (removed from the index by hand, tgz deleted). Two layers
now prevent it: (1) helm package --version/--app-version from the release
tag, so rc charts carry the -rc.N suffix helm's pre-release rules key on;
(2) pre-releases never run the gh-pages index steps at all -- FR consumes
the release assets (stamped installer / chart tgz), the index is a
customer surface reserved for finals.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix: gh-pages gates key on verify's tag-derived prerelease, not the frozen event (Bugbot)
github.event.release.prerelease is an event-time snapshot: after verify
demotes a mis-marked release, it still reads false, so the demoted rc
would have entered the public index anyway. verify now outputs effective
prerelease-ness derived from the tag shape (the same strict rule the
demotion uses) and all three gh-pages steps gate on that output.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* feat: post-publish index-invariant job (manual leak catch -> CI)
After every release run: the public index must contain only stable-shaped
versions, and a prerelease run must not have indexed its own version.
Fails loudly; would have caught the 1.9.7 leak within a minute of it
happening instead of during manual FR.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* feat(install): rootless Docker core + Tier-1 routing (opt-in) (#1219) (#452)
* feat(install): rootless Docker core + Tier-1 routing (opt-in)
Add install_rootless_docker() and a Tier-1 early-branch in install_linux
so a modern-kernel host with no runtime and no root can install entirely
in user space (RFC 0001 Tier 1 — the RFC's primary path). Gated behind
opt-in TB_TIER1_ROOTLESS=1; with the flag unset a Tier-1 host falls
through to the legacy privileged flow unchanged (validated default).
- install_rootless_docker: uidmap-helper precondition (defers to
prepare-host #1178 when absent — never self-sudo), no-sudo install via
dockerd-rootless-setuptool.sh or get.docker.com/rootless, user-scoped
systemctl --user + loginctl enable-linger, DOCKER_HOST export with
XDG_RUNTIME_DIR fallback, single docker-info verify (no retry loop).
- Tier-1 branch mirrors the Tier-0 early-return. Tools still install via
sudo here (_set_tools_target keys no-sudo off Tier 0 only) — tightening
that for rootless Tier 1 is deferred to slice 3 (#1221).
- 6 bats cases; scripts/manifest.sha256 regenerated (R8).
Closestracebloc/backend#1219
Part of tracebloc/backend#1177 · Epic tracebloc/backend#1168
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: address Bugbot review on rootless Docker core (#452)
- Prepend ~/bin to PATH after the rootless install so this run's docker
info verify + later k3d/docker calls resolve the CLI the
get.docker.com/rootless fallback installs there (High).
- Bound the rootless `docker info` verify with a new shared _bounded
helper (timeout/gtimeout, mirrors probe.sh) so a wedged user daemon
can't hang a headless install (Medium).
- Guard the user-systemd bring-up under set -e: `systemctl --user … ||
true` (the bounded verify is the real gate) and `loginctl
enable-linger … || warn` (optional; fails on polkit-locked hosts even
when the daemon is up) (Medium).
Adds 2 bats cases (~/bin on PATH; systemd/linger failure falls through
to the verify). Manifest regenerated (R8).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: correct the uidmap remedy message (Bugbot #452)
The missing-uidmap error claimed prepare-host would install the uidmap
helpers, but run_prepare_host only sets up privileged Docker + the docker
group — it never installs uidmap. Point at the two honest remedies
instead: install the `uidmap` package directly (rootless then works), or
run prepare-host to set up Docker so the researcher installs at Tier 0
(no rootless needed). #1220 folds this into the shared subuid/subgid gate
and teaches prepare-host to install uidmap for real.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* docs(install): TODO(#1221) — rootless daemon needs user-scoped proxy config
Bugbot on #452 flagged that install_rootless_docker never configures a
corporate proxy for the user-scoped dockerd (the #244 _configure_docker_proxy
is sudo/system-scoped and the Tier-1 early-return never reaches it), so k3d
pulls of rancher/k3s time out on proxy-only hosts. Deferred to #1221 (the
k3d-on-rootless-socket slice that owns the pulls); leaving a tracked TODO so
the follow-up adds the user-scoped drop-in.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: address Asad review nits on #452 — chmod no-op + misleading comment
- Drop the chmod +x on the rootless installer script: it runs via
`sh "$rootless_script"`, which ignores the exec bit.
- Reword the Tier-1 _install_userspace_tools comment: tools still
sudo-install on Tier 1 (only _persist_tools_on_path is no-sudo);
the comment previously implied otherwise.
The underlying _set_tools_target sudo-crash on no-sudo hosts and the
post-install DOCKER_HOST shell persistence are tracked to #1221.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix: resolve user via id -un in install_rootless_docker (Saqlain review, #452)
$USER can be empty in headless / su / cron contexts (a Tier-1 target),
which would break `loginctl enable-linger` and the success line. Resolve
the user once via `id -un` (fallback $USER) and use it for the linger
call, its hint, and the success message. Matches the id-based robustness
DOCKER_HOST already uses. Happy-path bats now mocks `id -un` cleanly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* ci: add code-quality caller workflow (advisory) (#463)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* Add pre-commit hooks (Layer 0, lint-only) (#465)
* Add pre-commit config (Layer 0, lint-only)
Lint-only on purpose: scripts/manifest.sha256 must keep matching the bytes
under scripts/, so no hook may rewrite files.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* Document pre-commit setup in README
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* docs: add Bugbot resolve-and-reply team norm to .cursor/BUGBOT.md (#464)
Part of tracebloc/backend#1308
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* ci: cover scripts/resolve-ingestor-digest.sh in CI shellcheck (#466)
* ci: lint scripts/resolve-ingestor-digest.sh in CI shellcheck (was never linted)
Both CI shellcheck invocations enumerate files explicitly and both omitted
this script. Verified clean against shellcheck --severity=error --shell=bash
0.11.0 before adding. The pre-commit hook from #465 already covers it
locally; this closes the same gap on the CI side.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* ci: lint scripts/resolve-ingestor-digest.sh in CI shellcheck (was never linted)
Both CI shellcheck invocations enumerate files explicitly and both omitted
this script. Verified clean against shellcheck --severity=error --shell=bash
0.11.0 before adding. The pre-commit hook from #465 already covers it
locally; this closes the same gap on the CI side.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): honest cosign bootstrap download + translated DISM failures (#468) (#469)
The v1.9.7-rc.1 FR killed a healthy install: PS 5.1's progress overlay
throttled the 17 MB pinned-cosign fetch to ~4.5 min of dead silence and
the window read as frozen.
- silence the PS 5.1 progress overlay in Get-WithRetry/Get-Optional
(function-local, auto-reverts) - the classic 10-50x IWR speedup
- run the cosign fetch in a background job with a dim liveness tick
(Wait-JobWithTicks / Get-OptionalWithTicks; cwd pinned per #409,
TLS 1.2 re-applied in the fresh process), expectation lines before,
elapsed + checksum-verified confirmation after
- ASCII-only string literals in both installers: the release asset is
served without a charset so PS 5.1's irm decodes UTF-8 source as
Latin-1 before iex, and BOM-less -File reads are ANSI - literal
em-dashes/ellipses reached customers as mojibake. Locked in by a
tokenizer-based Pester test (which also caught the -Help here-string).
- Enable-OneVirtFeature: translate DISM's raw COMException (feature
package absent on Server SKUs vs enable failure) and stop demanding
a reboot for a feature that never enabled (old code sent Server
users into a reboot->re-run->same-error loop)
Pester: 212 passed / 0 failed locally (pwsh 7.5, Pester 5.7.1).
PSScriptAnalyzer: 0 errors. manifest.sha256 regenerated.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(installer): trust the corporate MITM CA in the k3d nodes (#424) (#453)
* fix(installer): trust the corporate MITM CA in the k3d nodes (#424)
Proxy REACHABILITY reaches the nodes, but on a TLS-inspecting (break-and-
inspect) network the nodes still don't TRUST the corporate CA, so every in-node
containerd pull (rancher/k3s, ghcr.io, tracebloc images) fails x509 — then
masked (helm runs without --wait) into a root-cause-free "an image couldn't be
pulled." Enterprise/hospital archetype, all three OSes.
- Inject the CA at create time: when TRACEBLOC_CA_BUNDLE (or CURL_CA_BUNDLE) is
set, mount the bundle into every k3d node and write a registries.yaml pointing
containerd at it per-registry (docker.io, registry-1.docker.io, ghcr.io), via
the same --config/create path that already carries proxy env. Parity across
scripts/lib/cluster.sh (Linux/macOS) and install-k8s.ps1 (Windows). A CA var
set but unreadable fails loudly instead of silently skipping.
- Name the env var where the user hits the wall: the TLS-interception preflight
hint (both OSes), docs/INSTALL.md, and the PS -Help env-var list.
- CA-aware diagnosis: detect x509 / "certificate signed by unknown authority"
pull events and report a dedicated image_pull_ca state — "the cluster does not
trust your network's TLS-inspection CA" + the exact remedy — instead of the
generic pull error. Mirrored in summary.sh and Print-Summary.
- New check-drift.sh parity check (_drift_ca_trust) so neither installer can drop
the CA wiring for the other's OS.
Tests: +8 cluster.bats, +3 summary.bats, +2 check-drift.bats, +8 Pester.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): CA-trust hardening — no fail-open, bounded events, verify CA readable (Bugbot #424)
Three Bugbot findings on #424:
- _write_k3d_registries_config failed open: on mktemp failure it returned success
with no path, so create still mounted the CA and logged "nodes trust it" but
dropped --registry-config → containerd never got ca_file, x509 pulls still fail
while the operator thinks it's fixed. Now returns non-zero; the caller hard-errors
(CA was supplied, so we refuse to proceed without wiring it in).
- PS Get-NotReadyState `kubectl get events` had no --request-timeout (the bash path
does) — on a wedged/proxy-misrouted API, classification could hang. Added
--request-timeout=5s to match _diagnose_not_ready.
- PS Resolve-CaBundle only checked existence (Test-Path), not readability, so an
unreadable CA passed on Windows but bash (-r) hard-fails. Added an OpenRead probe
so both fail the same way, up front.
Tests: cluster.bats +mktemp-failure + unwritable-registries-hard-error;
install-k8s.Tests.ps1 +unreadable-CA (Unix) + events --request-timeout assertion.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): errexit-safe CA-resolve capture + drift check ignores comments (Bugbot #424 r2)
Two round-2 Bugbot findings:
- Under `set -euo pipefail`, `ca_bundle="$(_resolve_ca_bundle)"; ca_rc=$?` exited on
the rc-2 (unreadable/missing CA) BEFORE ca_rc/error ran — operators got a bare
exit instead of the "can't be read" guidance. Capture with `|| ca_rc=$?` so
errexit doesn't fire and the guidance prints.
- _drift_ca_trust whole-file grep matched tokens in comments (e.g. --registry-config
appears in a comment above the real line), so deleting the functional wiring could
still pass. Strip comment lines first (matches the execute-gate / preflight-host
checks), no grep -q under pipefail.
Tests: cluster.bats +errexit-safe-capture; check-drift.bats +comment-only-token drift.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): TLS-preflight hint names the right var per layer/OS (Bugbot #424 r3)
The hint claimed TRACEBLOC_CA_BUNDLE makes "the host AND the k3d nodes" trust the
CA, but the host connectivity checks use curl_secure / Invoke-WebRequest, which
read CURL_CA_BUNDLE / the system trust store — not TRACEBLOC_CA_BUNDLE (that var
only reaches the nodes via _resolve_ca_bundle). Following the hint literally left
host preflight TLS failures unchanged. Corrected, no behaviour change:
- bash: CURL_CA_BUNDLE fixes these host checks AND the nodes; TRACEBLOC_CA_BUNDLE
is nodes-only; or add the CA to the system trust store.
- Windows: import the CA into the cert store for the host checks (Invoke-WebRequest
uses the store, not an env var); TRACEBLOC_CA_BUNDLE/CURL_CA_BUNDLE cover the nodes.
(Reworded to avoid a bare lowercase `curl` that the curl_secure style guard flags.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): apply CA on cluster REUSE path — warn + recreate guidance (Bugbot #424 r4)
The image_pull_ca remedy said "set the CA and re-run", but CA trust is baked in
only at fresh create; a re-run reuses the existing cluster and never mounts the CA
or passes --registry-config, so the x509 pulls persisted. Mirror the existing
proxy handling (baked-at-create → warn on reuse):
- bash _check_existing_cluster_ca (called from _handle_existing_cluster): warns when
a CA bundle is set but the reused server container lacks the CA mount.
- ps1 New-K3dCluster reuse block: same check via docker inspect mounts.
- both image_pull_ca remedies now say to `k3d cluster delete <name>` first, then
re-run with the CA (CA, like proxy, can't be added to a running cluster).
Tests: cluster.bats +3 (no-CA no-op / CA-but-missing-mount warns / mount-present silent).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(installer): add auth.docker.io to the CA registries config (Bugbot #424 r5)
The registries.yaml ca_file entries covered docker.io / registry-1.docker.io /
ghcr.io, but Docker Hub pulls also TLS-handshake with auth.docker.io for bearer
tokens — so on a break-and-inspect network containerd still rejected the
intercepted cert there even with the CA mounted. #416 already probes auth.docker.io
at preflight; the CA registries list now matches. Added to TB_CA_REGISTRIES and
$TbCaRegistries; registries.yaml test counts 3 -> 4.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#424): _resolve_ca_bundle rejects a directory, not just unreadable paths
A directory of PEMs is readable (-r) but would bind-mount over the single
node ca_file path and containerd can't read it — the silent 'looks applied
but still x509' case. Require a regular file (-f), mirroring the PS
Resolve-CaBundle -PathType Leaf check. Adds a directory-reject bats case.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#424): exact whole-line match for CA mount detection (Bugbot)
_check_existing_cluster_ca used a substring test on docker mount
destinations, so a longer path embedding /etc/ssl/certs/tracebloc-mitm-ca.crt
(e.g. …crt.bak) would be treated as the CA mount and skip the recreate
warning while containerd still x509-fails. Switch to grep -qxF (exact
whole-line), matching the PS anchored regex. Adds a substring-embed test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#424): scope x509 classification to the pull-failure event (Asad)
_diagnose_not_ready / Get-NotReadyState flagged image_pull_ca on ANY x509
event in the namespace, so a stale/unrelated x509 event (e.g. a FailedMount)
could misdirect the user into a needless delete+recreate. Filter events to
the image-pull failure lines (failed to pull / ErrImagePull) before testing
x509, in both bash and PS. Adds an unrelated-x509 test to each side.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* feat(chart): perIngestionTables — RFC-0003 D16 enablement knob (backend#1205) (#472)
* feat(chart): perIngestionTables — the RFC-0003 D16 enablement knob (backend#1204/#1205)
values.perIngestionTables (default false, schema-typed) renders
PER_INGESTION_TABLES=1 onto the jobs-manager, which forwards it into
every ingestion Job it spawns (client-runtime companion PR). Flip per
environment, dev first, only once that environment's backend + engine
images + jobs-manager carry the merged D-series. Default installs
render byte-identically (conditional block; unit tests pin both sides).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* chore(values): own banner for perIngestionTables — it is not part of the authz section (review)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* chore: clear house-rules findings (#470)
Fix every finding the shared org checker (tracebloc/.github
scripts/house-rules.sh) reports at develop HEAD: missing curl
timeouts/TLS floors, plus (cli) a missing pipefail. Waivers only where
the finding is a documented false positive. Part of tracebloc/backend#1303.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(install): Tier-1 subuid/subgid gate + prepare-host remediation (#1220) (#458)
* feat(install): Tier-1 subuid/subgid gate + prepare-host remediation
RFC 0001 #1220. Detect the one privileged residue a modern rootless host may
still need — a subordinate UID/GID range + the setuid uidmap helpers — and
either proceed (present), hand off to prepare-host (unprivileged), or perform
one announced touch (sudo available). Never blanket sudo, never an opaque
mid-install crash inside dockerd-rootless-setuptool.sh.
- probe.sh: _probe_subid_ranges (PROBE_SUBID) + _probe_uidmap_helpers
(PROBE_UIDMAP), set in run_host_probes (Linux only), plus audit rows on
the Tier-1 path.
- common.sh: shared pure parsers _subid_has_entry + _next_subid_start, used
by both the probe and the remediation (no duplication).
- setup-linux.sh: _ensure_subid_ranges gate (present / hand-off / one
announced sudo touch) called before install_rootless_docker;
_provision_subid_ranges (idempotent, non-overlapping block, usermod
--add-subuids with file-append fallback, uidmap install) shared by the
installer and run_prepare_host. Folds in slice-1's minimal uidmap check.
- Tests: probe.bats + setup-linux.bats. Manifest regenerated (R8).
Closestracebloc/backend#1220
Part of tracebloc/backend#1177 · Epic tracebloc/backend#1168
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): address #458 review — subid gate/probe/hand-off robustness
Bugbot + @saadqbal + a self code-review on client#458, all in slice-2's code:
- id -un everywhere (gate, _provision default, probe): $USER diverges from the
rootless daemon's user under su/cron, which wedged detection/provisioning (#1).
- Re-verify the uidmap helpers are usable (present AND setuid|cap_setuid) after
install, and return non-zero + warn (NOT error/exit) so run_prepare_host stays
best-effort while the installer sudo-path hard-fails via `|| error` (#2 + self-review).
- _idmap_helper_ok (common.sh): accept the setuid bit OR a cap_setuid filecap, so
Arch's `shadow`/pacman path isn't false-rejected (#3).
- Hand-off + run_prepare_host fallback compute a non-overlapping start via
_next_subid_start (honoring TB_SUBUID_FILE/TB_SUBGID_FILE), not hardcoded 100000
(#4 + self-review path-override).
- Hand-off command names the researcher (TB_PREPARE_USER=) — bare prepare-host
provisions nothing, so it would have looped back to the same hand-off (#5).
- Capture `usermod --help` before grepping — pipefail-safe (#6).
bats: id -un mocks, filecaps accept/reject, gate hand-off (names user + computed
start), _provision re-verify best-effort, run_prepare_host best-effort. R8 regen.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(install): stub the subid gate in the Tier-1 rootless routing test
install_linux's Tier-1 branch now calls _ensure_subid_ranges (slice 2)
before install_rootless_docker; the routing test left it un-stubbed, so the
real gate hit the no-sudo hand-off and error()'d → install_linux returned
non-zero. Stub _ensure_subid_ranges (its own behavior is covered by the
dedicated gate tests) and assert it runs before daemon setup.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* test(install): scope set -o pipefail to a subshell (bats harness footgun)
Setting `set -o pipefail` in the @test body can leak into bats' own
post-test pipelines and fail the whole run with exit 1 even when every
test reports ok (no 'not ok'). Confine it to a subshell around the call
so the pipefail-safety assertion still holds without touching the harness.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): style guard — no bare curl in the prepare-host hint
The hand-off piped 'curl … | TB_PREPARE_USER=… bash', which breaks
check-style.sh's exemption for the canonical 'curl … | bash' one-liner
(the env var sits between the pipe and bash). Split into an 'export
TB_PREPARE_USER=…' line + the canonical piped one-liner — still names the
researcher, and passes the guard. Verified with scripts/check-style.sh.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): fix the #458 red bats + 2 Bugbot bugs (newgidmap cap, write-failure)
Root cause of the "540 ok but exit 1" bats red: the probe.bats uidmap tests set
PATH="$bin" in the test body to hide system helpers, which also hides `rm` — so
bats-core 1.10+ can't run its own per-test cleanup ("rm: command not found") and
fails the whole run even though every test passes. Scope the hermetic PATH to a
subshell so it can't leak into bats' machinery. (Why develop was green + this was
so hard to see: these tests are new in slice 2, and the symptom is a clean pass
list with a non-zero exit.)
Two real Bugbot findings in the slice's own code:
- _idmap_helper_ok checked cap_setuid for BOTH helpers; newgidmap carries
cap_setgid (Arch filecaps) -> false-rejected. Map name->cap; fix the test mock
that masked it + add a wrong-cap regression test.
- _provision_subid_ranges printed success/returned 0 even when the usermod/tee
write failed (callers run it with set -e off) -> installer proceeds with no
range. Guard every write; warn + return 1 on failure. + a test.
Verified: probe.bats + setup-linux.bats EXIT 0 (0 not-ok, 0 rm-not-found) in a
faithful ubuntu 24.04 + bats 1.10 + non-root container. Rebased onto develop.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): 2 more Bugbot findings on #458 (apt hang, false zero-root message)
- _install_uidmap_pkg ran a bare `sudo apt-get install -y uidmap` under the
spinner — no needrestart/DEBIAN_FRONTEND env, no DPkg::Lock::Timeout, no
apt_wait_for_lock — so a headless Tier-1 install can hang on Ubuntu needrestart
or an apt-daily lock (#210 class). Reuse the repo's hardened PM_INSTALL
(populate via setup_pm, which Tier 1 skips) + apt_wait_for_lock.
- install_rootless_docker always printed "no administrator rights were used",
even after _ensure_subid_ranges performed an announced sudo touch on the
root/sudo_nopw path. The gate now sets TB_ROOTLESS_ADMIN_TOUCH and the summary
is honest on both the zero-root and one-admin-touch paths.
Tests: hardened-install assertion (NEEDRESTART_MODE + DPkg::Lock::Timeout) + a
success-message honesty test. Verified EXIT 0 (0 not-ok, 0 rm-errors) in the
faithful ubuntu 24.04 + bats 1.10 + non-root container.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): refresh the package index in _install_uidmap_pkg (Bugbot #458)
Completing the prior apt-hardening: _install_uidmap_pkg populated PM_INSTALL and
waited for the dpkg lock but never ran PM_UPDATE. On the Tier-1 path this is the
first package op, so an empty/stale index can't locate uidmap/shadow and the
install hard-stops. Run $PM_UPDATE (best-effort) first, matching the repo's other
install paths (setup-linux.sh:335/543). Test asserts the index refresh.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(installer): silence the PS 5.1 progress throttle in install-k8s.ps1 downloads (#468 follow-up) (#471)
Same class as the bootstrap fix in #469: PS 5.1's progress overlay
throttles Invoke-WebRequest 10-50x and reads like a hang. One
function-local $ProgressPreference in Invoke-WithRetry covers every
fetch scriptblock it drives (dynamic scoping) - winget msixbundle,
Docker Desktop fallback, kubectl, k3d, helm, GPU plugin yaml, and the
version resolvers.
Honest-progress expectation lines (sizes measured today via HEAD):
Docker Desktop ~600 MB, winget ~200 MB, kubectl ~60 MB, k3d ~25 MB,
helm ~20 MB - all cold-path only, silent on warm re-runs.
Pester: 205 passed / 0 failed locally. PSSA: 0 errors.
manifest.sha256 regenerated.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: shujaat hasan <shujaat@tracebloc.io>
* fix(installer): trust the corporate CA in the Docker daemon for k3d runtime image pulls (#474) (#475)
* fix(#474): detect host Docker daemon x509 at cluster-create + document daemon CA trust
k3d pulls its own runtime images (rancher/k3s, k3d-tools, k3d-proxy) with the
HOST Docker daemon, which doesn't use the in-node CA trust from #424. On a
TLS-inspecting network that pull can x509-fail during 'k3d cluster create',
before any node boots — so the post-create diagnosis never classifies it.
- bash: _host_ca_create_hint() detects x509 in the k3d create output and prints
a platform-aware remedy (Linux system trust store vs Docker Desktop VM);
wired into _create_new_cluster's failure path.
- PS: Write-HostCaCreateHint() mirrors it (Windows Trusted Root store), wired
before the generic create failure.
- docs/INSTALL.md: document trusting the CA in the daemon itself (Linux /
Docker Desktop).
- check-drift.sh: enforce both installers keep the host-CA hint (parity).
- Tests: bats (Linux/macOS branches + silent-on-no-x509) + Pester + drift.
Closes#474
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#474): distro-aware Linux CA remedy + actionable Docker Desktop for Linux (Bugbot)
- Linux native-Docker remedy now covers both Debian/Ubuntu (update-ca-certificates)
and RHEL/Fedora (update-ca-trust), not just the Debian path — the installer
supports RHEL hosts where the Debian commands fail.
- Docker Desktop for Linux now has an actionable step (trust in the system store,
restart Docker Desktop) instead of a dangling reference to a step only printed
on the macOS branch.
- docs/INSTALL.md updated to match. bats Linux test asserts both distro paths.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#474): cover Colima runtime in the macOS host-CA remedy (Bugbot)
Headless macOS installs use Colima (_install_docker_colima), a Lima VM that
does not read the macOS keychain — so the 'trust it in the keychain + restart
Docker Desktop' remedy was wrong for those hosts. The macOS branch now also
gives the Colima path (add the CA inside the VM via 'colima ssh', then
'colima restart'). docs/INSTALL.md + macOS bats test updated to match.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* test(#474): isolate drift negative fixtures so a missing new token can't mask them (Bugbot)
Adding _host_ca_create_hint / Write-HostCaCreateHint as required _drift_ca_trust
tokens meant the older negative fixtures (missing registry-config, comment-only
registry-config) could pass just because the new token was also absent — so the
comment-strip case no longer uniquely proved comment-stripping still works. Each
negative fixture now carries ALL other required tokens and omits/comments only
the one under test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#474): surface host-CA hint on the PS create-timeout path too (Bugbot parity)
The PowerShell create-timeout branch exited via Err without calling
Write-HostCaCreateHint (and deleted the k3d logs first), so a TLS-inspected
host pull that logs x509 then hangs to the deadline gave Windows operators a
raw timeout with no certlm.msc CA guidance — while bash runs _host_ca_create_hint
on its timeout fall-through. Capture the full create output before deleting the
logs and call the hint before the timeout Err. Adds a parity regression test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#474): use a herestring in _host_ca_create_hint to survive pipefail (Asad)
printf '%s' "$out" | grep -qiE ... could swallow the hint under set -o pipefail:
grep -q closes the pipe on first match, so for output past the ~64KB pipe buffer
(reachable on the timeout path, which passes the full logs) printf takes SIGPIPE,
the pipeline exits non-zero, and `|| return 0` bails even though x509 matched.
Feed grep via a herestring (no pipe, no SIGPIPE). Adds a >64KB-under-pipefail
regression test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* feat(install): Tier-1 k3d-on-rootless + cgroup delegation + autostart (#1221) (#478)
* feat(install): Tier-1 k3d-on-rootless + cgroup delegation + autostart (#1221)
Slice #1221 (RFC 0001 / #1177): make a rootless Tier-1 cluster actually usable,
all behind the opt-in TB_TIER1_ROOTLESS flag (default off until the spike's §5
host validation). With the flag unset every path below is a no-op and current
behavior is byte-for-byte unchanged.
- Shared _rootless_active predicate (common.sh) so cluster.sh + setup-linux.sh
can't drift on the flag pair.
- create_cluster targets the rootless socket (DOCKER_HOST); ensure_cluster_
autostart gets a user-scope branch (systemctl --user enable + loginctl
enable-linger, never `sudo systemctl enable docker`), and promises
reboot-survival only when BOTH succeed (honesty rule, #375/#458).
- cgroup v2 controller delegation drop-in (Delegate=cpu cpuset io memory pids):
privileged write + daemon-reload on root/sudo, or hand off to prepare-host
with the exact path+content when unprivileged. run_prepare_host writes it too
(system-wide -> covers the researcher).
- Carry-ins from #452/#458: scope-aware _configure_docker_proxy (user scope, no
sudo) so a proxy-only host's rootless daemon can pull rancher/k3s;
_set_tools_target installs user-space on rootless Tier 1 (no sudo-mv crash on
a true no-sudo host); persist DOCKER_HOST to the shell rc for new terminals.
14 new bats tests incl. flag-off regressions; shellcheck --severity=error clean;
manifest.sha256 regenerated (R8).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): address Bugbot on #478 — rootless autostart seed + admin-touch msg
- ensure_cluster_autostart: don't seed TB_DOCKER_AUTOSTART from the SYSTEM
docker.service is-enabled check on the rootless path. The cluster runs on the
per-user rootless socket, so a system unit that happens to be enabled would seed
a false reboot promise the rootless branch then can't honestly retract. On
rootless the user-scope enable+linger are now the sole authority (Bugbot medium).
- install_rootless_docker: the TB_ROOTLESS_ADMIN_TOUCH success line no longer
hardcodes "subuid/subgid range" — _ensure_cgroup_delegation can set that flag
too, so it now names "host prerequisites (subuid/subgid range and/or cgroup
delegation)" (Bugbot low).
- Test: rootless + system docker.service enabled + user-enable fails => flag stays
0 (pins the seed-guard). manifest regenerated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(install): address Asad + Saqlain review on #478
- _persist_docker_host: key idempotency off our own marker, not a bare
'DOCKER_HOST=' probe. The old probe also matched a user's own DOCKER_HOST
(remote/TCP), so we silently skipped persisting the rootless socket and new
shells kept hitting the wrong daemon. Now: our own line -> idempotent; a foreign
DOCKER_HOST -> left untouched + a warn to repoint it (Asad #2 + Bugbot #478, Medium).
- ensure_cluster_autostart: reset TB_DOCKER_AUTOSTART=0 in the rootless else-branch
(defensive; the is-enabled seed is already guarded off the rootless path) so the
honesty guarantee is local to the branch (Asad #1).
- install_rootless_docker: success line now reads "one or more one-time admin steps"
so it doesn't undercount when both the subuid and cgroup touches happen (Saqlain #1).
- Test: foreign DOCKER_HOST -> warns, no clobber, no double-write. manifest regen.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(installer): failures surface the real error + log path + support-bundle hint (#423) (#476)
* fix(#423): failures surface the real error + log path + support-bundle hint
Fatal errors printed a generic red line while the actionable detail (k3d/helm
stderr) went only to the transcript, and the log path itself was never shown on
screen. Now:
- Err gains an optional $Detail param; Get-ErrDetailLines (pure, unit-tested)
renders the last ~5 non-empty output lines + the log path + a '-Diagnose'
next-step hint, appended to EVERY fatal error.
- Cluster-create failure passes k3d's stdout/stderr so the real reason (image
pull / proxy / port / WSL) shows on screen — the motivating case.
- Helm repo-add / reconcile / install failures pass helm's output via $Detail
instead of embedding it (no more duplicated log-path text).
- Install log path is announced up front in the banner (was log-only before).
Closes#423
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#423): force array enumeration of Err detail lines (Bugbot, defensive)
Bugbot flagged that a single-line Get-ErrDetailLines return (no detail + no
LOG_FILE, e.g. a Confirm-Config failure before Start-InstallLog) unwraps to a
scalar string. The foreach statement already iterates a scalar once (verified:
it prints the whole line, not per-character), so the reported char-splitting
does not reproduce -- but wrap the enumeration in @(...) to make that
unambiguous and future-proof. Adds a regression test asserting the single-line
case stays one intact line.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#423): strip PS 5.1 ErrorRecord chrome from the failure excerpt (Bugbot)
helm failures arrive as `native 2>&1 | Out-String`; on Windows PowerShell 5.1
that wraps stderr in ErrorRecord chrome (the `At <file>:<n> char:<n>` position
line plus the `+ ...` / `+ CategoryInfo` / `+ FullyQualifiedErrorId` block).
Get-ErrDetailLines kept only the last 5 non-empty lines, so the excerpt was all
chrome and the real `Error:` line dropped out -- a regression from the previous
full-message dump. Filter those chrome lines before taking the window so the
actual error survives. Adds a regression test simulating the 5.1 rendering.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#423): drop duplicate inline log-path hints (Bugbot)
Err now always prints the log path via Get-ErrDetailLines, so the k3d
spawn-failure and create-timeout paths that still Hint "Full log:" right before
Err printed it twice. Remove those inline hints; Err is the single source. Adds
a guard test asserting no inline 'Full log:' hints remain in the installer.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* fix(#423): put stderr last in the create-failure Err detail (Asad)
Get-ErrDetailLines keeps the LAST 5 non-empty lines, so with detail ordered
stderr-then-stdout any k3d stdout tail could crowd the real stderr reason
(FATA/x509/port) out of the excerpt. Order it stdout-then-stderr so the stderr
tail survives the window; also matches the Write-HostCaCreateHint order just
above.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Syed Is Saqlain <saqlain.syed007@gmail.com>
Co-authored-by: Syed Saqlain <syedsaqlain@MacBook-Pro.local>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Arturo Peroni <arturo@tracebloc.io>
Co-authored-by: shujaat_tracebloc <153823837+shujaatTracebloc@users.noreply.github.com>
Co-authored-by: shujaat hasan <shujaat@tracebloc.io>
Co-authored-by: tracebloc-release-train[bot] <309815517+tracebloc-release-train[bot]@users.noreply.github.com>
* ci(1606): standard-checks and helm-ci call the Makefile instead of copying it
CI parity. Two jobs restated targets the Makefile already declares -- and one
of them had ALREADY DRIFTED, in the direction nobody notices.
LINT. This job spelled out the shellcheck file list inline while the Makefile
kept the same list in SHELLCHECK_FILES. Measured: the Makefile carries 19
entries, this file carried 9. Ten scripts were shellchecked on a contributor
machine and NOT at the merge gate:
gen-manifest.sh check-facts.sh check-style.sh lib/*.sh
tests/check-drift.sh tests/e2e-full-seal.sh tests/e2e-journey.sh
tests/path-persist.sh tests/chart-env-vocabulary.sh
tests/env-vocabulary-agreement.sh
gen-manifest.sh is the installer integrity-manifest generator, so a shell
defect there could not be caught by this gate. `make lint` is green across all
19 on this tree, so arming the full list imports no backlog.
HELM LINT. The values-file loop, `helm lint --strict ./ingestor` and both
vocabulary scripts were verbatim copies. `env-vocabulary-agreement.sh` exists
to prove the four CLIENT_ENV declarations agree with each other (backend#1729
sweep 5) -- a check about "these declarations must not drift" being itself
declared twice is the joke version, and a third vocabulary script added to the
Makefile alone would leave this gate silently not running it.
The apt install of shellcheck stays: it bootstraps the runner, it is not a
duplicated command.
Job names untouched. `Lint` and `Unit tests` are required status checks on
main, matched by name.
Verified: make lint, make helm-lint and make helm-vocab all exit 0 on this
tree; actionlint clean on both files.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Asad Iqbal (Saadi) <asad.dsoft@gmail.com>
Co-authored-by: shujaat hasan <shujaathasan@shujaats-MacBook-Pro.local>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: shujaat_tracebloc <153823837+shujaatTracebloc@users.noreply.github.com>
Co-authored-by: Arturo Peroni <arturo@tracebloc.io>
Co-authored-by: tracebloc-release-train[bot] <309815517+tracebloc-release-train[bot]@users.noreply.github.com>
Co-authored-by: Syed Is Saqlain <saqlain.syed007@gmail.com>
Co-authored-by: Syed Saqlain <syedsaqlain@MacBook-Pro.local>
Co-authored-by: shujaat hasan <shujaat@tracebloc.io>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@LukasWodka@shujaatTracebloc@divyasinghds