Uh oh!
There was an error while loading. Please reload this page.
fix(installer): neutral Tier-1 rootless header — drop the early no-admin promise - #481
Merged
Merged
Conversation
…omise Bugbot on the staging promotion (#480): the Tier-1 branch printed 'no administrator rights needed' BEFORE _ensure_subid_ranges / _ensure_cgroup_delegation ran - on hosts where either fires, the operator saw a no-admin promise immediately contradicted by an announced sudo touch or a prepare-host handoff. The header now stays neutral ('user-space install'); the two prerequisite helpers already announce themselves or hand off when they actually apply. Tier 0's claim is unconditionally true and stays. Manifest regenerated.
LukasWodka
commented
Jul 29, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 35 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
divyasinghds
approved these changes
Jul 30, 2026
divyasinghds
left a comment
Contributor
There was a problem hiding this comment.
Log-text-only change + regenerated manifest.sha256; E2E/prereq matrix all green. Neutral rootless header no longer overpromises 'no admin' before the two conditional privileged prerequisites fire. Tier 0's unconditional claim correctly left untouched. LGTM.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Bugbot finding on the staging promotion (#480 thread): the Tier-1 rootless branch promised no administrator rights needed before
_ensure_subid_ranges/_ensure_cgroup_delegationran — on hosts where either applies, that promise is immediately contradicted by an announced sudo touch or a prepare-host handoff.Setting up a rootless container runtime (user-space install).— the two prerequisite helpers announce themselves (or hand off) only when they actually fire, so no message ever overpromises.scripts/manifest.sha256regenerated (R8 gate).One-line copy change + manifest; no behavior change.
Note
Low Risk
User-facing log text and checksum manifest only; no install behavior changes.
Overview
Fixes misleading installer copy on the Tier-1 rootless path (
_rootless_activeinsetup-linux.sh): the status line no longer claims no administrator rights needed before_ensure_subid_rangesor_ensure_cgroup_delegationrun, which can still trigger sudo or a prepare-host handoff.The message is now
Setting up a rootless container runtime (user-space install)., with an inline comment documenting the Bugbot/#480 rationale. Tier 0 still uses the unconditional no-admin line; install logic is unchanged.scripts/manifest.sha256is updated for the touchedsetup-linux.sh(R8 gate).Reviewed by Cursor Bugbot for commit 2d69b21. Bugbot is set up for automated code reviews on this repo. Configure here.