Skip to content

fix(installer): neutral Tier-1 rootless header — drop the early no-admin promise - #481

Merged
LukasWodka merged 1 commit into
developfrom
fix/rootless-header-no-admin-claim
Jul 30, 2026
Merged

fix(installer): neutral Tier-1 rootless header — drop the early no-admin promise#481
LukasWodka merged 1 commit into
developfrom
fix/rootless-header-no-admin-claim

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes the Bugbot finding on the staging promotion (#480 thread): the Tier-1 rootless branch promised no administrator rights needed before _ensure_subid_ranges / _ensure_cgroup_delegation ran — on hosts where either applies, that promise is immediately contradicted by an announced sudo touch or a prepare-host handoff.

  • Header is now neutral: Setting up a rootless container runtime (user-space install). — the two prerequisite helpers announce themselves (or hand off) only when they actually fire, so no message ever overpromises.
  • Tier 0's identical claim is unconditionally true (runtime already present, docker-group user) and is untouched.
  • scripts/manifest.sha256 regenerated (R8 gate).

One-line copy change + manifest; no behavior change.


Note

Low Risk
User-facing log text and checksum manifest only; no install behavior changes.

Overview
Fixes misleading installer copy on the Tier-1 rootless path (_rootless_active in setup-linux.sh): the status line no longer claims no administrator rights needed before _ensure_subid_ranges or _ensure_cgroup_delegation run, which can still trigger sudo or a prepare-host handoff.

The message is now Setting up a rootless container runtime (user-space install)., with an inline comment documenting the Bugbot/#480 rationale. Tier 0 still uses the unconditional no-admin line; install logic is unchanged.

scripts/manifest.sha256 is updated for the touched setup-linux.sh (R8 gate).

Reviewed by Cursor Bugbot for commit 2d69b21. Bugbot is set up for automated code reviews on this repo. Configure here.

…omise
Bugbot on the staging promotion (#480): the Tier-1 branch printed
'no administrator rights needed' BEFORE _ensure_subid_ranges /
_ensure_cgroup_delegation ran - on hosts where either fires, the
operator saw a no-admin promise immediately contradicted by an
announced sudo touch or a prepare-host handoff.
The header now stays neutral ('user-space install'); the two
prerequisite helpers already announce themselves or hand off when
they actually apply. Tier 0's claim is unconditionally true and
stays. Manifest regenerated.
@LukasWodkaLukasWodka self-assigned this Jul 29, 2026
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

👋 Heads-up — Code review queue is at 35 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@divyasinghdsdivyasinghds left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log-text-only change + regenerated manifest.sha256; E2E/prereq matrix all green. Neutral rootless header no longer overpromises 'no admin' before the two conditional privileged prerequisites fire. Tier 0's unconditional claim correctly left untouched. LGTM.

@LukasWodka
LukasWodka merged commit 51278d5 into developJul 30, 2026
39 checks passed
@LukasWodka
LukasWodka deleted the fix/rootless-header-no-admin-claim branch August 14, 2026 13:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LukasWodka@divyasinghds