Uh oh!
There was an error while loading. Please reload this page.
feat(installer): install Docker Desktop unattended with the WSL2 backend (#419) - #487
Merged
Merged
Conversation
On the winget path the installer couldn't pass Docker Desktop's own installer args (winget's manifest defaults decided), leaving first-launch license/onboarding prompts possible and the backend implicit; the direct path passed --quiet --accept-license but not --backend=wsl-2. - winget: add --override 'install --quiet --accept-license --backend=wsl-2 --always-run-service' so Docker's installer flags apply through winget. - direct: add --backend=wsl-2 --always-run-service to match. - --always-run-service (Docker's documented unattended flag) starts the engine service without a GUI first-run, so a fresh machine reaches a running engine with zero Docker Desktop interaction. Tests: source guards that both paths select the WSL2 backend + run the service unattended, and that winget uses --override. Closes#419 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 778fdd5. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
…afe, Bugbot) The --override value was one ArgumentList array element containing spaces; PS 5.1's Start-Process joins array elements without quoting, so winget received '--override install' plus stray --quiet/--accept-license tokens and the Docker installer flags never applied (winget failed -> fell back to the 600 MB direct download). Build the winget args as a single command-line string with the override value explicitly double-quoted, so it reaches winget as one argument. Updated the source guards accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ktop-flags # Conflicts: # scripts/manifest.sha256
saadqbal
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What & why
On the winget path the installer couldn't pass Docker Desktop's own installer arguments — winget's manifest defaults decided — leaving first-launch license/onboarding prompts possible and the backend choice implicit. The direct-download path already passed
install --quiet --accept-licensebut not--backend=wsl-2.Changes (
scripts/install-k8s.ps1)--override "install --quiet --accept-license --backend=wsl-2 --always-run-service"so Docker Desktop's own installer flags apply through winget (--overridereplaces winget's manifest defaults).--backend=wsl-2 --always-run-serviceto match.--always-run-service(Docker's documented unattended flag) runs the engine service without a GUI first-run — so a fresh machine reaches a running engine with zero Docker Desktop interaction. Both paths now produce the identical unattended result.Acceptance (from #419)
--override) / direct path adds--backend=wsl-2--always-run-service(the documented unattended flag that starts the service so any user can use Docker without launching the GUI). Left--admin-settingsJSON out of scope (needs a policy file; belongs with the docker-users/feat(installer): provision Docker for the daily user during the admin window (docker-users + autostart + sized .wslconfig) #418 provisioning work).Tests
Source guards: both install paths select the WSL2 backend explicitly + run the service unattended; winget uses
--override. (Widened the #422 killable-process regex for the longer args string.)Local verification
Pester 275/0/9 · check-style pass · drift clean · manifest regenerated · PS parse OK. (No bash changes — bats unaffected.)
Closes#419
Note
Low Risk
Installer-only change on Windows Docker install flags and tests; no auth, data, or cluster logic touched.
Overview
Windows Docker Desktop install now targets a fully unattended first run: WSL2 backend, license acceptance, and engine service without GUI onboarding.
On the winget path, the script passes Docker’s own installer args via
--override "install --quiet --accept-license --backend=wsl-2 --always-run-service"(replacing winget manifest defaults). Arguments are built as a single command-line string forStart-Processso PowerShell 5.1 does not split the quoted--overridevalue.The direct-download installer path uses the same flags (
--backend=wsl-2 --always-run-service) so both routes behave the same.Tests add a
#419describe block that guards those flags in source, and tweak existing#422regex windows for the longer installer argument strings.manifest.sha256is updated forinstall-k8s.ps1.Reviewed by Cursor Bugbot for commit 71e69ed. Bugbot is set up for automated code reviews on this repo. Configure here.