chore(install-k8s): drop dead Get-WslConfigContent + its test

[LukasWodka]

Summary

Removes Get-WslConfigContent from scripts/install-k8s.ps1 and its Pester test. The function had no production caller — it was superseded by Add-WslMemorySetting and stayed alive only because its own test referenced it.

Spotted while fixing the .wslconfig memory floor in #516.

Why it's dead

Get-WslConfigContent built a whole .wslconfig body from scratch, returning a fixed [wsl2] + memory=<N>GB stanza. That clobbers any other settings the operator had (processors, swap, …).

Add-WslMemorySetting replaced it: it merges a memory= line into existing content, preserves other sections, and returns $null when a memory= is already present so operator tuning is never overwritten.

Set-DailyUserProvisioning — the only consumer in the #418 daily-user-provisioning path — calls Get-WslConfigMemoryGb + Add-WslMemorySetting. Nothing calls the old builder.

The one remaining reference was its Pester test, which asserted that the function works, not that anything uses it — so the test was the only thing keeping the dead code alive. Both removed together.

Caller re-verification

Re-grepped before removing, not just scripts/:

Sweep	Hits
grep -rn "Get-WslConfigContent" scripts/	definition + 1 test only
grep -rn "Get-WslConfigContent" .github/	none
whole repo, excl. .git	definition + 1 test only
case-insensitive wslconfigcontent, whole repo	same 3 lines
grep -rn "WslConfig" (to catch dynamic invocation via & / Invoke-Expression)	no indirect invocation

No workflow shells into it. Safe to delete.

Rebased onto #516

#516 landed on develop while this was open and rewrote Get-WslConfigMemoryGb — the function immediately above this deletion — so the hunks overlapped and this PR went conflicting. Rebased onto bb4feab.

Both .ps1 files auto-merged; the only real conflict was the install-k8s.ps1 line in scripts/manifest.sha256, where both commits changed the same hash. Resolved by re-running gen-manifest.sh rather than picking a side — the merged file matches neither parent's hash, so either side would have been wrong. Verified the committed hash equals shasum -a 256 scripts/install-k8s.ps1.

Re-verified the premise on post-#516develop before continuing: Get-WslConfigContent still had no caller there, and #516 touched its test only as diff context (no added dependency). #516's rewritten Get-WslConfigMemoryGb and all 8 of its new assertions are intact on this branch.

Test plan

All repo gates re-run against the rebased tree, green:

• Invoke-Pester scripts/tests/ — 376 passed, 0 failed, 9 skipped (incl. all installer scripts verified against the signed manifest). fix(#418): .wslconfig memory can't be written below the client's own floor #516 reported 377; this removes exactly one test.
• Invoke-ScriptAnalyzer -Path scripts/install.ps1, scripts/install-k8s.ps1 -Severity Error,Warning — 0 Errors (236 Warnings, all pre-existing style rules). Compared against the new base: BASE (bb4feab): Errors=0 Warnings=236 / HEAD (rebased): Errors=0 Warnings=236 — this PR introduces no new findings.
• bash scripts/check-style.sh — ok: style + terminology clean
• bash scripts/tests/check-drift.sh — no drift.
• bash scripts/gen-manifest.sh — regenerated, scripts/manifest.sha256 committed (R8 gate)

Diff is 3 files: −6 lines in install-k8s.ps1, −5 in the test, 1 hash line in the manifest.

_{Local-environment notes, both unrelated to this change. (1) The two pwsh gates had to be run against a copy of scripts/ at a space-free path — PowerShell 7.5.2's filesystem provider silently enumerates zero entries under this checkout's parent dir (Claude File System), so the literal gate commands report "No test files were found" there rather than failing loudly. CI checkout paths have no spaces. (2) Invoke-ScriptAnalyzer -Path in PSScriptAnalyzer 1.25.0 rejects a two-path array (Cannot convert 'System.Object[]' to ... 'System.String') and returns empty, which reads as a false pass — the numbers above come from running it once per file. Worth checking that CI doesn't invoke it in the two-path form.}

Type

Tech-debt — dead-code removal. No behavior change.

🤖 Generated with Claude Code

---

Note

Low Risk
Dead-code removal only; production WSL paths are unchanged and tests still cover Add-WslMemorySetting.

Overview
Removes dead helper Get-WslConfigContent from scripts/install-k8s.ps1 and drops its Pester coverage. That helper built a full .wslconfig from scratch; daily-user WSL memory sizing already goes through Get-WslConfigMemoryGb + Add-WslMemorySetting in Set-DailyUserProvisioning, which merges memory= without overwriting other settings.

Updates scripts/manifest.sha256 for the changed install-k8s.ps1. No installer behavior change.

^{Reviewed by Cursor Bugbot for commit 4b81c48. Bugbot is set up for automated code reviews on this repo. Configure here.}

[shujaatTracebloc]

Approving — clean dead-code removal, independently verified.

What I checked

• Dead-code premise holds.grep -rniI Get-WslConfigContent (and case-insensitive wslconfigcontent) over the whole tree returns zero matches after the removal — the definition and its lone Pester test were the only references.
• Live path is unaffected.Set-DailyUserProvisioning (install-k8s.ps1:1945–1966) provisions .wslconfig via Get-WslConfigMemoryGb + Add-WslMemorySetting (the merge-preserving replacement), never the removed builder. No behavior change.
• R8 manifest gate. Committed hash for scripts/install-k8s.ps1 equals shasum -a 256 of the file. ✓
• Diff is exactly as described — −6 in install-k8s.ps1, −5 in the test, 1 hash line in the manifest.
• CI fully green (Pester, ScriptAnalyzer/Static analysis, drift, all Prereqs/PATH/E2E matrices) and Cursor Bugbot reports no findings.

Brought the branch current with develop (merged the docs-only RFC-0003 commit; manifest still matches, CI re-ran green).

Nice catch pulling this out of #516. LGTM. 🚀

[LukasWodka]

/fr-pass