Skip to content

docs: retire the fixed-assignee rule (it names a former code owner) - #533

Merged
saadqbal merged 1 commit into
developfrom
docs/retire-fixed-assignee
Aug 3, 2026
Merged

docs: retire the fixed-assignee rule (it names a former code owner)#533
saadqbal merged 1 commit into
developfrom
docs/retire-fixed-assignee

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

CLAUDE.md instructed every author to assign every PR in this repo to saadqbal, unconditionally:

Every PR you create must be assigned to saadqbal (Asad). … No exceptions

That was accurate when Asad was the de-facto code owner here. It is legacy now, and it conflicts with two things that supersede it:

  • RFC-BACKEND-0008 D31 — the assignee is whoever is doing the work, set by the author when the PR is opened. Assignee and reviewer are different roles.
  • The org-level CLAUDE.md, which says the same.

It also has a practical cost: a fixed assignee re-creates the bystander effect the author-picks model was adopted to remove. If every PR is assigned to the same person, nobody owns any of them — which is the opposite of the rule's stated intent ("orphaned PRs fall through the review queue").

Surfaced while an agent working in this repo hit the contradiction directly: repo CLAUDE.md said saadqbal, the task said the actual worker.

Change

One paragraph in CLAUDE.md → the D31 rule, plus a note on why the old line existed so nobody restores it.

Test plan

Documentation only. No workflow, script, chart or installer file touched.

Refs: tracebloc/backend#1405

🤖 Generated with Claude Code


Note

Low Risk
Documentation-only change to contributor guidance; no workflows, scripts, or runtime behavior.

Overview
PR conventions in CLAUDE.md no longer require every PR to be assigned to saadqbal. The rule now matches RFC-BACKEND-0008 D31: the author assigns whoever is doing the work, and assignee (merge ownership) is separate from reviewer.

A second paragraph explains why the old fixed assignee existed and warns against restoring it, since a single default assignee undermines the author-picks model and recreates bystander effects. Reviewer choice stays with the author; there is no automated reviewer pick.

Reviewed by Cursor Bugbot for commit 5865e76. Bugbot is set up for automated code reviews on this repo. Configure here.

CLAUDE.md told every author to assign every PR to saadqbal unconditionally.
That was true when he was the de-facto code owner for this repo; it is not
true now, and it contradicts RFC-BACKEND-0008 D31 (assignee = whoever is
doing the work, set by the author) and the org CLAUDE.md.
A fixed assignee also re-creates the bystander effect the author-picks model
was adopted to remove: if every PR is assigned to the same person, nobody
owns any of them.
Refs: tracebloc/backend#1405
@LukasWodkaLukasWodka self-assigned this Aug 2, 2026
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

👋 Heads-up — Code review queue is at 49 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@saadqbal
saadqbal merged commit 4846a99 into developAug 3, 2026
15 checks passed
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

/fr-pass

@LukasWodka
LukasWodka deleted the docs/retire-fixed-assignee branch August 14, 2026 13:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@LukasWodka@saadqbal