Uh oh!
There was an error while loading. Please reload this page.
docs: retire the fixed-assignee rule (it names a former code owner) - #533
Merged
Conversation
CLAUDE.md told every author to assign every PR to saadqbal unconditionally. That was true when he was the de-facto code owner for this repo; it is not true now, and it contradicts RFC-BACKEND-0008 D31 (assignee = whoever is doing the work, set by the author) and the org CLAUDE.md. A fixed assignee also re-creates the bystander effect the author-picks model was adopted to remove: if every PR is assigned to the same person, nobody owns any of them. Refs: tracebloc/backend#1405
LukasWodka
commented
Aug 2, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 49 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
saadqbal
approved these changes
Aug 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
LukasWodka
commented
Aug 3, 2026
ContributorAuthor
/fr-pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdinstructed every author to assign every PR in this repo tosaadqbal, unconditionally:That was accurate when Asad was the de-facto code owner here. It is legacy now, and it conflicts with two things that supersede it:
CLAUDE.md, which says the same.It also has a practical cost: a fixed assignee re-creates the bystander effect the author-picks model was adopted to remove. If every PR is assigned to the same person, nobody owns any of them — which is the opposite of the rule's stated intent ("orphaned PRs fall through the review queue").
Surfaced while an agent working in this repo hit the contradiction directly: repo
CLAUDE.mdsaidsaadqbal, the task said the actual worker.Change
One paragraph in
CLAUDE.md→ the D31 rule, plus a note on why the old line existed so nobody restores it.Test plan
Documentation only. No workflow, script, chart or installer file touched.
Refs: tracebloc/backend#1405
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only change to contributor guidance; no workflows, scripts, or runtime behavior.
Overview
PR conventions in
CLAUDE.mdno longer require every PR to be assigned tosaadqbal. The rule now matches RFC-BACKEND-0008 D31: the author assigns whoever is doing the work, and assignee (merge ownership) is separate from reviewer.A second paragraph explains why the old fixed assignee existed and warns against restoring it, since a single default assignee undermines the author-picks model and recreates bystander effects. Reviewer choice stays with the author; there is no automated reviewer pick.
Reviewed by Cursor Bugbot for commit 5865e76. Bugbot is set up for automated code reviews on this repo. Configure here.