Uh oh!
There was an error while loading. Please reload this page.
fix(installer): lowercase 'tracebloc' in user-facing copy + drift guard (#586) - #587
Merged
Merged
Conversation
…rd (#586) House-style alignment (from the #576 review): the product name is lowercase `tracebloc` always, and the installers must feel one-to-one across platforms (bash is the gold standard). PowerShell had capital-T "Tracebloc" in two user-facing lines while the rest of the copy is lowercase. - install.ps1: "Downloading Tracebloc client installer" / "Running Tracebloc environment setup" -> lowercase `tracebloc`. - check-style.sh: new guard fails on capital-T `Tracebloc` in user-facing text so the casing can't drift again (same spirit as the #435 single-source facts guard). Exempts comments + PascalCase identifiers (Get-Tracebloc… , the TraceblocInstallerResume resume key); honours `# style-guard: allow`. Verified: check-style.sh clean; the guard flags a real "Tracebloc client" line and excludes identifiers/comments; shellcheck + PS parse clean. Closes#586. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saadqbal
approved these changes
Aug 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#586. House-style alignment from the #576 review.
Problem
The installer copy should feel one-to-one across platforms, with the product name lowercase
tracebloc, always (the bash script is the gold standard). PowerShell had capital-T "Tracebloc" in two user-facing lines while the rest of its copy is lowercase — a per-platform drift.Change
install.ps1:"Downloading Tracebloc client installer"/"Running Tracebloc environment setup"→ lowercasetracebloc.check-style.sh(the "Static analysis" CI gate): a new guard that fails on capital-TTraceblocin user-facing text, so the casing can't drift again — same spirit as the feat(installer): single-source installer facts (versions, hosts, timeouts, floors) + CI behavior-parity gate (RFC-CLIENT-0003 D3/D4) #435 single-source installer-facts guard. It exempts comments and PascalCase code identifiers (Get-Tracebloc…function names, theTraceblocInstallerResumeresume key), and honours the# style-guard: allowopt-out.Verified
check-style.shclean; the guard flags a real"Tracebloc client"line and excludes identifiers/comments;shellcheck+ PS parse clean. No behaviour change — user-facing copy only.Follow-up (not here)
A fuller shared cross-platform message catalog is a larger refactor; this guard already enforces the product-name consistency the drift caused.
Note
Low Risk
User-facing installer copy only plus a static style guard; no runtime, auth, or install logic changes.
Overview
Aligns Windows bootstrap user-facing strings with house style: the product name is always lowercase
tracebloc(bash installer is the reference).install.ps1now says “Downloading tracebloc client installer…” and “Running tracebloc environment setup…” instead of capital-T Tracebloc.check-style.shgains a fourth CI check that fails on capital-TTraceblocinscripts/*.shand*.ps1, with the same opt-out pattern as other guards. Comments, PascalCase identifiers (Get-Tracebloc…,TraceblocInstallerResume), and# style-guard: allowlines are exempt so legitimate code names are not flagged.Reviewed by Cursor Bugbot for commit bd62a81. Bugbot is set up for automated code reviews on this repo. Configure here.