Uh oh!
There was an error while loading. Please reload this page.
fix(#343): stop stamping GPU_LIMITS on CPU-only installs - #617
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
divyasinghds added a commit
that referenced
this pull request
Aug 6, 2026
…gbot) A chart-direct install that omits env.GPU_LIMITS was still emitting GPU_REQUESTS via its "nvidia.com/gpu=1" fallback, so CPU-only installs kept a phantom GPU and any chart-direct install could ask for a GPU request with no matching limit (rejected by the API server). Gate GPU_REQUESTS with the same `(default "" .Values.env.GPU_LIMITS)` condition in both the api and pods-monitor containers so a CPU-only install emits neither var and a GPU install emits both (request==limit). Also bump client/Chart.yaml version 1.9.15 -> 1.9.16 so the chart content change is publishable (chart-version-guard). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5e50d99. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Only render the GPU_LIMITS env var when a GPU is actually configured (a non-empty .Values.env.GPU_LIMITS). A CPU-only install writes GPU_LIMITS: "" and a chart-direct install may omit the key entirely; previously the template still emitted the var (or its "nvidia.com/gpu=1" default), surfacing a phantom GPU in the CLI resources view that the CLI had to normalize away client-side. Applied to both the api and pods-monitor containers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…gbot) A chart-direct install that omits env.GPU_LIMITS was still emitting GPU_REQUESTS via its "nvidia.com/gpu=1" fallback, so CPU-only installs kept a phantom GPU and any chart-direct install could ask for a GPU request with no matching limit (rejected by the API server). Gate GPU_REQUESTS with the same `(default "" .Values.env.GPU_LIMITS)` condition in both the api and pods-monitor containers so a CPU-only install emits neither var and a GPU install emits both (request==limit). Also bump client/Chart.yaml version 1.9.15 -> 1.9.16 so the chart content change is publishable (chart-version-guard). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
divyasinghdsforce-pushed
the
fix/343-gpu-limits-cpu-only
branch
from
August 6, 2026 10:55
5e50d99 to
f5d5ee3Comparesaadqbal
approved these changes
Aug 6, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#343.
Fix
Only stamp the
GPU_LIMITSenv var (both jobs-manager containers) when a GPU value is actually configured (non-empty), removing the phantom-GPU source on CPU-only installs.Files
client/templates/jobs-manager-deployment.yamlValidation
helm template— 2GPU_LIMITSentries when set, 0 when empty/absent.🤖 Generated with Claude Code
Note
Low Risk
Scoped Helm templating change for optional GPU env vars; GPU-enabled installs keep paired request/limit behavior.
Overview
Fixes #343 by changing how the jobs-manager Helm template sets GPU-related env on the api and pods-monitor containers.
GPU_REQUESTSandGPU_LIMITSare only rendered whenenv.GPU_LIMITSis non-empty. CPU-only installs (emptyGPU_LIMITSor the key omitted) no longer get those vars or the previousnvidia.com/gpu=1default, which was showing a phantom GPU in the CLI resources view. GPU installs still emit both request and limit together;GPU_LIMITSis taken from values without a chart default inside the gated block.Chart version bumps to 1.9.22.
Reviewed by Cursor Bugbot for commit f5d5ee3. Bugbot is set up for automated code reviews on this repo. Configure here.