Uh oh!
There was an error while loading. Please reload this page.
fix(installer): installer-set SSL_CERT_FILE shouldn't read as a pre-set bundle to verify (client#631) - #632
Merged
Conversation
…to verify' (client#631) On the curl|bash Linux path install.sh exports SSL_CERT_FILE from TRACEBLOC_CA_BUNDLE before launching install-k8s.sh, so wire_ca_trust always saw it pre-set, took the 'kept' branch, told the operator to verify their pre-set bundle (which the installer itself just set), and never reported the cosign/helm wiring. Treat a var already pointing at our CA (-ef) as wired; only a genuinely different pre-set takes 'kept'.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4c60e0d. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
…#631) cluster.sh is a manifest-covered bootstrap file; its recorded sha256 was stale after the wire_ca_trust change, so the verified curl|bash installer would reject it.
saadqbal
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Medium from the 2026-08-06 prod hop (scripts/lib/cluster.sh).
On the primary
curl | bashLinux path,install.shexportsSSL_CERT_FILEfromTRACEBLOC_CA_BUNDLEbefore launchinginstall-k8s.sh, sowire_ca_trustalways saw it pre-set → took thekeptbranch → told the operator "keeping your pre-set SSL_CERT_FILE, make sure it includes your company's CA" for a variable the installer itself just set from that CA, and never reported the cosign/helm wiring.Fix: a var already pointing at our CA (
$ca, compared with-effor file identity) is treated as wired (reports "Trusting your company's certificate for cosign, helm"). Only a genuinely different operator pre-set bundle takes thekept/verify branch.-efis robust to relative/absolute/symlink path differences.Closes#631.
Note
Low Risk
Small installer messaging/trust-branch logic change in cluster.sh with no security model change; manifest checksum updated accordingly.
Overview
wire_ca_trustno longer treatsSSL_CERT_FILE/GIT_SSL_CAINFOas a foreign “pre-set bundle to verify” when they already refer to the same corporate CA file the installer resolved ($ca). The condition now also exports when the var is unset or when it is the same file as$ca(-ef, so path/symlink differences do not matter).On the usual
curl | bashpath,install.shexportsSSL_CERT_FILEfromTRACEBLOC_CA_BUNDLEbeforeinstall-k8s.shrunswire_ca_trust, so operators previously always saw the “keeping your pre-set…” hint and never the success line for cosign/helm wiring. Only a genuinely different pre-set bundle still uses the kept/verify branch.scripts/manifest.sha256is updated forscripts/lib/cluster.sh.Reviewed by Cursor Bugbot for commit 3702084. Bugbot is set up for automated code reviews on this repo. Configure here.