Uh oh!
There was an error while loading. Please reload this page.
fix(ci): arm code-quality — gitleaks was a required check that could not fail (backend#1681) - #104
Merged
Merged
Conversation
…not fail (backend#1681)
`soft-fail` was left at its default of true, so every code-quality job in this
repo reported findings and then exited 0 — including the credential scan. On
this repo gitleaks and house-rules are REQUIRED status checks, so they were
required checks incapable of failing.
backend#1303 ("flip code-quality to required per repo once its backlog is
clean"), which the deferring comment pointed at, closed 2026-07-31. Measured
the most recent run on this repo before flipping: zero real findings for
gitleaks, house-rules and action-pins (the only annotations are GitHub's
Node-20 deprecation notice). So this arms a green check rather than
importing a backlog.
Also corrects the comment claiming the pin check is "Independent of soft-fail
above" — there was no soft-fail above.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>shujaatTracebloc
approved these changes
Aug 11, 2026
shujaatTracebloc
left a comment
Contributor
There was a problem hiding this comment.
Arms code-quality: soft-fail flipped to false so gitleaks + house-rules — which are REQUIRED status checks here — can actually fail instead of reporting findings and exiting 0 (a required check that could not fail). Justified: backend#1303 closed 2026-07-31 and the latest run shows zero real findings, so this keeps a green check green rather than importing a backlog; also fixes the missing EOF newline. Green, no threads. LGTM.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sets
soft-fail: falseon this repo'scode-qualitycaller.Why this is a real gap, not tidying
soft-faildefaults to true, so every job in this caller —gitleaks,house-rules,action-pins— reported its findings and then exited 0. On this repoquality / gitleaksandquality / house-rulesare required status checks. They were required checks that could not fail: a genuine secret could be flagged and the PR would still be green and mergeable.Found by the round-2 pipeline audit (backend#1681), which measured this across the fleet: 12 of 16 repos pass
soft-fail: false; this repo was one of four that did not.Why it is safe to arm now
gitleaks,house-rulesandaction-pins. The only annotations present are GitHub's platform-level "Node.js 20 is deprecated" notice, which is not a code-quality finding.python/shellarefalsehere, soruff/shellcheck/formatare skipped and unaffected.So this arms a check that is already green rather than importing a backlog.
Also fixed
The comment claiming the pin check is "Independent of soft-fail above" — there is no
soft-failabove it, and under the shared reusable's current OR-expression that claim was false. (The expression itself is fixed separately in tracebloc/.github#207; this PR is correct either way, since both inputs are nowfalse.)Parent epic: backend#1680.
Note
Low Risk
Workflow-input-only change that tightens CI enforcement; no application or data-path changes, and checks were already green before arming.
Overview
Sets
soft-fail: falseon the reusablecode-qualityworkflow caller sogitleaks,house-rules, and related jobs fail the check when they report findings instead of exiting 0 under the previous default.Comments are updated to record backend#1681: required status checks on this repo were effectively advisory until now; recent runs showed no backlog, so arming does not block merges on existing noise. The action-pins comment is corrected to note that pin enforcement is tied to the same
soft-failposture, not independent of it.Reviewed by Cursor Bugbot for commit 2ab036d. Bugbot is set up for automated code reviews on this repo. Configure here.