Uh oh!
There was an error while loading. Please reload this page.
docs(forecasting): replace wrong numeric sequence-length/horizon defaults with the real sources - #67
Conversation
…eal sources The forecasting accordion claimed sequence length defaults to 60 and forecast horizon to 1. Neither is a platform default: the effective values come from the model template's module-level declarations (lstm/gru/rnn declare 60/1, patch_tst 96/24, timesfm 512/128), from the notebook setters, or — only when neither sets a value — from the backend's stored defaults (25/1). The 60 in the engine is an unreachable fallback on the platform path. Mirror the TSC section's approach (#66): name where the values come from and point readers at the experiment view instead of asserting a number that is wrong for most paths. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 124133a. Configure here.
LukasWodka
commented
Jul 23, 2026
👋 Heads-up — Code review queue is at 32 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
…emplate-override rule Follow-up to the interim correction: now that backend#1196 has ratified Option A, positively state the platform-canonical defaults (sequence length 25, forecast horizon 1) and that model templates commonly declare their own window and override them — rather than only removing the old wrong numbers. Completes the docs item of the #1196 alignment checklist. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
divyasinghds
commented
Jul 23, 2026
Pushed 56edc87: now that backend#1196 ratified Option A, this positively states the platform-canonical defaults (sequence length 25, forecast horizon 1) and the template-override rule, rather than only removing the wrong numbers. Completes the docs item of the #1196 checklist. |
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
The forecasting accordion in
join-use-case/how-training-works.mdxclaimed the sliding-window sequence length "you set in the notebook" defaults to 60, and forecast horizon to 1. Neither number is a platform default — 60 is only the engine's internalparameters.get("sequence_length", 60)fallback, which platform runs can never hit (the backend always sends the stored value inexperiment_parameters).What a no-touch forecasting experiment actually runs with (verified end-to-end on develop, 2026-07-23):
lstm/gru/rnndeclare60/1, butpatch_tstdeclares96/24andtimesfm512/128. The SDK's upload rewriter extracts and retains these for time-series categories, and they flow through the experiment payload to the engine.Noneis dropped from the form-encoded POST) and the backend's model defaults apply: 25/1.reset_training_plan()before a successfulstart()(which happens automatically after a failed submission) → the SDK re-seeds 24/12 and submits those.So "default 60"/"default 1" is accidentally right only for path 1 with the basic templates. This PR replaces the numeric claims with the actual sources (template declarations / notebook setters) and points readers at the experiment view — the same approach the new TSC section takes in #66.
Canonicalizing one cross-layer default (and aligning SDK/backend/engine) is tracked in tracebloc/backend#1196; once the team ratifies a number, the docs can state it.
Type
Test plan
validation/rewriter.py,training/submitter.py,link_model_dataset.py), backend (metaApi/models/Experiment.py,common/utils/bus_client_util.py) and tracebloc-engine (core/domains/time_series/base.py)🤖 Generated with Claude Code
Note
Low Risk
Documentation-only wording change with no runtime or API impact.
Overview
Time series forecasting docs in
how-training-works.mdxno longer claim lookback sequence length defaults to 60 from the notebook or that forecast horizon defaults to 1 in a misleading way.The sliding-window bullet now states that both values come from model template declarations or notebook settings, with platform fallbacks of 25 and 1 when nothing is set, and that templates often override those defaults—readers are directed to the experiment view for what actually ran.
Reviewed by Cursor Bugbot for commit 56edc87. Bugbot is set up for automated code reviews on this repo. Configure here.