Uh oh!
There was an error while loading. Please reload this page.
docs: model files build locally — hub-referenced models not supported (#1495) - #77
Draft
LukasWodka wants to merge 1 commit into
Draft
docs: model files build locally — hub-referenced models not supported (#1495)#77LukasWodka wants to merge 1 commit into
LukasWodka wants to merge 1 commit into
Conversation
… (#1495) Document the #1495 contract on the Customize Models page: a model file must build its architecture from local code; tracebloc does not fetch models, weights, tokenizers, or configs from an external hub (HuggingFace) at training time. Removes the retired model_id / hf_token 'additional variables' and adds the pretrained-weights-upload + tokenizer.json guidance and the strict weight-load note. Refs #1151. Documents #1495. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saqlainsyed007
left a comment
Contributor
There was a problem hiding this comment.
Content LGTM — accurate, and cleanly scoped. Verified:
- Both internal anchors resolve:
#use-pre-trained-weights→ the existing Use Pre-trained Weights heading, and the self-reference#models-build-locally-no-external-hubs→ this new section's heading. - The retired variables are fully removed — no dangling
model_id/hf_token/tokenizer_idreferences remain anywhere in the doc; the only mentions left are the two that deliberately name them as no-longer-supported. - The new section documents the #1495 contract at the right place (the canonical Customize Models page), and the strict weight-load Note matches the "build the same architecture" requirement.
Holding the formal approval (commenting, not approving) purely on your own prod-timing gate: docs develop auto-deploys to production, and this describes behavior that isn't live until backend#1505 + tracebloc-py-package#380 reach prod. The content is ready — approve/merge once those are deployed and you un-draft, per your note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the #1495 contract on the Customize Models page (
join-use-case/model-optimization.mdx):from_pretrained("<hub-id>"), nomodel_id/tokenizer_id/hf_token. Start from pretrained by downloading weights once and uploading them; ship atokenizer.jsonfor NLP.model_id/hf_tokenadditional variables (they now fail upload) and points to the new section.developauto-deploys to production, and this describes behavior that isn't live until backend#1505 + tracebloc-py-package#380 reach prod. Un-draft + merge once they're deployed.Refs #1151 · Documents #1495.
🤖 Generated with Claude Code