Skip to content

fix: Updated MissingMinVersionTLS query to check go version#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mschwager merged 2 commits into from
Dec 18, 2025
Merged

fix: Updated MissingMinVersionTLS query to check go version #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d881241
fix: Updated MissingMinVersionTLS query to check go version
Apostlex0 Dec 8, 2025
65fcd82
code fixes
Apostlex0 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions go/src/docs/security/MissingMinVersionTLS/MissingMinVersionTLS.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
# Missing MinVersion in tls.Config
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers. TLS1.0 is considered deprecated and should not be used.
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, the default depends on the Go version in use:

- Since **Go 1.18**, clients default to TLS 1.2 (previously TLS 1.0)
- Since **Go 1.22**, servers also default to TLS 1.2 (previously TLS 1.0)

For projects that support older Go versions, leaving `MinVersion` unset may still permit TLS 1.0 or 1.1, which are deprecated and should not be used.

This query flags `tls.Config` values where `MinVersion` is never set explicitly and the project's `go.mod` declares support for:
- **Go < 1.18** for client-side configs (when client default is TLS 1.0)
- **Go < 1.22** for server-side configs (when server default is TLS 1.0)

## Recommendation
Explicitly set tls version to an up-to-date one.
Explicitly set the TLS version to TLS 1.2 or higher:
- For projects using Go < 1.18: Set `MinVersion` for both clients and servers
- For projects using Go 1.18-1.21: Set `MinVersion` for servers
- For projects using Go >= 1.22: Defaults are secure, but explicit setting is still recommended


## Example
Expand DownExpand Up@@ -50,8 +61,15 @@ func main() {
}

```
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. The `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even that it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. For projects with `go` directive < 1.22, the `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even though it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.

Note: The query behavior depends on the `go` directive in `go.mod`:
- **Go < 1.18**: Both client and server configs without MinVersion are flagged
- **Go 1.18-1.21**: Only server configs without MinVersion are flagged
- **Go >= 1.22**: No configs are flagged (both defaults are secure)


## References
* [tls.Config specification](https://pkg.go.dev/crypto/tls#Config)
* [Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side](https://tip.golang.org/doc/go1.18#tls10)
* [Go 1.22 Release Notes - TLS 1.2 default for servers](https://tip.golang.org/doc/go1.22#minor_library_changes)
42 changes: 35 additions & 7 deletions go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qhelp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,29 +4,57 @@
<qhelp>
<overview>
<p>
Golang's <code>tls.Config</code> struct accepts <code>MinVersion</code> parameter that sets minimum accepted TLS version.
If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers.
TLS1.0 is considered deprecated and should not be used.
Golang's <code>tls.Config</code> struct accepts a <code>MinVersion</code> parameter that sets the minimum accepted TLS version.
If the parameter is not provided, the default depends on the Go version in use. Since Go 1.18, <code>crypto/tls</code> clients default to TLS 1.2 (previously TLS 1.0).
Since Go 1.22, <code>crypto/tls</code> servers also default to TLS 1.2 (previously TLS 1.0).
</p>
<p>
This query flags <code>tls.Config</code> values where <code>MinVersion</code> is never set explicitly and the project's
<code>go.mod</code> declares support for a Go version where the defaults are insecure:
</p>
<ul>
<li>Go &lt; 1.18 for client-side configs (when client default is TLS 1.0)</li>
<li>Go &lt; 1.22 for server-side configs (when server default is TLS 1.0)</li>
</ul>
<p>
TLS 1.0 and 1.1 are deprecated and should not be used.
</p>

</overview>
<recommendation>
<p>Explicitly set tls version to an up-to-date one.</p>
<p>Explicitly set the TLS version to TLS 1.2 or higher:</p>
<ul>
<li>For projects using Go &lt; 1.18: Set <code>MinVersion</code> for both clients and servers</li>
<li>For projects using Go 1.18-1.21: Set <code>MinVersion</code> for servers</li>
<li>For projects using Go &gt;= 1.22: Defaults are secure, but explicit setting is still recommended</li>
</ul>

</recommendation>
<example>
<sample src="MissingMinVersionTLS.go" />

<p>In this example, the <code>http.Server</code> may be set with TLS configuration created by either <code>test1</code> or <code>test2</code> functions.
The <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even that it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
For projects with a <code>go</code> directive &lt; 1.22, the <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even though it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
</p>
<p>Note: The query behavior depends on the <code>go</code> directive in <code>go.mod</code>:</p>
<ul>
<li>Go &lt; 1.18: Both client and server configs without MinVersion are flagged</li>
<li>Go 1.18-1.21: Only server configs without MinVersion are flagged</li>
<li>Go &gt;= 1.22: No configs are flagged (both defaults are secure)</li>
</ul>

</example>
<references>
<li>
<a href="https://pkg.go.dev/crypto/tls#Config">tls.Config specification</a>
</li>
<li>
<a href="https://tip.golang.org/doc/go1.18#tls10">Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side</a>
</li>
<li>
<a href="https://tip.golang.org/doc/go1.22#minor_library_changes">Go 1.22 Release Notes - TLS 1.2 default for servers</a>
</li>
</references>
</qhelp>
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix: Updated MissingMinVersionTLS query to check go version by Apostlex0 · Pull Request #29 · trailofbits/codeql-queries · GitHub
Skip to content
fix: Updated MissingMinVersionTLS query to check go version#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mschwager
merged 2 commits into

from

Dec 18, 2025
 Merged


fix: Updated MissingMinVersionTLS query to check go version
#29
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d881241

fix: Updated MissingMinVersionTLS query to check go version


Apostlex0 Dec 8, 2025
65fcd82

code fixes


Apostlex0 Dec 17, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 21 additions & 3 deletions
go/src/docs/security/MissingMinVersionTLS/MissingMinVersionTLS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
# Missing MinVersion in tls.Config
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers. TLS1.0 is considered deprecated and should not be used.
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, the default depends on the Go version in use:

- Since **Go 1.18**, clients default to TLS 1.2 (previously TLS 1.0)
- Since **Go 1.22**, servers also default to TLS 1.2 (previously TLS 1.0)

For projects that support older Go versions, leaving `MinVersion` unset may still permit TLS 1.0 or 1.1, which are deprecated and should not be used.

This query flags `tls.Config` values where `MinVersion` is never set explicitly and the project's `go.mod` declares support for:
- **Go < 1.18** for client-side configs (when client default is TLS 1.0)
- **Go < 1.22** for server-side configs (when server default is TLS 1.0)

## Recommendation
Explicitly set tls version to an up-to-date one.
Explicitly set the TLS version to TLS 1.2 or higher:
- For projects using Go < 1.18: Set `MinVersion` for both clients and servers
- For projects using Go 1.18-1.21: Set `MinVersion` for servers
- For projects using Go >= 1.22: Defaults are secure, but explicit setting is still recommended


## Example
Expand DownExpand Up@@ -50,8 +61,15 @@ func main() {
}

```
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. The `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even that it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. For projects with `go` directive < 1.22, the `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even though it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.

Note: The query behavior depends on the `go` directive in `go.mod`:
- **Go < 1.18**: Both client and server configs without MinVersion are flagged
- **Go 1.18-1.21**: Only server configs without MinVersion are flagged
- **Go >= 1.22**: No configs are flagged (both defaults are secure)


## References
* [tls.Config specification](https://pkg.go.dev/crypto/tls#Config)
* [Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side](https://tip.golang.org/doc/go1.18#tls10)
* [Go 1.22 Release Notes - TLS 1.2 default for servers](https://tip.golang.org/doc/go1.22#minor_library_changes)

42 changes: 35 additions & 7 deletions
go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qhelp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,29 +4,57 @@
<qhelp>
<overview>
<p>
Golang's <code>tls.Config</code> struct accepts <code>MinVersion</code> parameter that sets minimum accepted TLS version.
If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers.
TLS1.0 is considered deprecated and should not be used. 
Golang's <code>tls.Config</code> struct accepts a <code>MinVersion</code> parameter that sets the minimum accepted TLS version.
If the parameter is not provided, the default depends on the Go version in use. Since Go 1.18, <code>crypto/tls</code> clients default to TLS 1.2 (previously TLS 1.0).
Since Go 1.22, <code>crypto/tls</code> servers also default to TLS 1.2 (previously TLS 1.0).
</p>
<p>
This query flags <code>tls.Config</code> values where <code>MinVersion</code> is never set explicitly and the project's
<code>go.mod</code> declares support for a Go version where the defaults are insecure:
</p>
<ul>
<li>Go &lt; 1.18 for client-side configs (when client default is TLS 1.0)</li>
<li>Go &lt; 1.22 for server-side configs (when server default is TLS 1.0)</li>
</ul>
<p>
TLS 1.0 and 1.1 are deprecated and should not be used.
</p>

</overview>
<recommendation>
<p>Explicitly set tls version to an up-to-date one.</p>
<p>Explicitly set the TLS version to TLS 1.2 or higher:</p>
<ul>
<li>For projects using Go &lt; 1.18: Set <code>MinVersion</code> for both clients and servers</li>
<li>For projects using Go 1.18-1.21: Set <code>MinVersion</code> for servers</li>
<li>For projects using Go &gt;= 1.22: Defaults are secure, but explicit setting is still recommended</li>
</ul>

</recommendation>
<example>
<sample src="MissingMinVersionTLS.go" />

<p>In this example, the <code>http.Server</code> may be set with TLS configuration created by either <code>test1</code> or <code>test2</code> functions.
The <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even that it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
For projects with a <code>go</code> directive &lt; 1.22, the <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even though it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
</p>
<p>Note: The query behavior depends on the <code>go</code> directive in <code>go.mod</code>:</p>
<ul>
<li>Go &lt; 1.18: Both client and server configs without MinVersion are flagged</li>
<li>Go 1.18-1.21: Only server configs without MinVersion are flagged</li>
<li>Go &gt;= 1.22: No configs are flagged (both defaults are secure)</li>
</ul>

</example>
<references>
<li>
 <a href="https://pkg.go.dev/crypto/tls#Config">tls.Config specification</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.18#tls10">Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.22#minor_library_changes">Go 1.22 Release Notes - TLS 1.2 default for servers</a>
</li>
</references>
</qhelp>
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: Updated MissingMinVersionTLS query to check go version by Apostlex0 · Pull Request #29 · trailofbits/codeql-queries · GitHub
Skip to content
fix: Updated MissingMinVersionTLS query to check go version#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mschwager
merged 2 commits into

from

Dec 18, 2025
 Merged


fix: Updated MissingMinVersionTLS query to check go version
#29
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d881241

fix: Updated MissingMinVersionTLS query to check go version


Apostlex0 Dec 8, 2025
65fcd82

code fixes


Apostlex0 Dec 17, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 21 additions & 3 deletions
go/src/docs/security/MissingMinVersionTLS/MissingMinVersionTLS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
# Missing MinVersion in tls.Config
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers. TLS1.0 is considered deprecated and should not be used.
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, the default depends on the Go version in use:

- Since **Go 1.18**, clients default to TLS 1.2 (previously TLS 1.0)
- Since **Go 1.22**, servers also default to TLS 1.2 (previously TLS 1.0)

For projects that support older Go versions, leaving `MinVersion` unset may still permit TLS 1.0 or 1.1, which are deprecated and should not be used.

This query flags `tls.Config` values where `MinVersion` is never set explicitly and the project's `go.mod` declares support for:
- **Go < 1.18** for client-side configs (when client default is TLS 1.0)
- **Go < 1.22** for server-side configs (when server default is TLS 1.0)

## Recommendation
Explicitly set tls version to an up-to-date one.
Explicitly set the TLS version to TLS 1.2 or higher:
- For projects using Go < 1.18: Set `MinVersion` for both clients and servers
- For projects using Go 1.18-1.21: Set `MinVersion` for servers
- For projects using Go >= 1.22: Defaults are secure, but explicit setting is still recommended


## Example
Expand DownExpand Up@@ -50,8 +61,15 @@ func main() {
}

```
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. The `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even that it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. For projects with `go` directive < 1.22, the `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even though it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.

Note: The query behavior depends on the `go` directive in `go.mod`:
- **Go < 1.18**: Both client and server configs without MinVersion are flagged
- **Go 1.18-1.21**: Only server configs without MinVersion are flagged
- **Go >= 1.22**: No configs are flagged (both defaults are secure)


## References
* [tls.Config specification](https://pkg.go.dev/crypto/tls#Config)
* [Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side](https://tip.golang.org/doc/go1.18#tls10)
* [Go 1.22 Release Notes - TLS 1.2 default for servers](https://tip.golang.org/doc/go1.22#minor_library_changes)

42 changes: 35 additions & 7 deletions
go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qhelp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,29 +4,57 @@
<qhelp>
<overview>
<p>
Golang's <code>tls.Config</code> struct accepts <code>MinVersion</code> parameter that sets minimum accepted TLS version.
If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers.
TLS1.0 is considered deprecated and should not be used. 
Golang's <code>tls.Config</code> struct accepts a <code>MinVersion</code> parameter that sets the minimum accepted TLS version.
If the parameter is not provided, the default depends on the Go version in use. Since Go 1.18, <code>crypto/tls</code> clients default to TLS 1.2 (previously TLS 1.0).
Since Go 1.22, <code>crypto/tls</code> servers also default to TLS 1.2 (previously TLS 1.0).
</p>
<p>
This query flags <code>tls.Config</code> values where <code>MinVersion</code> is never set explicitly and the project's
<code>go.mod</code> declares support for a Go version where the defaults are insecure:
</p>
<ul>
<li>Go &lt; 1.18 for client-side configs (when client default is TLS 1.0)</li>
<li>Go &lt; 1.22 for server-side configs (when server default is TLS 1.0)</li>
</ul>
<p>
TLS 1.0 and 1.1 are deprecated and should not be used.
</p>

</overview>
<recommendation>
<p>Explicitly set tls version to an up-to-date one.</p>
<p>Explicitly set the TLS version to TLS 1.2 or higher:</p>
<ul>
<li>For projects using Go &lt; 1.18: Set <code>MinVersion</code> for both clients and servers</li>
<li>For projects using Go 1.18-1.21: Set <code>MinVersion</code> for servers</li>
<li>For projects using Go &gt;= 1.22: Defaults are secure, but explicit setting is still recommended</li>
</ul>

</recommendation>
<example>
<sample src="MissingMinVersionTLS.go" />

<p>In this example, the <code>http.Server</code> may be set with TLS configuration created by either <code>test1</code> or <code>test2</code> functions.
The <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even that it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
For projects with a <code>go</code> directive &lt; 1.22, the <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even though it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
</p>
<p>Note: The query behavior depends on the <code>go</code> directive in <code>go.mod</code>:</p>
<ul>
<li>Go &lt; 1.18: Both client and server configs without MinVersion are flagged</li>
<li>Go 1.18-1.21: Only server configs without MinVersion are flagged</li>
<li>Go &gt;= 1.22: No configs are flagged (both defaults are secure)</li>
</ul>

</example>
<references>
<li>
 <a href="https://pkg.go.dev/crypto/tls#Config">tls.Config specification</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.18#tls10">Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.22#minor_library_changes">Go 1.22 Release Notes - TLS 1.2 default for servers</a>
</li>
</references>
</qhelp>
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: Updated MissingMinVersionTLS query to check go version by Apostlex0 · Pull Request #29 · trailofbits/codeql-queries · GitHub
Skip to content
fix: Updated MissingMinVersionTLS query to check go version#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mschwager
merged 2 commits into

from

Dec 18, 2025
 Merged


fix: Updated MissingMinVersionTLS query to check go version
#29
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d881241

fix: Updated MissingMinVersionTLS query to check go version


Apostlex0 Dec 8, 2025
65fcd82

code fixes


Apostlex0 Dec 17, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 21 additions & 3 deletions
go/src/docs/security/MissingMinVersionTLS/MissingMinVersionTLS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
# Missing MinVersion in tls.Config
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers. TLS1.0 is considered deprecated and should not be used.
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, the default depends on the Go version in use:

- Since **Go 1.18**, clients default to TLS 1.2 (previously TLS 1.0)
- Since **Go 1.22**, servers also default to TLS 1.2 (previously TLS 1.0)

For projects that support older Go versions, leaving `MinVersion` unset may still permit TLS 1.0 or 1.1, which are deprecated and should not be used.

This query flags `tls.Config` values where `MinVersion` is never set explicitly and the project's `go.mod` declares support for:
- **Go < 1.18** for client-side configs (when client default is TLS 1.0)
- **Go < 1.22** for server-side configs (when server default is TLS 1.0)

## Recommendation
Explicitly set tls version to an up-to-date one.
Explicitly set the TLS version to TLS 1.2 or higher:
- For projects using Go < 1.18: Set `MinVersion` for both clients and servers
- For projects using Go 1.18-1.21: Set `MinVersion` for servers
- For projects using Go >= 1.22: Defaults are secure, but explicit setting is still recommended


## Example
Expand DownExpand Up@@ -50,8 +61,15 @@ func main() {
}

```
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. The `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even that it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. For projects with `go` directive < 1.22, the `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even though it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.

Note: The query behavior depends on the `go` directive in `go.mod`:
- **Go < 1.18**: Both client and server configs without MinVersion are flagged
- **Go 1.18-1.21**: Only server configs without MinVersion are flagged
- **Go >= 1.22**: No configs are flagged (both defaults are secure)


## References
* [tls.Config specification](https://pkg.go.dev/crypto/tls#Config)
* [Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side](https://tip.golang.org/doc/go1.18#tls10)
* [Go 1.22 Release Notes - TLS 1.2 default for servers](https://tip.golang.org/doc/go1.22#minor_library_changes)

42 changes: 35 additions & 7 deletions
go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qhelp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,29 +4,57 @@
<qhelp>
<overview>
<p>
Golang's <code>tls.Config</code> struct accepts <code>MinVersion</code> parameter that sets minimum accepted TLS version.
If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers.
TLS1.0 is considered deprecated and should not be used. 
Golang's <code>tls.Config</code> struct accepts a <code>MinVersion</code> parameter that sets the minimum accepted TLS version.
If the parameter is not provided, the default depends on the Go version in use. Since Go 1.18, <code>crypto/tls</code> clients default to TLS 1.2 (previously TLS 1.0).
Since Go 1.22, <code>crypto/tls</code> servers also default to TLS 1.2 (previously TLS 1.0).
</p>
<p>
This query flags <code>tls.Config</code> values where <code>MinVersion</code> is never set explicitly and the project's
<code>go.mod</code> declares support for a Go version where the defaults are insecure:
</p>
<ul>
<li>Go &lt; 1.18 for client-side configs (when client default is TLS 1.0)</li>
<li>Go &lt; 1.22 for server-side configs (when server default is TLS 1.0)</li>
</ul>
<p>
TLS 1.0 and 1.1 are deprecated and should not be used.
</p>

</overview>
<recommendation>
<p>Explicitly set tls version to an up-to-date one.</p>
<p>Explicitly set the TLS version to TLS 1.2 or higher:</p>
<ul>
<li>For projects using Go &lt; 1.18: Set <code>MinVersion</code> for both clients and servers</li>
<li>For projects using Go 1.18-1.21: Set <code>MinVersion</code> for servers</li>
<li>For projects using Go &gt;= 1.22: Defaults are secure, but explicit setting is still recommended</li>
</ul>

</recommendation>
<example>
<sample src="MissingMinVersionTLS.go" />

<p>In this example, the <code>http.Server</code> may be set with TLS configuration created by either <code>test1</code> or <code>test2</code> functions.
The <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even that it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
For projects with a <code>go</code> directive &lt; 1.22, the <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even though it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
</p>
<p>Note: The query behavior depends on the <code>go</code> directive in <code>go.mod</code>:</p>
<ul>
<li>Go &lt; 1.18: Both client and server configs without MinVersion are flagged</li>
<li>Go 1.18-1.21: Only server configs without MinVersion are flagged</li>
<li>Go &gt;= 1.22: No configs are flagged (both defaults are secure)</li>
</ul>

</example>
<references>
<li>
 <a href="https://pkg.go.dev/crypto/tls#Config">tls.Config specification</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.18#tls10">Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.22#minor_library_changes">Go 1.22 Release Notes - TLS 1.2 default for servers</a>
</li>
</references>
</qhelp>
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix: Updated MissingMinVersionTLS query to check go version by Apostlex0 · Pull Request #29 · trailofbits/codeql-queries · GitHub
Skip to content
fix: Updated MissingMinVersionTLS query to check go version#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mschwager
merged 2 commits into

from

Dec 18, 2025
 Merged


fix: Updated MissingMinVersionTLS query to check go version
#29
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d881241

fix: Updated MissingMinVersionTLS query to check go version


Apostlex0 Dec 8, 2025
65fcd82

code fixes


Apostlex0 Dec 17, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 21 additions & 3 deletions
go/src/docs/security/MissingMinVersionTLS/MissingMinVersionTLS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
# Missing MinVersion in tls.Config
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers. TLS1.0 is considered deprecated and should not be used.
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, the default depends on the Go version in use:

- Since **Go 1.18**, clients default to TLS 1.2 (previously TLS 1.0)
- Since **Go 1.22**, servers also default to TLS 1.2 (previously TLS 1.0)

For projects that support older Go versions, leaving `MinVersion` unset may still permit TLS 1.0 or 1.1, which are deprecated and should not be used.

This query flags `tls.Config` values where `MinVersion` is never set explicitly and the project's `go.mod` declares support for:
- **Go < 1.18** for client-side configs (when client default is TLS 1.0)
- **Go < 1.22** for server-side configs (when server default is TLS 1.0)

## Recommendation
Explicitly set tls version to an up-to-date one.
Explicitly set the TLS version to TLS 1.2 or higher:
- For projects using Go < 1.18: Set `MinVersion` for both clients and servers
- For projects using Go 1.18-1.21: Set `MinVersion` for servers
- For projects using Go >= 1.22: Defaults are secure, but explicit setting is still recommended


## Example
Expand DownExpand Up@@ -50,8 +61,15 @@ func main() {
}

```
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. The `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even that it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. For projects with `go` directive < 1.22, the `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even though it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.

Note: The query behavior depends on the `go` directive in `go.mod`:
- **Go < 1.18**: Both client and server configs without MinVersion are flagged
- **Go 1.18-1.21**: Only server configs without MinVersion are flagged
- **Go >= 1.22**: No configs are flagged (both defaults are secure)


## References
* [tls.Config specification](https://pkg.go.dev/crypto/tls#Config)
* [Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side](https://tip.golang.org/doc/go1.18#tls10)
* [Go 1.22 Release Notes - TLS 1.2 default for servers](https://tip.golang.org/doc/go1.22#minor_library_changes)

42 changes: 35 additions & 7 deletions
go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qhelp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,29 +4,57 @@
<qhelp>
<overview>
<p>
Golang's <code>tls.Config</code> struct accepts <code>MinVersion</code> parameter that sets minimum accepted TLS version.
If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers.
TLS1.0 is considered deprecated and should not be used. 
Golang's <code>tls.Config</code> struct accepts a <code>MinVersion</code> parameter that sets the minimum accepted TLS version.
If the parameter is not provided, the default depends on the Go version in use. Since Go 1.18, <code>crypto/tls</code> clients default to TLS 1.2 (previously TLS 1.0).
Since Go 1.22, <code>crypto/tls</code> servers also default to TLS 1.2 (previously TLS 1.0).
</p>
<p>
This query flags <code>tls.Config</code> values where <code>MinVersion</code> is never set explicitly and the project's
<code>go.mod</code> declares support for a Go version where the defaults are insecure:
</p>
<ul>
<li>Go &lt; 1.18 for client-side configs (when client default is TLS 1.0)</li>
<li>Go &lt; 1.22 for server-side configs (when server default is TLS 1.0)</li>
</ul>
<p>
TLS 1.0 and 1.1 are deprecated and should not be used.
</p>

</overview>
<recommendation>
<p>Explicitly set tls version to an up-to-date one.</p>
<p>Explicitly set the TLS version to TLS 1.2 or higher:</p>
<ul>
<li>For projects using Go &lt; 1.18: Set <code>MinVersion</code> for both clients and servers</li>
<li>For projects using Go 1.18-1.21: Set <code>MinVersion</code> for servers</li>
<li>For projects using Go &gt;= 1.22: Defaults are secure, but explicit setting is still recommended</li>
</ul>

</recommendation>
<example>
<sample src="MissingMinVersionTLS.go" />

<p>In this example, the <code>http.Server</code> may be set with TLS configuration created by either <code>test1</code> or <code>test2</code> functions.
The <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even that it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
For projects with a <code>go</code> directive &lt; 1.22, the <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even though it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
</p>
<p>Note: The query behavior depends on the <code>go</code> directive in <code>go.mod</code>:</p>
<ul>
<li>Go &lt; 1.18: Both client and server configs without MinVersion are flagged</li>
<li>Go 1.18-1.21: Only server configs without MinVersion are flagged</li>
<li>Go &gt;= 1.22: No configs are flagged (both defaults are secure)</li>
</ul>

</example>
<references>
<li>
 <a href="https://pkg.go.dev/crypto/tls#Config">tls.Config specification</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.18#tls10">Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.22#minor_library_changes">Go 1.22 Release Notes - TLS 1.2 default for servers</a>
</li>
</references>
</qhelp>
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: Updated MissingMinVersionTLS query to check go version by Apostlex0 · Pull Request #29 · trailofbits/codeql-queries · GitHub
Skip to content
fix: Updated MissingMinVersionTLS query to check go version#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mschwager
merged 2 commits into

from

Dec 18, 2025
 Merged


fix: Updated MissingMinVersionTLS query to check go version
#29
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d881241

fix: Updated MissingMinVersionTLS query to check go version


Apostlex0 Dec 8, 2025
65fcd82

code fixes


Apostlex0 Dec 17, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 21 additions & 3 deletions
go/src/docs/security/MissingMinVersionTLS/MissingMinVersionTLS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
# Missing MinVersion in tls.Config
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers. TLS1.0 is considered deprecated and should not be used.
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, the default depends on the Go version in use:

- Since **Go 1.18**, clients default to TLS 1.2 (previously TLS 1.0)
- Since **Go 1.22**, servers also default to TLS 1.2 (previously TLS 1.0)

For projects that support older Go versions, leaving `MinVersion` unset may still permit TLS 1.0 or 1.1, which are deprecated and should not be used.

This query flags `tls.Config` values where `MinVersion` is never set explicitly and the project's `go.mod` declares support for:
- **Go < 1.18** for client-side configs (when client default is TLS 1.0)
- **Go < 1.22** for server-side configs (when server default is TLS 1.0)

## Recommendation
Explicitly set tls version to an up-to-date one.
Explicitly set the TLS version to TLS 1.2 or higher:
- For projects using Go < 1.18: Set `MinVersion` for both clients and servers
- For projects using Go 1.18-1.21: Set `MinVersion` for servers
- For projects using Go >= 1.22: Defaults are secure, but explicit setting is still recommended


## Example
Expand DownExpand Up@@ -50,8 +61,15 @@ func main() {
}

```
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. The `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even that it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. For projects with `go` directive < 1.22, the `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even though it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.

Note: The query behavior depends on the `go` directive in `go.mod`:
- **Go < 1.18**: Both client and server configs without MinVersion are flagged
- **Go 1.18-1.21**: Only server configs without MinVersion are flagged
- **Go >= 1.22**: No configs are flagged (both defaults are secure)


## References
* [tls.Config specification](https://pkg.go.dev/crypto/tls#Config)
* [Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side](https://tip.golang.org/doc/go1.18#tls10)
* [Go 1.22 Release Notes - TLS 1.2 default for servers](https://tip.golang.org/doc/go1.22#minor_library_changes)

42 changes: 35 additions & 7 deletions
go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qhelp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,29 +4,57 @@
<qhelp>
<overview>
<p>
Golang's <code>tls.Config</code> struct accepts <code>MinVersion</code> parameter that sets minimum accepted TLS version.
If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers.
TLS1.0 is considered deprecated and should not be used. 
Golang's <code>tls.Config</code> struct accepts a <code>MinVersion</code> parameter that sets the minimum accepted TLS version.
If the parameter is not provided, the default depends on the Go version in use. Since Go 1.18, <code>crypto/tls</code> clients default to TLS 1.2 (previously TLS 1.0).
Since Go 1.22, <code>crypto/tls</code> servers also default to TLS 1.2 (previously TLS 1.0).
</p>
<p>
This query flags <code>tls.Config</code> values where <code>MinVersion</code> is never set explicitly and the project's
<code>go.mod</code> declares support for a Go version where the defaults are insecure:
</p>
<ul>
<li>Go &lt; 1.18 for client-side configs (when client default is TLS 1.0)</li>
<li>Go &lt; 1.22 for server-side configs (when server default is TLS 1.0)</li>
</ul>
<p>
TLS 1.0 and 1.1 are deprecated and should not be used.
</p>

</overview>
<recommendation>
<p>Explicitly set tls version to an up-to-date one.</p>
<p>Explicitly set the TLS version to TLS 1.2 or higher:</p>
<ul>
<li>For projects using Go &lt; 1.18: Set <code>MinVersion</code> for both clients and servers</li>
<li>For projects using Go 1.18-1.21: Set <code>MinVersion</code> for servers</li>
<li>For projects using Go &gt;= 1.22: Defaults are secure, but explicit setting is still recommended</li>
</ul>

</recommendation>
<example>
<sample src="MissingMinVersionTLS.go" />

<p>In this example, the <code>http.Server</code> may be set with TLS configuration created by either <code>test1</code> or <code>test2</code> functions.
The <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even that it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
For projects with a <code>go</code> directive &lt; 1.22, the <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even though it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
</p>
<p>Note: The query behavior depends on the <code>go</code> directive in <code>go.mod</code>:</p>
<ul>
<li>Go &lt; 1.18: Both client and server configs without MinVersion are flagged</li>
<li>Go 1.18-1.21: Only server configs without MinVersion are flagged</li>
<li>Go &gt;= 1.22: No configs are flagged (both defaults are secure)</li>
</ul>

</example>
<references>
<li>
 <a href="https://pkg.go.dev/crypto/tls#Config">tls.Config specification</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.18#tls10">Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.22#minor_library_changes">Go 1.22 Release Notes - TLS 1.2 default for servers</a>
</li>
</references>
</qhelp>
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: Updated MissingMinVersionTLS query to check go version by Apostlex0 · Pull Request #29 · trailofbits/codeql-queries · GitHub
Skip to content
fix: Updated MissingMinVersionTLS query to check go version#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mschwager
merged 2 commits into

from

Dec 18, 2025
 Merged


fix: Updated MissingMinVersionTLS query to check go version
#29
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d881241

fix: Updated MissingMinVersionTLS query to check go version


Apostlex0 Dec 8, 2025
65fcd82

code fixes


Apostlex0 Dec 17, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 21 additions & 3 deletions
go/src/docs/security/MissingMinVersionTLS/MissingMinVersionTLS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
# Missing MinVersion in tls.Config
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers. TLS1.0 is considered deprecated and should not be used.
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, the default depends on the Go version in use:

- Since **Go 1.18**, clients default to TLS 1.2 (previously TLS 1.0)
- Since **Go 1.22**, servers also default to TLS 1.2 (previously TLS 1.0)

For projects that support older Go versions, leaving `MinVersion` unset may still permit TLS 1.0 or 1.1, which are deprecated and should not be used.

This query flags `tls.Config` values where `MinVersion` is never set explicitly and the project's `go.mod` declares support for:
- **Go < 1.18** for client-side configs (when client default is TLS 1.0)
- **Go < 1.22** for server-side configs (when server default is TLS 1.0)

## Recommendation
Explicitly set tls version to an up-to-date one.
Explicitly set the TLS version to TLS 1.2 or higher:
- For projects using Go < 1.18: Set `MinVersion` for both clients and servers
- For projects using Go 1.18-1.21: Set `MinVersion` for servers
- For projects using Go >= 1.22: Defaults are secure, but explicit setting is still recommended


## Example
Expand DownExpand Up@@ -50,8 +61,15 @@ func main() {
}

```
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. The `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even that it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. For projects with `go` directive < 1.22, the `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even though it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.

Note: The query behavior depends on the `go` directive in `go.mod`:
- **Go < 1.18**: Both client and server configs without MinVersion are flagged
- **Go 1.18-1.21**: Only server configs without MinVersion are flagged
- **Go >= 1.22**: No configs are flagged (both defaults are secure)


## References
* [tls.Config specification](https://pkg.go.dev/crypto/tls#Config)
* [Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side](https://tip.golang.org/doc/go1.18#tls10)
* [Go 1.22 Release Notes - TLS 1.2 default for servers](https://tip.golang.org/doc/go1.22#minor_library_changes)

42 changes: 35 additions & 7 deletions
go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qhelp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,29 +4,57 @@
<qhelp>
<overview>
<p>
Golang's <code>tls.Config</code> struct accepts <code>MinVersion</code> parameter that sets minimum accepted TLS version.
If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers.
TLS1.0 is considered deprecated and should not be used. 
Golang's <code>tls.Config</code> struct accepts a <code>MinVersion</code> parameter that sets the minimum accepted TLS version.
If the parameter is not provided, the default depends on the Go version in use. Since Go 1.18, <code>crypto/tls</code> clients default to TLS 1.2 (previously TLS 1.0).
Since Go 1.22, <code>crypto/tls</code> servers also default to TLS 1.2 (previously TLS 1.0).
</p>
<p>
This query flags <code>tls.Config</code> values where <code>MinVersion</code> is never set explicitly and the project's
<code>go.mod</code> declares support for a Go version where the defaults are insecure:
</p>
<ul>
<li>Go &lt; 1.18 for client-side configs (when client default is TLS 1.0)</li>
<li>Go &lt; 1.22 for server-side configs (when server default is TLS 1.0)</li>
</ul>
<p>
TLS 1.0 and 1.1 are deprecated and should not be used.
</p>

</overview>
<recommendation>
<p>Explicitly set tls version to an up-to-date one.</p>
<p>Explicitly set the TLS version to TLS 1.2 or higher:</p>
<ul>
<li>For projects using Go &lt; 1.18: Set <code>MinVersion</code> for both clients and servers</li>
<li>For projects using Go 1.18-1.21: Set <code>MinVersion</code> for servers</li>
<li>For projects using Go &gt;= 1.22: Defaults are secure, but explicit setting is still recommended</li>
</ul>

</recommendation>
<example>
<sample src="MissingMinVersionTLS.go" />

<p>In this example, the <code>http.Server</code> may be set with TLS configuration created by either <code>test1</code> or <code>test2</code> functions.
The <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even that it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
For projects with a <code>go</code> directive &lt; 1.22, the <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even though it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
</p>
<p>Note: The query behavior depends on the <code>go</code> directive in <code>go.mod</code>:</p>
<ul>
<li>Go &lt; 1.18: Both client and server configs without MinVersion are flagged</li>
<li>Go 1.18-1.21: Only server configs without MinVersion are flagged</li>
<li>Go &gt;= 1.22: No configs are flagged (both defaults are secure)</li>
</ul>

</example>
<references>
<li>
 <a href="https://pkg.go.dev/crypto/tls#Config">tls.Config specification</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.18#tls10">Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.22#minor_library_changes">Go 1.22 Release Notes - TLS 1.2 default for servers</a>
</li>
</references>
</qhelp>
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix: Updated MissingMinVersionTLS query to check go version by Apostlex0 · Pull Request #29 · trailofbits/codeql-queries · GitHub
Skip to content
fix: Updated MissingMinVersionTLS query to check go version#29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mschwager
merged 2 commits into

from

Dec 18, 2025
 Merged


fix: Updated MissingMinVersionTLS query to check go version
#29
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d881241

fix: Updated MissingMinVersionTLS query to check go version


Apostlex0 Dec 8, 2025
65fcd82

code fixes


Apostlex0 Dec 17, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


24 changes: 21 additions & 3 deletions
go/src/docs/security/MissingMinVersionTLS/MissingMinVersionTLS.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
# Missing MinVersion in tls.Config
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers. TLS1.0 is considered deprecated and should not be used.
Golang's `tls.Config` struct accepts `MinVersion` parameter that sets minimum accepted TLS version. If the parameter is not provided, the default depends on the Go version in use:

- Since **Go 1.18**, clients default to TLS 1.2 (previously TLS 1.0)
- Since **Go 1.22**, servers also default to TLS 1.2 (previously TLS 1.0)

For projects that support older Go versions, leaving `MinVersion` unset may still permit TLS 1.0 or 1.1, which are deprecated and should not be used.

This query flags `tls.Config` values where `MinVersion` is never set explicitly and the project's `go.mod` declares support for:
- **Go < 1.18** for client-side configs (when client default is TLS 1.0)
- **Go < 1.22** for server-side configs (when server default is TLS 1.0)

## Recommendation
Explicitly set tls version to an up-to-date one.
Explicitly set the TLS version to TLS 1.2 or higher:
- For projects using Go < 1.18: Set `MinVersion` for both clients and servers
- For projects using Go 1.18-1.21: Set `MinVersion` for servers
- For projects using Go >= 1.22: Defaults are secure, but explicit setting is still recommended


## Example
Expand DownExpand Up@@ -50,8 +61,15 @@ func main() {
}

```
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. The `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even that it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.
In this example, the `http.Server` may be set with TLS configuration created by either `test1` or `test2` functions. For projects with `go` directive < 1.22, the `test1` result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version. The `test2` result will not be marked, even though it also uses the default value for minimum version. That is because the `test2` is explicit, and this query assumes that developers knew what they are doing.

Note: The query behavior depends on the `go` directive in `go.mod`:
- **Go < 1.18**: Both client and server configs without MinVersion are flagged
- **Go 1.18-1.21**: Only server configs without MinVersion are flagged
- **Go >= 1.22**: No configs are flagged (both defaults are secure)


## References
* [tls.Config specification](https://pkg.go.dev/crypto/tls#Config)
* [Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side](https://tip.golang.org/doc/go1.18#tls10)
* [Go 1.22 Release Notes - TLS 1.2 default for servers](https://tip.golang.org/doc/go1.22#minor_library_changes)

42 changes: 35 additions & 7 deletions
go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.qhelp

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,29 +4,57 @@
<qhelp>
<overview>
<p>
Golang's <code>tls.Config</code> struct accepts <code>MinVersion</code> parameter that sets minimum accepted TLS version.
If the parameter is not provided, default value is used: TLS1.2 for clients, and TLS1.0 for servers.
TLS1.0 is considered deprecated and should not be used. 
Golang's <code>tls.Config</code> struct accepts a <code>MinVersion</code> parameter that sets the minimum accepted TLS version.
If the parameter is not provided, the default depends on the Go version in use. Since Go 1.18, <code>crypto/tls</code> clients default to TLS 1.2 (previously TLS 1.0).
Since Go 1.22, <code>crypto/tls</code> servers also default to TLS 1.2 (previously TLS 1.0).
</p>
<p>
This query flags <code>tls.Config</code> values where <code>MinVersion</code> is never set explicitly and the project's
<code>go.mod</code> declares support for a Go version where the defaults are insecure:
</p>
<ul>
<li>Go &lt; 1.18 for client-side configs (when client default is TLS 1.0)</li>
<li>Go &lt; 1.22 for server-side configs (when server default is TLS 1.0)</li>
</ul>
<p>
TLS 1.0 and 1.1 are deprecated and should not be used.
</p>

</overview>
<recommendation>
<p>Explicitly set tls version to an up-to-date one.</p>
<p>Explicitly set the TLS version to TLS 1.2 or higher:</p>
<ul>
<li>For projects using Go &lt; 1.18: Set <code>MinVersion</code> for both clients and servers</li>
<li>For projects using Go 1.18-1.21: Set <code>MinVersion</code> for servers</li>
<li>For projects using Go &gt;= 1.22: Defaults are secure, but explicit setting is still recommended</li>
</ul>

</recommendation>
<example>
<sample src="MissingMinVersionTLS.go" />

<p>In this example, the <code>http.Server</code> may be set with TLS configuration created by either <code>test1</code> or <code>test2</code> functions.
The <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even that it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
For projects with a <code>go</code> directive &lt; 1.22, the <code>test1</code> result will be highlighted by this query, as it fails to explicitly set minimum supported TLS version.
The <code>test2</code> result will not be marked, even though it also uses the default value for minimum version.
That is because the <code>test2</code> is explicit, and this query assumes that developers knew what they are doing.
</p>
<p>Note: The query behavior depends on the <code>go</code> directive in <code>go.mod</code>:</p>
<ul>
<li>Go &lt; 1.18: Both client and server configs without MinVersion are flagged</li>
<li>Go 1.18-1.21: Only server configs without MinVersion are flagged</li>
<li>Go &gt;= 1.22: No configs are flagged (both defaults are secure)</li>
</ul>

</example>
<references>
<li>
 <a href="https://pkg.go.dev/crypto/tls#Config">tls.Config specification</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.18#tls10">Go 1.18 Release Notes - TLS 1.0 and 1.1 disabled by default client-side</a>
</li>
<li>
 <a href="https://tip.golang.org/doc/go1.22#minor_library_changes">Go 1.22 Release Notes - TLS 1.2 default for servers</a>
</li>
</references>
</qhelp>
Loading