Skip to content

Drop unused spatie/calendar-links dependency - #189

Merged
edalzell merged 1 commit into
mainfrom
claude/github-issue-188-review-93ybiu
Aug 21, 2026
Merged

Drop unused spatie/calendar-links dependency#189
edalzell merged 1 commit into
mainfrom
claude/github-issue-188-review-93ybiu

Conversation

@edalzell

@edalzelledalzell commented Aug 21, 2026

Copy link
Copy Markdown
Member

Closes#188.

@steveparks is correct — spatie/calendar-links is no longer used anywhere in this addon. All calendar/ICS generation goes through spatie/icalendar-generator.

Verification

A search across the whole repo (src/, tests/, resources/, routes/, docs, templates) for CalendarLinks / calendar-links returns exactly one hit: the require entry in composer.json itself. The only Spatie imports remaining are:

src/Http/Controllers/IcsController.php:12 Spatie\IcalendarGenerator\Components\Calendar
src/Http/Controllers/IcsController.php:13 Spatie\IcalendarGenerator\Components\Event
src/Types/RecurringEvent.php:9-11 Spatie\IcalendarGenerator\{Components\Event, Enums\RecurrenceFrequency, ValueObjects\RRule}
src/Types/MultiDayEvent.php:11 Spatie\IcalendarGenerator\Components\Event
src/Types/Event.php:12 Spatie\IcalendarGenerator\Components\Event
src/Day.php:6 Spatie\IcalendarGenerator\Components\Event

Change

Removes the "spatie/calendar-links": "^1.0" line from composer.json. Nothing else needed — no imports, no config, no docs referenced it.

This is purely a dependency cleanup with no behaviour change, but it does unconstrain consumers' dependency graphs (the ^1.0 pin was holding back anyone who wanted a newer calendar-links for their own use).

Note: the branch name doesn't match the pr-labeler.yml patterns, so you may want to add the chore label manually for release-drafter.


Generated by Claude Code


Note

Low Risk
Dependency-only cleanup with no runtime or API changes.

Overview
Removes unused spatie/calendar-links from composer.json. ICS generation already uses spatie/icalendar-generator only; no code, config, or docs referenced the dropped package.

Reviewed by Cursor Bugbot for commit 62af124. Bugbot is set up for automated code reviews on this repo. Configure here.

The package hasn't been used since the addon moved to
spatie/icalendar-generator in v4. There are no remaining references to
Spatie\CalendarLinks anywhere in the codebase, so the requirement is a
leftover that only constrains consumers' dependency graphs.
Closes#188
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Xw4jZB7SwYKsbtdJ3yyG7e
@edalzell
edalzell merged commit 3a008cc into mainAug 21, 2026
27 checks passed
@edalzell
edalzell deleted the claude/github-issue-188-review-93ybiu branch August 21, 2026 20:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Spatie Calendar Links?

2 participants

@edalzell@claude