Uh oh!
There was an error while loading. Please reload this page.
Drop unused spatie/calendar-links dependency - #189
Merged
Conversation
The package hasn't been used since the addon moved to spatie/icalendar-generator in v4. There are no remaining references to Spatie\CalendarLinks anywhere in the codebase, so the requirement is a leftover that only constrains consumers' dependency graphs. Closes#188 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xw4jZB7SwYKsbtdJ3yyG7e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#188.
@steveparks is correct —
spatie/calendar-linksis no longer used anywhere in this addon. All calendar/ICS generation goes throughspatie/icalendar-generator.Verification
A search across the whole repo (
src/,tests/,resources/,routes/, docs, templates) forCalendarLinks/calendar-linksreturns exactly one hit: therequireentry incomposer.jsonitself. The only Spatie imports remaining are:Change
Removes the
"spatie/calendar-links": "^1.0"line fromcomposer.json. Nothing else needed — no imports, no config, no docs referenced it.This is purely a dependency cleanup with no behaviour change, but it does unconstrain consumers' dependency graphs (the
^1.0pin was holding back anyone who wanted a newercalendar-linksfor their own use).Note: the branch name doesn't match the
pr-labeler.ymlpatterns, so you may want to add thechorelabel manually for release-drafter.Generated by Claude Code
Note
Low Risk
Dependency-only cleanup with no runtime or API changes.
Overview
Removes unused
spatie/calendar-linksfromcomposer.json. ICS generation already usesspatie/icalendar-generatoronly; no code, config, or docs referenced the dropped package.Reviewed by Cursor Bugbot for commit 62af124. Bugbot is set up for automated code reviews on this repo. Configure here.