Skip to content

Pin @types/react and @types/react-dom to 18.x to avoid TS errors from mixed versions#3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matt-aitken wants to merge 1 commit into from
Closed

Pin @types/react and @types/react-dom to 18.x to avoid TS errors from mixed versions #3267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -88,6 +88,8 @@
"overrides": {
"typescript": "5.5.4",
"@types/node": "20.14.14",
"@types/react": "18.2.69",
"@types/react-dom": "18.2.7",
Comment on lines +91 to +92

@coderabbitaicoderabbitaiBotMar 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash# Description: Find all packages declaring React types and check for React 19 API usageecho"=== Packages declaring `@types/react` ==="
fd -t f "package.json"| xargs rg -l "@types/react"|whileread -r file;doecho -e "\n📦 $file"
cat "$file"| jq -r '.devDependencies["@types/react"] // .dependencies["@types/react"] // empty'| sed 's/^/ `@types`\/react: /'
cat "$file"| jq -r '.devDependencies["@types/react-dom"] // .dependencies["@types/react-dom"] // empty'| sed 's/^/ `@types`\/react-dom: /'doneecho -e "\n=== Searching for React 19 API usage in d3-chat ==="
rg -n --type=ts --type=tsx -g 'references/d3-chat/**/*''\b(useActionState|useFormStatus|useOptimistic|use\(|startTransition|experimental_taintObjectReference)\b'||echo"No React 19 API usage found"echo -e "\n=== Checking if affected packages are public ==="forpkgin packages/react-hooks packages/cli-v3;doif [ -f"$pkg/package.json" ];thenecho -e "\n📦 $pkg"
cat "$pkg/package.json"| jq -r 'if .private == true then " Private: true" else " Public or not specified (likely public)" end'fidone

Repository: triggerdotdev/trigger.dev

Length of output: 1220

React version override affects multiple packages and needs clarification on intended scope.

The pnpm.overrides pins all packages to React 18 types, but several packages in references/ explicitly declare React 19 types: d3-chat, realtime-streams, realtime-hooks-test, and d3-openai-agents (all using ^19). While a search found no React 19 API usage in d3-chat, the override will still silently downgrade all four packages.

Additionally, packages/react-hooks and packages/rsc use wildcards ("*") for both type packages, which now pin to 18.2.69. If these packages are meant to support multiple React versions, pinning them this way may mask compatibility issues.

Clarify:

  • Is the downgrade of React 19 packages intentional, or should they remain unpinned?
  • Should packages/react-hooks and packages/rsc use explicit version constraints instead of wildcards?
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` around lines 91 - 92, The pnpm.overrides currently pins
`@types/react` and `@types/react-dom` to 18.2.69 which silently downgrades packages
under references/ (d3-chat, realtime-streams, realtime-hooks-test,
d3-openai-agents) that declare ^19 and also masks compatibility for
packages/react-hooks and packages/rsc that use "*" — decide and implement one of
two fixes: either remove the global override and only add per-package overrides
for the specific packages that must remain on 18, or keep the override but
change the four references/* packages to explicit `@types/react/`@types/react-dom
^18 or remove their ^19 constraint; additionally replace "*" in
packages/react-hooks and packages/rsc with explicit version ranges (e.g., ^18 ||
^19) if they must support multiple React versions, and update pnpm.overrides
entries to target only the package names that truly require the 18.x types (use
the pnpm.overrides key names and package names d3-chat, realtime-streams,
realtime-hooks-test, d3-openai-agents, packages/react-hooks, packages/rsc to
locate the changes).

"express@^4>body-parser": "1.20.3",
"@remix-run/dev@2.1.0>tar-fs": "2.1.3",
"testcontainers@10.28.0>tar-fs": "3.0.9",
Expand Down
Loading
Loading