Skip to content

chore: pin react types to 18.x project-wide#3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepshekhardas wants to merge 1 commit into from
Closed

chore: pin react types to 18.x project-wide #3313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -94,6 +94,8 @@
"overrides": {
"typescript": "5.5.4",
"@types/node": "22.20.0",
"@types/react": "18.2.69",
"@types/react-dom": "18.2.7",
Comment on lines +97 to +98

@coderabbitaicoderabbitaiBotJun 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash# Description: Check latest 18.x versions of React type packagesecho"=== `@types/react` latest 18.x version ==="
npm view `@types/react` versions --json | jq -r '.[]'| grep '^18\.'| tail -1
echo -e "\n=== `@types/react-dom` latest 18.x version ==="
npm view `@types/react-dom` versions --json | jq -r '.[]'| grep '^18\.'| tail -1
echo -e "\n=== Checking for security advisories ==="
gh api graphql -f query='{ securityVulnerabilities(first: 5, ecosystem: NPM, package: "`@types/react`") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange firstPatchedVersion { identifier } } }}'

Repository: triggerdotdev/trigger.dev

Length of output: 262

🏁 Script executed:

#!/bin/bashset -euo pipefail
echo"=== Checking security advisories for `@types/react-dom` ==="
gh api graphql -f query='{ securityVulnerabilities(first: 5, ecosystem: NPM, package: "`@types/react-dom`") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange firstPatchedVersion { identifier } } }}'

Repository: triggerdotdev/trigger.dev

Length of output: 176

Bump pinned React type packages to the latest 18.x patch versions

  • @types/react is pinned to 18.2.69, but the latest 18.x patch is 18.3.30.
  • @types/react-dom is pinned to 18.2.7, but the latest 18.x patch is 18.3.7.
  • No GitHub-reported security advisories were found for either package in the vulnerability lookup.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` around lines 93 - 94, The package.json pins for TypeScript
React types are out of date: update the versions for `@types/react` and
`@types/react-dom` to the latest 18.x patch releases; specifically change
`@types/react` from 18.2.69 to 18.3.30 and `@types/react-dom` from 18.2.7 to 18.3.7,
then run your package manager install (npm/yarn/pnpm) and rebuild to ensure type
compatibility; confirm no breaking type changes affect functions/components that
rely on react/react-dom type declarations.

Comment on lines +97 to +98

@devin-ai-integrationdevin-ai-integrationBotJun 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Override silently downgrades trigger-sdk from @types/react 19 to 18

packages/trigger-sdk/package.json declares @types/react: ^19.2.14 as a devDependency, but this override forces it to 18.2.69. This is a significant version downgrade (React 19 → 18 types). I verified that the only React usage in the SDK (packages/trigger-sdk/src/v3/chat-react.ts) uses basic hooks (useCallback, useEffect, useRef, useState) that are fully compatible with React 18 types. However, the explicit ^19.2.14 pin was presumably added intentionally — future code additions to chat-react.ts using React 19 features (e.g., useActionState, use(), or the new ref prop pattern) would silently fail to typecheck correctly since the override masks the package-level declaration. Consider updating the trigger-sdk's package.json devDependency to 18.2.69 to make the intent explicit rather than relying on a global override to silently downgrade it.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +97 to +98

@devin-ai-integrationdevin-ai-integrationBotJun 17, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Lockfile not updated alongside override changes

The commit only modifies package.json without updating pnpm-lock.yaml. Per CLAUDE.md, the process is to edit package.json then run pnpm i from the repo root. The lockfile currently still resolves multiple @types/react versions (18.2.48, 18.2.69, 18.3.1, 19.2.14 per the lockfile). Until pnpm install is run, the overrides won't take effect, and CI environments using --frozen-lockfile would fail due to the mismatch. This is likely just a staging issue (lockfile update expected before merge), but worth confirming.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"react@^18": "18.3.1",
"react-dom@^18": "18.3.1",
"ai@^6": "6.0.116",
Expand Down