Skip to content

fix(core): use Promise.allSettled in TracingSDK flush/shutdown#3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericallam wants to merge 3 commits into from
+31 −2
Closed

fix(core): use Promise.allSettled in TracingSDK flush/shutdown #3562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5b5fde
fix(core): use Promise.allSettled in TracingSDK flush/shutdown
github-actions[bot] May 12, 2026
1e29a72
fix(core): throw AggregateError after Promise.allSettled to preserve …
github-actions[bot] May 12, 2026
d7eae64
fix(core): remove duplicate error logging and improve AggregateError …
github-actions[bot] May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-tracing-sdk-flush.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/core": patch
---

Fixed TracingSDK.flush() and shutdown() to use Promise.allSettled instead of Promise.all, preventing one provider's rejection from abandoning the other providers' in-flight exports. This fixes an issue where user-emitted trace data (logger.info calls, child spans) could be silently dropped on shutdown when any provider fails to flush.
28 changes: 26 additions & 2 deletions packages/core/src/v3/otel/tracingSDK.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -369,19 +369,43 @@ export class TracingSDK {
}

public async flush() {
await Promise.all([
const results = await Promise.allSettled([
this._traceProvider.forceFlush(),
this._logProvider.forceFlush(),
this._meterProvider.forceFlush(),
]);
const providerNames = ["trace", "log", "meter"] as const;
const errors: Error[] = [];
const failedNames: string[] = [];
results.forEach((result, index) => {
if (result.status === "rejected") {
failedNames.push(providerNames[index]);
errors.push(result.reason instanceof Error ? result.reason : new Error(String(result.reason)));
}
});
if (errors.length > 0) {
throw new AggregateError(errors, `One or more providers failed to flush: ${failedNames.join(", ")}`);
}
}
Comment on lines 371 to 389

@devin-ai-integrationdevin-ai-integrationBotMay 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 flush()/shutdown() no longer propagate errors to callers

With Promise.allSettled, flush() and shutdown() now always resolve (never reject), even when individual providers fail. This changes the public API contract. The callers in managed-run-worker.ts:725-738 and dev-run-worker.ts:724-737 (flushTracingSDK) wrap _tracingSDK?.flush() in Promise.race inside an outer Promise.allSettled (managed-run-worker.ts:673, dev-run-worker.ts:687), which tracks success/failure via successfulFlushes/failedFlushes. After this PR, flushTracingSDK will always resolve successfully, so "tracingSDK" will always appear in successfulFlushes even if underlying providers failed. The failure tracking at the flushAll level becomes less precise for tracing SDK failures specifically — though the individual provider errors are still logged to console by the new code. This is arguably the right tradeoff (partial success is better than total failure), but reviewers should be aware the caller-level failure detection for tracing is now effectively bypassed.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


public async shutdown() {
await Promise.all([
const results = await Promise.allSettled([
this._traceProvider.shutdown(),
this._logProvider.shutdown(),
this._meterProvider.shutdown(),
]);
const providerNames = ["trace", "log", "meter"] as const;
const errors: Error[] = [];
const failedNames: string[] = [];
results.forEach((result, index) => {
if (result.status === "rejected") {
failedNames.push(providerNames[index]);
errors.push(result.reason instanceof Error ? result.reason : new Error(String(result.reason)));
}
});
if (errors.length > 0) {
throw new AggregateError(errors, `One or more providers failed to shutdown: ${failedNames.join(", ")}`);
}
}
}

Expand Down
Loading