Uh oh!
There was an error while loading. Please reload this page.
feat(webapp): storybook gallery for the dashboard agent - #4516
feat(webapp): storybook gallery for the dashboard agent#4516kathiekiwi wants to merge 7 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdded client-safe dashboard-agent demo fixtures for investigations, diagnoses, charts, intents, watches, messages, reports, and identifiers. Added reusable chart and intent components. Replaced the agent Storybook route with a manifest-driven gallery for chat, view blocks, reports, investigations, watches, prompts, banners, and wake states. Added dedicated Storybook routes for view blocks, reports, investigations, and watches. Added toast examples and expanded Vitest coverage for fixture schemas, rendering states, navigation targets, and source isolation. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bfe64cc to
1b6dfb1Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
712396b to
e110e90Compare662e92f to
02e1f60Compare@trigger.dev/buildtrigger.dev@trigger.dev/core@trigger.dev/python@trigger.dev/react-hooks@trigger.dev/redis-worker@trigger.dev/rsc@trigger.dev/schema-to-json@trigger.dev/sdkcommit: |
ec08b16 to
c43d49fComparec0f0058 to
e7432a8CompareNote GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
c43d49f to
a71b7e0Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
a71b7e0 to
6587840Compare3a64fb0 to
4dc89f6Compare6587840 to
fc9ce3bCompare4dc89f6 to
5cddeb8Comparefc9ce3b to
3a8fbccCompare| type ViewBlock, | ||
| type WatchResultBlock as WatchResultBlockPayload, | ||
| } from "@internal/dashboard-agent-contracts"; | ||
| import { DEMO_WORLD, demoFixtures } from "~/components/dashboard-agent/demo"; |
There was a problem hiding this comment.
🔍 New test imports React component barrel where sibling tests deliberately avoid it
fixtures.test.ts imports ./fixtures, which imports ~/components/dashboard-agent/demo — a barrel that pulls in DemoChartCard and therefore ~/components/code/QueryResultsChart (recharts/lucide/react-use's useMeasure). The existing dashboard-agent tests avoid loading .tsx modules entirely and instead read source text (e.g. apps/webapp/app/components/dashboard-agent/ReportView.test.ts:1-5). The vitest config declares no environment, so these run under plain node; any DOM access at module scope in that chart dependency chain would make the suite fail to import. Worth confirming the suite actually runs green in CI, or importing demoFixtures from ~/components/dashboard-agent/demo/fixtures directly to keep components out of the test graph.
Was this helpful? React with 👍 or 👎 to provide feedback.
The gallery pages for the agent chat, view blocks, report, investigation and watch cards, the demo fixtures behind them, and the screenshot script. This reverts commit bbdcb0881, which held these back out of the parent PR.
…d pin them to the code that reads them The confirmation card's external notification became a three-state object while the gallery branch sat still, and the report card's untrustworthy reason was renamed under a free-form key that nothing typechecked. Moves the hand-written fixtures into the shared gallery module and checks them against the schemas and readers the product uses, so the next rename fails a test instead of rendering an unreachable state.
5cddeb8 to
f1f8c97Compare3a8fbcc to
305742dCompare
Split out of #4418 so that PR carries only what ships to users.
Adds the agent gallery: five
storybook.agent-*pages (chat UI, view blocks, report, investigation, watch) with their shared shell and manifest, the demo fixtures and two demo-only cards that feed them, the agent toast examples, and the screenshot script.