Skip to content

feat(webapp): storybook gallery for the dashboard agent - #4516

Open
kathiekiwi wants to merge 7 commits into
feat/dashboard-agent-flows-watchfrom
feat/agent-storybook-gallery
Open

feat(webapp): storybook gallery for the dashboard agent#4516
kathiekiwi wants to merge 7 commits into
feat/dashboard-agent-flows-watchfrom
feat/agent-storybook-gallery

Conversation

@kathiekiwi

@kathiekiwikathiekiwi commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Split out of #4418 so that PR carries only what ships to users.

Adds the agent gallery: five storybook.agent-* pages (chat UI, view blocks, report, investigation, watch) with their shared shell and manifest, the demo fixtures and two demo-only cards that feed them, the agent toast examples, and the screenshot script.

Screenshot 2026-08-06 at 00 36 19

@changeset-bot

changeset-botBot commented Aug 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 305742d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1aa09925-1d25-412a-ac52-d1f4033ccd4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Added client-safe dashboard-agent demo fixtures for investigations, diagnoses, charts, intents, watches, messages, reports, and identifiers. Added reusable chart and intent components. Replaced the agent Storybook route with a manifest-driven gallery for chat, view blocks, reports, investigations, watches, prompts, banners, and wake states. Added dedicated Storybook routes for view blocks, reports, investigations, and watches. Added toast examples and expanded Vitest coverage for fixture schemas, rendering states, navigation targets, and source isolation.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Description check⚠️ WarningThe description explains the main changes and includes a screenshot, but it omits the required issue, checklist, testing, and changelog sections.Add the required template sections, complete the checklist, describe testing steps, provide a changelog entry, and reference the closing issue.
Docstring Coverage⚠️ WarningDocstring coverage is 6.15% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: adding a Storybook gallery for the dashboard agent.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/agent-storybook-gallery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@kathiekiwikathiekiwi changed the title Dashboard agent storybook galleryfeat(webapp): storybook gallery for the dashboard agentAug 6, 2026
@kathiekiwi
kathiekiwi marked this pull request as ready for review August 6, 2026 00:07
devin-ai-integration[bot]

This comment was marked as resolved.

@kathiekiwi
kathiekiwiforce-pushed the feat/agent-storybook-gallery branch from bfe64cc to 1b6dfb1CompareAugust 6, 2026 00:56
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@kathiekiwi
kathiekiwi changed the base branch from feat/dashboard-agent-flows to feat/dashboard-agent-flows-watchAugust 7, 2026 12:51
@kathiekiwi
kathiekiwiforce-pushed the feat/dashboard-agent-flows-watch branch from 712396b to e110e90CompareAugust 8, 2026 12:05
@kathiekiwi
kathiekiwiforce-pushed the feat/agent-storybook-gallery branch from 662e92f to 02e1f60CompareAugust 8, 2026 12:28
@pkg-pr-new

pkg-pr-newBot commented Aug 8, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@305742d

trigger.dev

npm i https://pkg.pr.new/trigger.dev@305742d

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@305742d

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@305742d

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@305742d

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@305742d

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@305742d

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@305742d

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@305742d

commit: 305742d

@kathiekiwi
kathiekiwiforce-pushed the feat/agent-storybook-gallery branch 2 times, most recently from ec08b16 to c43d49fCompareAugust 8, 2026 14:30
@kathiekiwi
kathiekiwiforce-pushed the feat/dashboard-agent-flows-watch branch from c0f0058 to e7432a8CompareAugust 8, 2026 14:30
@coderabbitai

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@kathiekiwi
kathiekiwiforce-pushed the feat/agent-storybook-gallery branch from c43d49f to a71b7e0CompareAugust 8, 2026 14:57
coderabbitai[bot]

This comment was marked as resolved.

@kathiekiwi
kathiekiwiforce-pushed the feat/agent-storybook-gallery branch from a71b7e0 to 6587840CompareAugust 8, 2026 16:09
@kathiekiwi
kathiekiwiforce-pushed the feat/dashboard-agent-flows-watch branch from 3a64fb0 to 4dc89f6CompareAugust 8, 2026 17:49
@kathiekiwi
kathiekiwiforce-pushed the feat/agent-storybook-gallery branch from 6587840 to fc9ce3bCompareAugust 8, 2026 17:51
@kathiekiwi
kathiekiwiforce-pushed the feat/dashboard-agent-flows-watch branch from 4dc89f6 to 5cddeb8CompareAugust 8, 2026 18:08
@kathiekiwi
kathiekiwiforce-pushed the feat/agent-storybook-gallery branch from fc9ce3b to 3a8fbccCompareAugust 8, 2026 18:08

@devin-ai-integrationdevin-ai-integrationBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

type ViewBlock,
type WatchResultBlock as WatchResultBlockPayload,
} from "@internal/dashboard-agent-contracts";
import { DEMO_WORLD, demoFixtures } from "~/components/dashboard-agent/demo";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 New test imports React component barrel where sibling tests deliberately avoid it

fixtures.test.ts imports ./fixtures, which imports ~/components/dashboard-agent/demo — a barrel that pulls in DemoChartCard and therefore ~/components/code/QueryResultsChart (recharts/lucide/react-use's useMeasure). The existing dashboard-agent tests avoid loading .tsx modules entirely and instead read source text (e.g. apps/webapp/app/components/dashboard-agent/ReportView.test.ts:1-5). The vitest config declares no environment, so these run under plain node; any DOM access at module scope in that chart dependency chain would make the suite fail to import. Worth confirming the suite actually runs green in CI, or importing demoFixtures from ~/components/dashboard-agent/demo/fixtures directly to keep components out of the test graph.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

The gallery pages for the agent chat, view blocks, report, investigation and
watch cards, the demo fixtures behind them, and the screenshot script.
This reverts commit bbdcb0881, which held these back out of the parent PR.
…d pin them to the code that reads them
The confirmation card's external notification became a three-state object while the
gallery branch sat still, and the report card's untrustworthy reason was renamed
under a free-form key that nothing typechecked. Moves the hand-written fixtures into
the shared gallery module and checks them against the schemas and readers the product
uses, so the next rename fails a test instead of rendering an unreachable state.
@kathiekiwi
kathiekiwiforce-pushed the feat/dashboard-agent-flows-watch branch from 5cddeb8 to f1f8c97CompareAugust 8, 2026 18:22
@kathiekiwi
kathiekiwiforce-pushed the feat/agent-storybook-gallery branch from 3a8fbcc to 305742dCompareAugust 8, 2026 18:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kathiekiwi