Skip to content

Introduce a result interface to allow extraction of diagnostics - #19

Open
ruediste wants to merge 1 commit into
masterfrom
unknown repository
Open

Introduce a result interface to allow extraction of diagnostics#19
ruediste wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@ruediste

Copy link
Copy Markdown

I need access to the individual diagnostics messages. Unfortunately, the only implemented behaviour was to throw an exception when on compile errors/warnings. What do you think?

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #19 into master will decrease coverage by 0.04%.
The diff coverage is 93.93%.

Impacted file tree graph

@@ Coverage Diff @@## master #19 +/- ##
=======================================
- Coverage 86.04% 86% -0.05% 
=======================================
Files 6 6 Lines 86 100 +14 Branches 8 10 +2 =======================================
+ Hits 74 86 +12 - Misses 10 12 +2 
Partials 2 2
Impacted FilesCoverage Δ
...n/java/org/mdkt/compiler/InMemoryJavaCompiler.java85.71% <93.93%> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d84c404...789f9c8. Read the comment docs.

xzxiaoshan added a commit to xzxiaoshan/InMemoryJavaCompiler that referenced this pull request Jun 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ruediste@codecov-io