add attachment conversion support - #7
Conversation
Habbie
commented
May 6, 2013
Replying to #5 I realise this pull request depends on SQLite. Remove rowid, from the query, and from one of the prints, and it is portable to MySQL. |
trustmaster
commented
May 6, 2013
Does it have to have both |
ctrueden
commented
Jan 8, 2014
@trustmaster: I am no expert, but at least with my SQLite3 Trac environments, here's what I see: I am guessing So for consistency (assuming @Habbie ever comes back to this), I would suggest the patch just use |
Habbie
commented
Jan 13, 2014
id vs. rowid actually makes a big difference in the attachment table: However, the only reason rowid is in the select is so we can print it. Drop it from the select, drop the print, everything should work with both SQLite and MySQL again. |
Hello,
this patch adds support for converting attachments. It posts them as gists (one gist per attachment) and then posts comments to the ticket.
Limitations:
When I used this, I hardcoded the URL. For this pull request, I moved the URL to a variable. I did not test this.
I extracted this patch from a bigger bunch of changes; I did not test the code after extraction. If anything is broken, my apologies.