Skip to content

Fix four file/event consistency defects - #152

Open
Prabin-Wagle wants to merge 1 commit into
tscircuit:mainfrom
Prabin-Wagle:fix/file-event-consistency-149
Open

Fix four file/event consistency defects#152
Prabin-Wagle wants to merge 1 commit into
tscircuit:mainfrom
Prabin-Wagle:fix/file-event-consistency-149

Conversation

@Prabin-Wagle

Copy link
Copy Markdown

Fixes #149 (independently investigated, not copied from proposed diff).

  • delete with both file_id+file_path now 400 instead of deleting two files with one event
  • upsert/rename to empty/root now 400 using normalizePath, before mutation
  • events/list since now compares Date instants, fixing timezone-offset cases
  • renameFile builds new events array instead of push-mutating snapshot

Tests: 4 new regression tests (0/4 before, 4/4 after). Full: 33 pass.
tsc --noEmit and git diff --check pass. Biome/build Windows-only failures are pre-existing and reproduce on clean main.

…tering, rename immutability

Reject dual-selector deletes (400), reject empty/root paths on
upsert/rename, compare event timestamps as instants, return fresh
events array on rename. Add four regression tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Four reproduced file/event consistency defects with tested fixes

1 participant