Skip to content

Update charged-ieee for Typst 0.12.0 - #52

Merged
laurmaedje merged 6 commits into
mainfrom
charged-ieee-012
Oct 29, 2024
Merged

laurmaedje merged 6 commits into
mainfrom
charged-ieee-012

Conversation

@PgBiel

@PgBiel PgBiel commented Oct 4, 2024

Copy link
Copy Markdown
Contributor
  • Use #set page(columns: 2) instead of #show: columns.with(2) (but keep #set columns(gutter: ...) before the #set page configuration)
  • Use multi-column floats for the document title and authors
  • Use contextual functions (counter(heading).get()) in show rules instead of locate()
  • Use #set par(spacing: ...)

Thumbnail

The thumbnail will need to be updated due to small 0.12.0 reflows. Let me know the best way to update that.

Version

I bumped charged-ieee to version 0.1.3, not sure if 0.2.0 would have been more appropriate, though the only "breaking change" here is basically to require Typst 0.12.0+. Undone.

@laurmaedje

laurmaedje commented Oct 5, 2024

Copy link
Copy Markdown
Member

We should probably review/merge #50 first. (Should've mentioned that!)

Re thumbnail and version: Best leave that out of this PR. We can update both in a separate version bump commit.

@MDLC01

MDLC01 commented Oct 19, 2024

Copy link
Copy Markdown
Contributor

I believe the block.sticky should be used in the heading show rule. Currently, both level 1 and level 2 headings can be widow, as illustrated by the image below.

image

@PgBiel

PgBiel commented Oct 19, 2024

Copy link
Copy Markdown
Contributor Author

Good call, thank you.

@PgBiel

PgBiel commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

Something is off with this figure in 0.12 (with or without this PR). The spacing around it is smaller (I think that's just because it's inheriting par spacing now), but also the circle is no longer perfectly centered it seems. Kinda weird.

Typst 0.11.1 Typst 0.12.0
circle is centered and there's spacing around figure circle appears to not be centered, less spacing around figure

also fixes first line indent not resetting after heading
@laurmaedje

Copy link
Copy Markdown
Member

Damn, it looks like circles and squares are just totally broken in 0.12. Something about the logic that enforces them to have fixed aspect ratio makes the visual circle/square shrink but it's bounding box is still large. The fact that nobody noticed this goes to show how many people use circle/square in the first place.

@laurmaedje

Copy link
Copy Markdown
Member

I opened typst/typst#5287. We could have another figure or switch the circle to a fixed radius for now.

@PgBiel

PgBiel commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

That's interesting haha. I'll just switch to a fixed radius then

@PgBiel
PgBiel marked this pull request as ready for review October 26, 2024 00:47
@laurmaedje
laurmaedje merged commit bdde0ab into main Oct 29, 2024
@laurmaedje
laurmaedje deleted the charged-ieee-012 branch October 29, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants