Update charged-ieee for Typst 0.12.0 - #52
Merged
Merged
Conversation
Member
|
We should probably review/merge #50 first. (Should've mentioned that!) Re thumbnail and version: Best leave that out of this PR. We can update both in a separate version bump commit. |
Contributor
Contributor
Author
|
Good call, thank you. |
PgBiel
force-pushed
the
charged-ieee-012
branch
from
October 23, 2024 23:11
a097cf3 to
3262092
Compare
Contributor
Author
also fixes first line indent not resetting after heading
Member
|
Damn, it looks like circles and squares are just totally broken in 0.12. Something about the logic that enforces them to have fixed aspect ratio makes the visual circle/square shrink but it's bounding box is still large. The fact that nobody noticed this goes to show how many people use circle/square in the first place. |
Member
|
I opened typst/typst#5287. We could have another figure or switch the circle to a fixed |
Contributor
Author
|
That's interesting haha. I'll just switch to a fixed radius then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



#set page(columns: 2)instead of#show: columns.with(2)(but keep#set columns(gutter: ...)before the#set pageconfiguration)counter(heading).get()) in show rules instead oflocate()#set par(spacing: ...)Thumbnail
The thumbnail will need to be updated due to small 0.12.0 reflows. Let me know the best way to update that.
Version
I bumped charged-ieee to version 0.1.3, not sure if 0.2.0 would have been more appropriate, though the only "breaking change" here is basically to require Typst 0.12.0+.Undone.