simplify d1 instructions - #137
Merged
Merged
Conversation
kdchin
reviewed
Sep 11, 2026
| There is no review step at this stage: nobody is waiting to approve anything, so merge it | ||
| yourself as soon as you're ready. | ||
| Only what's on `main` before the deadline is graded, even if it is on a different branch before the deadline! | ||
| **2. How did you represent "no campus"?** When a building has no campus set, does your response omit |
Contributor
There was a problem hiding this comment.
maybe we can be a bit more specific here: one of the more interesting implications of this is on providing null or not providing a campus on PUT: does it clear out the campus, or noop?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.