Fix forked Workflow invoking didComplete multiple times - #214
Merged
Conversation
Because didComplete is added at the end of the Workflow Rx side-effect, if a Workflow is forked, multiple Rx chains with the side-effect are created and subscribed to. This means the didComplete is invoked duplicately. Fixes #211
sbarow
approved these changes
Feb 12, 2018
Contributor
|
Can we merge this in and create a new release. |
CosmicYogi
pushed a commit
to CosmicYogi/RIBs
that referenced
this pull request
Jan 8, 2020
Fix forked Workflow invoking didComplete multiple times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because didComplete is added at the end of the Workflow Rx side-effect, if a Workflow is forked, multiple Rx chains with the side-effect are created and subscribed to. This means the didComplete is invoked duplicately.
Fixes #211
Description:
Related issue(s):