Skip to content

Unmount React Components when removing elements from Dom#322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamzapasnik wants to merge 1 commit into
base:master
Choose a base branch
from
Open

Unmount React Components when removing elements from Dom #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions __tests__/utilities/graph-util.test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
// @flow
import * as React from 'react';
import ReactDOM from 'react-dom';
import { shallow } from 'enzyme';
import GraphView from '../../src/components/graph-view';

Expand DownExpand Up@@ -128,6 +129,7 @@ describe('GraphUtils class', () => {

describe('removeElementFromDom method', () => {
it('removes an element using an id', () => {
ReactDOM.unmountComponentAtNode = jest.fn();
const fakeElement = {
parentNode: {
removeChild: jest.fn(),
Expand All@@ -137,6 +139,7 @@ describe('GraphUtils class', () => {
jest.spyOn(document, 'querySelector').mockReturnValue(fakeElement);
const result = GraphUtils.removeElementFromDom('fake');

expect(ReactDOM.unmountComponentAtNode).toHaveBeenCalledWith(fakeElement);
expect(fakeElement.parentNode.removeChild).toHaveBeenCalledWith(
fakeElement
);
Expand Down
2 changes: 2 additions & 0 deletions src/utilities/graph-util.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import { type IEdge } from '../components/edge';
import { type INode } from '../components/node';
import { type IPoint } from '../components/graph-view-props';
import fastDeepEqual from 'fast-deep-equal';
import ReactDOM from 'react-dom';

export type INodeMapNode = {
node: INode,
Expand DownExpand Up@@ -106,6 +107,7 @@ class GraphUtils {
const container = searchElement.querySelector(`[id='${id}']`);

if (container && container.parentNode) {
ReactDOM.unmountComponentAtNode(container);
container.parentNode.removeChild(container);

return true;
Expand Down