Skip to content

Added Contributing file with information - #226

Merged
una merged 3 commits into
una:masterfrom
Bobeta:master
Nov 2, 2016
Merged

Added Contributing file with information#226
una merged 3 commits into
una:masterfrom
Bobeta:master

Conversation

@Bobeta

Copy link
Copy Markdown
Contributor

I happened to miss the contribution section in the Readme while looking through the project. As many others do, I was looking for the CONTRIBUTING.md file in the repository, but couldn't find it. I suggest we add it with this pull request 👍

Comment threadCONTRIBUTING.md Outdated

## Procedure 1

1. Create an [issue](https://github.com/una/CSSgram/issues)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say look for an issue first becuase a lot of them are already made

Comment threadCONTRIBUTING.md Outdated
2. Clone the fork onto your system
3. `npm install` dependencies (must have Node installed)
4. Run `gulp` to compile CSS and the test site
5. Make changes and check the test site with your changes (see file structure outline below)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing file structure outline here (also mention to edit the .scss file related to the filter)

@una

una commented Oct 20, 2016

Copy link
Copy Markdown
Owner

Hey -- have you taken a look at any of these comments yet?

@Bobeta

Copy link
Copy Markdown
ContributorAuthor

I made the requested changes 👍

@una

una commented Oct 27, 2016

Copy link
Copy Markdown
Owner

There's also slightly different information here: #242 with this being merged, please include that as well

@Bobeta

Copy link
Copy Markdown
ContributorAuthor

There you go 👍 an idea would be to just merge it and update it on the fly as new things come along, instead of me maintaining the docs haha 😆

@una
una merged commit e5a2ad8 into una:masterNov 2, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Bobeta@una