Skip to content

Deadline Buffer - #217

Closed
isaiah-andrade wants to merge 2 commits into
underground-software:masterfrom
isaiah-andrade:deadline_fix
Closed

Deadline Buffer#217
isaiah-andrade wants to merge 2 commits into
underground-software:masterfrom
isaiah-andrade:deadline_fix

Conversation

@isaiah-andrade

Copy link
Copy Markdown

This commit adds a 7 minute buffer so the deadline for the initial, final, and peer review submissions will trigger at each due date + 7 minutes. Attempts to address issue #204

@theyoyojotheyoyojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

Comment threadmailman/submit.py Outdated
This commit adds a buffer as an environment variable to the deadline for
the initial, final, and peer review submissions so the deadline will
trigger at each due date + "deadline_buffer" minutes. This is set to 7
minutes by default.
Signed-off-by: Isaiah Andrade <isaiah_andrade@fall2024-uml.kdlp.underground.software>

@theyoyojotheyoyojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment threadmailman/submit.py Outdated
Comment threadmailman/submit.py Outdated
@isaiah-andrade
isaiah-andradeforce-pushed the deadline_fix branch 2 times, most recently from 1102c37 to a62f9e1CompareFebruary 1, 2025 17:04
@theyoyojo

Copy link
Copy Markdown
Contributor

Ok nice looks reasonable.

How did you test this?

Post your steps so I can reproduce the testing on my end

@theyoyojo

Copy link
Copy Markdown
Contributor

Closed due to inactivity

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaiah-andrade@theyoyojo