Skip to content

Submission tests to greatly pinp our CI - #297

Merged
charliemirabile merged 4 commits into
masterfrom
submission_test_good_fixed_correct_branch_pls_merge
Oct 5, 2025
Merged

Submission tests to greatly pinp our CI#297
charliemirabile merged 4 commits into
masterfrom
submission_test_good_fixed_correct_branch_pls_merge

Conversation

@theyoyojo

@theyoyojotheyoyojo commented Sep 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Add a bunch of new tests to exercise submission codepaths and workflow

Fixes#281

Also doubles as documentation

@theyoyojo
theyoyojoforce-pushed the submission_test_good_fixed_correct_branch_pls_merge branch 5 times, most recently from 3c16928 to c8462baCompareSeptember 25, 2025 00:23
charliemirabile
charliemirabile reviewed Sep 25, 2025
View reviewed changes
Comment threadContainerfile Outdated
charliemirabile
charliemirabile reviewed Sep 25, 2025
View reviewed changes
Comment threadscript-lint.sh
charliemirabile
charliemirabile requested changes Sep 25, 2025
View reviewed changes

@charliemirabilecharliemirabile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if it even makes sense to have 4 different scripts, any reason not to just fold all of the new stuff into the existing test.sh? like I think maybe the main reason you wrote it that way is because we don't use podman-compose up or podman-compose down in the test.sh and you wanted to just write these tests from a blank slate, but could we modify the tests now that they are more crystalized to just work with the existing testing code?

Comment threadtest-sub-check.sh Outdated
Comment threadtest-sub-check.sh Outdated
Comment threadtest-sub-check.sh Outdated
Comment threadtest-sub-check.sh Outdated
Comment threadtest-sub-check.sh Outdated
Comment threadtest-sub2.sh Outdated
Comment threadtest-sub2.sh Outdated
Comment threadtest-sub3.sh Outdated
Comment threadtest-sub3.sh Outdated
Comment threadtest-sub3.sh Outdated
@theyoyojo
theyoyojoforce-pushed the submission_test_good_fixed_correct_branch_pls_merge branch 7 times, most recently from 5da69eb to 181252bCompareOctober 2, 2025 18:48
@theyoyojo
theyoyojoforce-pushed the submission_test_good_fixed_correct_branch_pls_merge branch 2 times, most recently from 370c1d8 to fa1d5bcCompareOctober 3, 2025 19:45
@theyoyojotheyoyojo changed the title Add a bunch of new tests to exercise submission codepaths and workflowSubmission tests to greatly pinp our CIOct 3, 2025
@theyoyojo
denis: move and rephrase deadline handler messages
0874153
denis prints a message when the submissions are released for an
assignment, i.e. when the deadline handler is triggered. This represents
the system making the assignment emails available for viewing by
qualified students. After this action is taken, denis updates the git
tags in the grading repo and runs automated checks on the gradable
submissions.
Move the message to the end of the handler and rephrase it
appropriately.
Signed-off-by: Joel Savitz <joel@underground.software>
@theyoyojo
mailman: suppress output from underlying git commands
24e439e
This isn't comprehensive but it's certainly an improvement.
Signed-off-by: Joel Savitz <joel@underground.software>
@theyoyojo
mailman: print original Message-ID header after processing
f048c9d
This value is the same Message-ID that the client sees when sending the
message with e.g. git-send-email. Our SMTP server saves this in a
different header, X-KDLP-Orig-Message-ID, so retrieve it from there.
Signed-off-by: Joel Savitz <joel@underground.software>
@theyoyojo
theyoyojoforce-pushed the submission_test_good_fixed_correct_branch_pls_merge branch from 2af0f84 to 9abf528CompareOctober 3, 2025 20:28
@theyoyojotheyoyojo mentioned this pull request Oct 3, 2025
Closed
@theyoyojo
Add a bunch of new tests to exercise submission codepaths and workflow
5b2c003
Release the Epstein files
Fixes#281
Signed-off-by: Joel Savitz <joel@underground.software>
@theyoyojo
theyoyojoforce-pushed the submission_test_good_fixed_correct_branch_pls_merge branch from 9abf528 to 5b2c003CompareOctober 4, 2025 21:42
charliemirabile
charliemirabile approved these changes Oct 5, 2025
View reviewed changes

@charliemirabilecharliemirabile left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start, important to merge even if not perfect.

@charliemirabile
charliemirabile merged commit 05126c3 into masterOct 5, 2025
1 check passed
@charliemirabile
charliemirabile deleted the submission_test_good_fixed_correct_branch_pls_merge branch October 5, 2025 03:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliemirabilecharliemirabilecharliemirabile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tests to CI to exercise submission codepaths and workflow

2 participants

@theyoyojo@charliemirabile