Uh oh!
There was an error while loading. Please reload this page.
Dockerfile --> Containerfile - #14
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull Request Overview
This PR migrates container configuration from Docker to Podman by replacing Dockerfile with Containerfile and updating the environment configuration. The changes align with using Podman as the preferred container runtime.
- Replaced Dockerfile with Containerfile following Podman conventions
- Updated environment configuration from specific Python version to flexible version constraint
- Added new container launch script for Podman workflow
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| environment.yaml | Updated environment name and Python version constraint, removed pygmsh dependency |
| docs/developer/docker/underworld3.dockerfile | Removed old Docker configuration file |
| docs/developer/container/launch-container.sh | Added new Podman launch script with volume mounts and port mapping |
| docs/developer/container/Containerfile | Added new Containerfile with updated build instructions and syntax |
| Dockerfile | Removed root-level Dockerfile in favor of new Containerfile location |
| - conda-forge | ||
| dependencies: | ||
| - python=3.11 | ||
| - python <= 3.11 |
There was a problem hiding this comment.
The Python version constraint <= 3.11 allows older Python versions which may not be compatible with the codebase. Consider using >=3.9,<=3.11 or a more specific constraint to ensure compatibility.
| - python <= 3.11 | |
| - python >=3.9,<=3.11 |
| -u root \ | ||
| -v $HOME:/uw_dir/host_ro:ro \ | ||
| -v uw_vol:/uw_dir/workspace:rw \ | ||
| docker.io:underworldcode/underworld3:development $@ |
There was a problem hiding this comment.
Invalid Docker registry URL format. Should be docker.io/underworldcode/underworld3:development (single colon after docker.io).
| docker.io:underworldcode/underworld3:development $@ | |
| docker.io/underworldcode/underworld3:development $@ |
| COPY --chown=$MAMBA_USER:$MAMBA_USER \ | ||
| --exclude=**/.git \ | ||
| . /home/$MAMBA_USER/underworld3 | ||
| # asdasd |
There was a problem hiding this comment.
Remove the nonsensical comment '# asdasd' - this appears to be leftover debugging text.
| # asdasd |
| podman run \ | ||
| --rm -it \ | ||
| -p 9999:8888 \ | ||
| -u root \ |
There was a problem hiding this comment.
Running the container as root user poses security risks. Consider using a non-privileged user or the default container user instead.
| -u root \ |
This assumes containers will be run with `podman` and only in 'rootless podman' mode. This more is much better than 'rootful podman' or docker.
… into containerfile
Some useful links and overall desciption of the container technology used.
Some useful links and overall desciption of the container technology used.
jcgraciosa
left a comment
There was a problem hiding this comment.
I've checked and tested this so I approve the pull request.
Uh oh!
There was an error while loading. Please reload this page.
Podman for the win!