Skip to content

Development - #15

Merged
lmoresi merged 11 commits into
mainfrom
development
Aug 12, 2025
Merged

Development#15
lmoresi merged 11 commits into
mainfrom
development

Conversation

@lmoresi

Copy link
Copy Markdown
Member

This is needed to get the binder running again.

Juan Carlos Graciosaand others added 10 commits July 29, 2025 21:16
The pykdtree routines are currently hanging (on query) when using binder. Backing off to previous implementation (more bugs await, no doubt)
Make the cKDTree class switchable (i.e. same name as the pykdtree interface)
Fixing the old (C++ / hpp) one to match the new one and to use Julian's einstein summation speedups.
A few more corrections based on testing.
CopilotAI review requested due to automatic review settings August 2, 2025 06:56
@lmoresi

Copy link
Copy Markdown
MemberAuthor

All the recent fixes from JC plus the LM fixes to binder (making the kdtree switchable).

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses compatibility issues and improves debugging capabilities to get binder running again. The changes primarily involve API parameter fixes, class renames, debugging enhancements, and fallback implementations.

  • Fixed API parameter names from deprecated to current versions
  • Added debugging output and better error handling for mesh operations
  • Switched to fallback KD-tree implementation due to pykdtree hanging issues on binder

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
FileDescription
src/underworld3/swarm.pyFixed deprecated sqr_dist parameter to sqr_dists in KDTree query calls
src/underworld3/function/_function.pyxAdded array handling for single point evaluations and consistent output behavior
src/underworld3/discretisation.pyEnhanced debugging output, fixed variable references, and improved mesh initialization
src/underworld3/ckdtree.pyxRenamed class, updated query interface, and added new RBF interpolation implementation
src/underworld3/init.pySwitched from pykdtree to ckdtree fallback implementation
docs/user/Notebooks/2-Variables.ipynbAdded test cells for mesh functionality validation

Comment threadsrc/underworld3/discretisation.py
Comment threadsrc/underworld3/discretisation.py Outdated
Comment threadsrc/underworld3/discretisation.py Outdated
Comment threadsrc/underworld3/discretisation.py Outdated
Comment threadsrc/underworld3/discretisation.py Outdated
Comment threadsrc/underworld3/ckdtree.pyx
Comment threadsrc/underworld3/ckdtree.pyx
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@lmoresi

Copy link
Copy Markdown
MemberAuthor

Apply recent fixes in dev to main branch (to ensure binder is running at the time we announce new release)

@lmoresi
lmoresi merged commit fbb20c8 into mainAug 12, 2025
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lmoresi