Uh oh!
There was an error while loading. Please reload this page.
Development - #15
Conversation
The pykdtree routines are currently hanging (on query) when using binder. Backing off to previous implementation (more bugs await, no doubt)
Make the cKDTree class switchable (i.e. same name as the pykdtree interface)
Fixing the old (C++ / hpp) one to match the new one and to use Julian's einstein summation speedups.
A few more corrections based on testing.
lmoresi
commented
Aug 2, 2025
All the recent fixes from JC plus the LM fixes to binder (making the kdtree switchable). |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses compatibility issues and improves debugging capabilities to get binder running again. The changes primarily involve API parameter fixes, class renames, debugging enhancements, and fallback implementations.
- Fixed API parameter names from deprecated to current versions
- Added debugging output and better error handling for mesh operations
- Switched to fallback KD-tree implementation due to pykdtree hanging issues on binder
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/underworld3/swarm.py | Fixed deprecated sqr_dist parameter to sqr_dists in KDTree query calls |
| src/underworld3/function/_function.pyx | Added array handling for single point evaluations and consistent output behavior |
| src/underworld3/discretisation.py | Enhanced debugging output, fixed variable references, and improved mesh initialization |
| src/underworld3/ckdtree.pyx | Renamed class, updated query interface, and added new RBF interpolation implementation |
| src/underworld3/init.py | Switched from pykdtree to ckdtree fallback implementation |
| docs/user/Notebooks/2-Variables.ipynb | Added test cells for mesh functionality validation |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lmoresi
commented
Aug 12, 2025
Apply recent fixes in dev to main branch (to ensure binder is running at the time we announce new release) |
Uh oh!
There was an error while loading. Please reload this page.
This is needed to get the binder running again.