Uh oh!
There was an error while loading. Please reload this page.
fix: web rn bundling by adding browser exports field - #624
Conversation
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe package export map adds browser-specific targets for the root package, the component entry point, and component wildcard exports. Each target points to the corresponding web module build. ChangesBrowser export mapping
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR adds explicit browser-condition targets to the root and component package exports.
Confidence Score: 5/5The PR appears safe to merge with no blocking failure remaining. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/uniwind/package.json | Adds browser resolution conditions for the root, components index, and wildcard component exports. |
Reviews (2): Last reviewed commit: "chore: reorder exports" | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/uniwind/package.json`:
- Around line 47-50: Reorder the export conditions in the package.json exports
maps so browser appears before react-native for the root, ./components, and
./components/* entries. Keep all existing targets unchanged and apply the same
ordering consistently across each affected export mapping.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🚀 This pull request is included in v1.11.0. See Release v1.11.0 for release notes. |
#622
Summary by CodeRabbit