Uh oh!
There was an error while loading. Please reload this page.
feat: support drop-shadow filter function - #645
Conversation
Add processDropShadow handler to compile Tailwind CSS v4 drop-shadow filter utilities (drop-shadow-sm, drop-shadow-md, etc.) into React Native compatible filter strings. Supports preset sizes, arbitrary values, color modifiers, and combined filters.
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe CSS processor now converts ChangesDrop-shadow processing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk:⚪ Minimal · up to This adds native support for drop-shadow filter utilities with coverage for preset, arbitrary, combined, and color-modified values; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds native compilation support for Tailwind CSS
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking issues identified. The new processor preserves the tested drop-shadow arguments, composes correctly with other filters, and has coverage for the principal preset, arbitrary-value, disabled, and color-modified paths.
|
| Filename | Overview |
|---|---|
| packages/uniwind/src/bundler/css-processor/functions.ts | Adds drop-shadow argument processing and generated filter-expression construction; no actionable defect was established. |
| packages/uniwind/tests/native/styles-parsing/filters.test.tsx | Adds broad native drop-shadow parsing assertions for supported utility forms. |
Reviews (1): Last reviewed commit: "feat: support drop-shadow filter functio..." | Re-trigger Greptile
Summary
Add support for
drop-shadowfilter utilities in React Native. Previously, thedrop-shadowfunction in the CSS processor returnedundefined, causing alldrop-shadow-*classes to be silently ignored on native.This PR adds a
processDropShadowhandler that compiles Tailwind CSS v4'sdrop-shadow()filter function into React Native compatible filter strings.Discussion: #644
Changes
packages/uniwind/src/bundler/css-processor/functions.tsdrop-shadowfunction calls to the newprocessDropShadowmethod instead of returningundefined.processDropShadowprivate method that:white-spacetokens from the LightningCSS AST to prevent double-spacing.processValueand wraps appropriately for JS template expression."drop-shadow(" + (0) + " " + (3) + " " + (3) + " " + "#0000001f" + ")".packages/uniwind/tests/native/styles-parsing/filters.test.tsxDrop shadowtest block with 9 assertions covering:drop-shadow-sm,drop-shadow-md,drop-shadow-lg,drop-shadow-xl,drop-shadow-2xl)drop-shadow-nonedrop-shadow-[0_10px_8px_rgba(0,0,0,0.5)])drop-shadow-md blur-md)drop-shadow-md drop-shadow-red-500)Supported Utilities
drop-shadow-smdrop-shadow(0 1 2 #00000026)drop-shadow-mddrop-shadow(0 3 3 #0000001f)drop-shadow-lgdrop-shadow(0 4 4 #00000026)drop-shadow-xldrop-shadow(0 9 7 #0000001a)drop-shadow-2xldrop-shadow(0 25 25 #00000026)drop-shadow-nonedrop-shadow-[0_10px_8px_rgba(0,0,0,0.5)]drop-shadow(0 10 8 #00000080)blur-md drop-shadow-mdblur(12px) drop-shadow(0 3 3 #0000001f)drop-shadow-md drop-shadow-red-500drop-shadow(0 3 3 #fb2c36ff)Verification
All CI-equivalent checks pass locally:
bun run buildbun run check:typescriptbun run check:typescript:testbun run lintbun run check:formatbun run circular:checkbun run test:native(147 tests passed)bun run test:web(26 tests passed)bun run test:typesbun run test:e2e(9 tests passed)Summary by CodeRabbit
Bug Fixes
Tests