Conversation
Closes unjs#77 Adds genExportDefault(expression) which generates an `export default <expression>;` statement. The expression is used as-is (raw), consistent with knitwork's existing raw-expression helpers such as genObjectFromRaw, leaving serialization of runtime values to the caller (e.g. genObjectFromValues or JSON.stringify). - src/esm.ts: implement and document genExportDefault - test/esm.test.ts: cover identifiers, objects, arrow fns, strings, numbers - README.md: regenerated via automd from JSDoc
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds ChangesExport default helper
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77
Problem
knitwork can generate
import,export, and dynamicimport()statements, but there is no helper for generatingexport default <expression>.Changes
Adds
genExportDefault(expression)which returns anexport default <expression>;statement.The expression is used as-is (raw, not escaped or quoted), consistent with knitwork's existing raw-expression helpers such as
genObjectFromRaw. Serialization of runtime values is left to the caller, e.g.genObjectFromValues(...)orJSON.stringify(...). This keeps the API unambiguous and composable rather than guessing whether a string is a value or an expression.src/esm.ts: implement and documentgenExportDefaulttest/esm.test.ts: add cases for identifiers, objects, arrow functions, strings, and numbersREADME.md: regenerated via automd from the new JSDocValidation
pnpm vitest run— 64 tests passing (5 new)pnpm lint— eslint + prettier cleanpnpm build— unbuild succeeds,genExportDefaultexported in both ESM and CJSSummary by CodeRabbit
New Features
export defaultstatements from a provided expression.Documentation
Tests