fix: properly override header values

[Eli Bosley (elibosley)]

Summary by CodeRabbit

• New Features
  • Header colors now support theme overrides with safe fallbacks (text primary/secondary and background).
• Style
  • Scoped base styles and Tailwind preflight to the .unapi namespace for better isolation and fewer global side effects.
  • Refined element resets (buttons, dialogs, typography) and focus-visible states within .unapi.
  • Utilities remain globally available; recommend using .unapi-prefixed HTML for consistent styling.
  • Improved consistency of UI components under the scoped styling approach.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

CSS updates replace hard-coded header colors with theme variables and restructure Tailwind usage: introducing layered imports, scoping preflight and base resets to the .unapi namespace, and refining component/resets within that scope. Global Tailwind utilities remain available. Other imports remain, with broadened class scanning paths.

Changes

Cohort / File(s)	Summary
Theme variables @tailwind-shared/unraid-theme.css	Converted header color constants to CSS custom property references with fallbacks: --color-header-text-primary, --color-header-text-secondary, --color-header-background.
Scoped Tailwind base and layers web/src/assets/main.css	Replaced root Tailwind import with layered approach: @layer theme, unapi-base, components, utilities. Scoped Tailwind preflight and base resets inside .unapi. Consolidated/rewrote element resets and component tweaks under .unapi. Kept global utilities and existing external imports, expanded class scanning.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

A rabbit twitches whiskers, neat and keen,
Threads of theme now weave a subtle sheen.
Preflight burrows under .unapi’s dome,
Utilities hop freely, room to roam.
Colors nibble vars with fallback grace—
Tailwind paths align, a tidier place. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 785f1f5 and cf5ca0b.

📒 Files selected for processing (2)

• @tailwind-shared/unraid-theme.css (1 hunks)
• web/src/assets/main.css (2 hunks)

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/color-overrides

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Claude finished Eli Bosley (@elibosley)'s task —— View job

---

PR Review: Color Override Fix

Analyzing the changes for critical issues in the diff...

Todo List:

• Read modified files to understand the specific changes
• Analyze only the changed lines for critical issues (bugs, security, breaking changes, data loss)
• Post review findings

Analysis of Changed Lines:

@tailwind-shared/unraid-theme.css (Lines 87-90):

• Changed hardcoded header color values to use CSS custom properties with fallbacks
• --color-header-text-primary: var(--header-text-primary, #1c1c1c)
• --color-header-text-secondary: var(--header-text-secondary, #999999)
• --color-header-background: var(--header-background-color, #f2f2f2)

web/src/assets/main.css (Lines 6-11, 21-29):

• Replaced @import "tailwindcss"; with layer-specific imports
• Changed from @layer base to @layer unapi-base
• Simplified Tailwind preflight scoping approach

✅ No critical issues found in changes

The modifications are focused on CSS variable improvements and Tailwind import optimization. All fallback values are preserved, ensuring backwards compatibility.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.53%. Comparing base (193be3d) to head (cf5ca0b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #1673 +/- ##
=======================================
Coverage 58.53% 58.53% =======================================
Files 624 624 Lines 30732 30732 Branches 3617 3617 =======================================
Hits 17989 17989 Misses 12706 12706 Partials 37 37 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1673/dynamix.unraid.net.plg