Feature/add url shortener api tests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
upendrakumbham merged 16 commits into from
Apr 26, 2026
Merged

Feature/add url shortener api tests #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8c06bcd
Added H2 data files
upendrakumbham Apr 22, 2026
80c7fb8
Added springboot starter test dependency
upendrakumbham Apr 22, 2026
ce085ed
Added service layer unit tests
upendrakumbham Apr 23, 2026
f24f104
Updated H2 Db as part of testing
upendrakumbham Apr 24, 2026
762d07f
Upgraded parent starter dependency to 4.0.1 from 3.2.0, 3.0.2 is in …
upendrakumbham Apr 24, 2026
ff2cd29
Upgraded parent starter dependency to 4.0.5 from 4.0.1 to remove vuln…
upendrakumbham Apr 24, 2026
0c396fd
Moved back to 3.5.0 to avoid modularised tech saperation package issues
upendrakumbham Apr 24, 2026
0a1f68d
Added web integration(E2E) tests
upendrakumbham Apr 24, 2026
d631bdf
Added controller unit tests
upendrakumbham Apr 24, 2026
795d1bb
Added controller integration Mockmvc tests to verify API flow, especi…
upendrakumbham Apr 24, 2026
b6b0f67
Removed unused variable
upendrakumbham Apr 24, 2026
3823260
Rename DB and added more capabilities
upendrakumbham Apr 24, 2026
dd903e8
We don't need @Transactional, data jpa handles that.
upendrakumbham Apr 26, 2026
518d3ca
Remove unused import
upendrakumbham Apr 26, 2026
9bbc0ee
Commit DB data
upendrakumbham Apr 26, 2026
f0b4bab
Added test properties file
upendrakumbham Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file addeddata/mydb.mv.db
View file
Open in desktop
Binary file not shown.
73 changes: 73 additions & 0 deletions data/mydb.trace.db
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
2026-04-21 19:51:51.423293+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 05:55:04.822844+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:09:33.475810+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:16:11.292904+01:00 jdbc[16]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:23.617910+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:30.987650+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:33.627303+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 16:38:46.730818Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:38:53.145271Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:39:21.684624Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-24 05:52:19.361391+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
10 changes: 9 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.2.0</version>
<version>3.5.0</version>
</parent>

<properties>
Expand DownExpand Up@@ -53,5 +53,13 @@
<artifactId>lombok</artifactId>
<optional>true</optional>
</dependency>

<!-- api testing-->
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
</dependency>

</dependencies>
</project>
2 changes: 1 addition & 1 deletion src/main/resources/application-dev.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
spring:
datasource:
url: jdbc:h2:file:./data/mydb
url: jdbc:h2:file:./data/url-shorten-db;AUTO_SERVER=TRUE;DB_CLOSE_ON_EXIT=FALSE
driver-class-name: org.h2.Driver
username: sa
password:
Expand Down
76 changes: 76 additions & 0 deletions src/test/java/com/tpximpact/urlshortener/controller/UrlControllerIntegrationTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@SpringBootTest
@AutoConfigureMockMvc
class UrlControllerIntegrationTest {

@Autowired
private MockMvc mockMvc;

@Autowired
private ObjectMapper objectMapper;

@Test
@DisplayName("Full integration flow: Create, Redirect, List, and Delete")
void testUrlLifecycle() throws Exception {
String longUrl = "https://www.tpximpact.com";
String alias = "tpx";
UrlRequest request = new UrlRequest(longUrl, alias);

// 1. POST /shorten - Create a new mapping
mockMvc.perform(post("/shorten")
.contentType(MediaType.APPLICATION_JSON)
.content(objectMapper.writeValueAsString(request)))
.andExpect(status().isCreated())
.andExpect(jsonPath("$.shortUrl").exists());

// 2. GET /{alias} - Test redirection logic
mockMvc.perform(get("/{alias}", alias))
.andExpect(status().isFound()) // 302
.andExpect(header().string("Location", longUrl))
.andExpect(content().string(""));

// 3. GET /urls - Verify the alias appears in the list
mockMvc.perform(get("/urls"))
.andExpect(status().isOk())
.andExpect(jsonPath("$").isArray())
.andExpect(jsonPath("$[?(@.alias == '" + alias + "')]").exists());

// 4. DELETE /{alias} - Remove the mapping
mockMvc.perform(delete("/{alias}", alias))
.andExpect(status().isNoContent());

// 5. GET /{alias} - Verify it no longer exists (assuming service throws 404)
mockMvc.perform(get("/{alias}", alias))
.andExpect(status().isNotFound());
}

@Test
@DisplayName("POST /shorten - Should return 400 when fullUrl is blank")
void shouldReturn400ForInvalidInput() throws Exception {
UrlRequest invalidRequest = new UrlRequest("", "short");

mockMvc.perform(post("/shorten")
.contentType(MediaType.APPLICATION_JSON)
.content(objectMapper.writeValueAsString(invalidRequest)))
.andExpect(status().isBadRequest());
}
}
125 changes: 125 additions & 0 deletions src/test/java/com/tpximpact/urlshortener/controller/UrlControllerTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlListResponse;
import com.tpximpact.urlshortener.dto.UrlRequest;
import com.tpximpact.urlshortener.dto.UrlResponse;
import com.tpximpact.urlshortener.exception.NotFoundException;
import com.tpximpact.urlshortener.service.UrlService;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.test.context.bean.override.mockito.MockitoBean; // SB 4.0 standard
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import java.util.List;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(UrlController.class)
class UrlControllerTest {

@Autowired
private MockMvc mockMvc;

@Autowired
private ObjectMapper objectMapper;

@MockitoBean
private UrlService urlService;

@Test
@DisplayName("POST /shorten - Success")
void shortenUrl_Returns201() throws Exception {
// Given
UrlRequest request = new UrlRequest("https://example.com", "my-alias");
UrlResponse response = new UrlResponse("http://localhost:8080/my-alias");

when(urlService.shorten(any(UrlRequest.class))).thenReturn(response);

// When & Then
mockMvc.perform(post("/shorten")
.contentType(MediaType.APPLICATION_JSON)
.content(objectMapper.writeValueAsString(request)))
.andExpect(status().isCreated())
.andExpect(jsonPath("$.shortUrl").value("http://localhost:8080/my-alias"));

verify(urlService, times(1)).shorten(any(UrlRequest.class));
}

@Test
@DisplayName("GET /{alias} - Redirects to full URL")
void redirect_Returns302() throws Exception {
// Given
String alias = "tpx";
String fullUrl = "https://tpximpact.com";
when(urlService.getFullUrl(alias)).thenReturn(fullUrl);

// When & Then
mockMvc.perform(get("/{alias}", alias))
.andExpect(status().isFound())
.andExpect(header().string("Location", fullUrl))
.andExpect(content().string("")); // Asserting empty body as requested

verify(urlService).getFullUrl(alias);
}

@Test
@DisplayName("GET /{alias} - Redirects returns 404 if alias not exist")
void redirect_Returns404_If_Alias_Not_Exist() throws Exception {
// Given
String aliasNotExist = "notExist";
when(urlService.getFullUrl(aliasNotExist)).thenThrow(NotFoundException.class);

// When & Then
mockMvc.perform(get("/{alias}", aliasNotExist))
.andExpect(status().isNotFound());

verify(urlService).getFullUrl(aliasNotExist);
}

@Test
@DisplayName("GET /urls - Returns list of mappings")
void getAll_Returns200() throws Exception {
// Given
List<UrlListResponse> mockList = List.of(
new UrlListResponse("alias1", "https://site1.com", "http://short/1"),
new UrlListResponse("alias2", "https://site2.com", "http://short/2")
);
when(urlService.getAll()).thenReturn(mockList);

// When & Then
mockMvc.perform(get("/urls"))
.andExpect(status().isOk())
.andExpect(jsonPath("$.length()").value(2))
.andExpect(jsonPath("$[0].alias").value("alias1"));
}

@Test
@DisplayName("DELETE /{alias} - Success")
void delete_Returns204() throws Exception {
// When & Then
mockMvc.perform(delete("/{alias}", "old-alias"))
.andExpect(status().isNoContent());

verify(urlService).delete("old-alias");
}

@Test
@DisplayName("POST /shorten - Fails on invalid input")
void shortenUrl_BlankUrl_Returns400() throws Exception {
UrlRequest invalidRequest = new UrlRequest("", "alias");

mockMvc.perform(post("/shorten")
.contentType(MediaType.APPLICATION_JSON)
.content(objectMapper.writeValueAsString(invalidRequest)))
.andExpect(status().isBadRequest());

verifyNoInteractions(urlService);
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Feature/add url shortener api tests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

upendrakumbham
merged 16 commits into

from

Apr 26, 2026
 Merged


Feature/add url shortener api tests
#3
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
8c06bcd

Added H2 data files


upendrakumbham Apr 22, 2026
80c7fb8

Added springboot starter test dependency


upendrakumbham Apr 22, 2026
ce085ed

Added service layer unit tests


upendrakumbham Apr 23, 2026
f24f104

Updated H2 Db as part of testing


upendrakumbham Apr 24, 2026
762d07f

Upgraded parent starter dependency to 4.0.1 from 3.2.0, 3.0.2 is in …


upendrakumbham Apr 24, 2026
ff2cd29

Upgraded parent starter dependency to 4.0.5 from 4.0.1 to remove vuln…


upendrakumbham Apr 24, 2026
0c396fd

Moved back to 3.5.0 to avoid modularised tech saperation package issues


upendrakumbham Apr 24, 2026
0a1f68d

Added web integration(E2E) tests


upendrakumbham Apr 24, 2026
d631bdf

Added controller unit tests


upendrakumbham Apr 24, 2026
795d1bb

Added controller integration Mockmvc tests to verify API flow, especi…


upendrakumbham Apr 24, 2026
b6b0f67

Removed unused variable


upendrakumbham Apr 24, 2026
3823260

Rename DB and added more capabilities


upendrakumbham Apr 24, 2026
dd903e8

We don't need @Transactional, data jpa handles that.


upendrakumbham Apr 26, 2026
518d3ca

Remove unused import


upendrakumbham Apr 26, 2026
9bbc0ee

Commit DB data


upendrakumbham Apr 26, 2026
f0b4bab

Added test properties file


upendrakumbham Apr 26, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view

Binary file addeddata/mydb.mv.db

View file


Open in desktop


Binary file not shown.


73 changes: 73 additions & 0 deletions
data/mydb.trace.db

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
2026-04-21 19:51:51.423293+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 05:55:04.822844+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:09:33.475810+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:16:11.292904+01:00 jdbc[16]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:23.617910+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:30.987650+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:33.627303+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 16:38:46.730818Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:38:53.145271Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:39:21.684624Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-24 05:52:19.361391+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]

10 changes: 9 additions & 1 deletion
pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 <parent>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-parent</artifactId>
 <version>3.2.0</version>
 <version>3.5.0</version>
 </parent>

 <properties>
Expand DownExpand Up@@ -53,5 +53,13 @@
 <artifactId>lombok</artifactId>
 <optional>true</optional>
 </dependency>

 <!-- api testing-->
 <dependency>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-test</artifactId>
 <scope>test</scope>
 </dependency>

 </dependencies>
</project>

2 changes: 1 addition & 1 deletion
src/main/resources/application-dev.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
spring:
 datasource:
 url: jdbc:h2:file:./data/mydb
 url: jdbc:h2:file:./data/url-shorten-db;AUTO_SERVER=TRUE;DB_CLOSE_ON_EXIT=FALSE
 driver-class-name: org.h2.Driver
 username: sa
 password:
Expand Down

76 changes: 76 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerIntegrationTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@SpringBootTest
@AutoConfigureMockMvc
class UrlControllerIntegrationTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @Test
 @DisplayName("Full integration flow: Create, Redirect, List, and Delete")
 void testUrlLifecycle() throws Exception {
 String longUrl = "https://www.tpximpact.com";
 String alias = "tpx";
 UrlRequest request = new UrlRequest(longUrl, alias);

 // 1. POST /shorten - Create a new mapping
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").exists());

 // 2. GET /{alias} - Test redirection logic
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound()) // 302
 .andExpect(header().string("Location", longUrl))
 .andExpect(content().string(""));

 // 3. GET /urls - Verify the alias appears in the list
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$").isArray())
 .andExpect(jsonPath("$[?(@.alias == '" + alias + "')]").exists());

 // 4. DELETE /{alias} - Remove the mapping
 mockMvc.perform(delete("/{alias}", alias))
 .andExpect(status().isNoContent());

 // 5. GET /{alias} - Verify it no longer exists (assuming service throws 404)
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isNotFound());
 }

 @Test
 @DisplayName("POST /shorten - Should return 400 when fullUrl is blank")
 void shouldReturn400ForInvalidInput() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "short");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());
 }
}

125 changes: 125 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlListResponse;
import com.tpximpact.urlshortener.dto.UrlRequest;
import com.tpximpact.urlshortener.dto.UrlResponse;
import com.tpximpact.urlshortener.exception.NotFoundException;
import com.tpximpact.urlshortener.service.UrlService;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.test.context.bean.override.mockito.MockitoBean; // SB 4.0 standard
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import java.util.List;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(UrlController.class)
class UrlControllerTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @MockitoBean
 private UrlService urlService;

 @Test
 @DisplayName("POST /shorten - Success")
 void shortenUrl_Returns201() throws Exception {
 // Given
 UrlRequest request = new UrlRequest("https://example.com", "my-alias");
 UrlResponse response = new UrlResponse("http://localhost:8080/my-alias");

 when(urlService.shorten(any(UrlRequest.class))).thenReturn(response);

 // When & Then
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").value("http://localhost:8080/my-alias"));

 verify(urlService, times(1)).shorten(any(UrlRequest.class));
 }

 @Test
 @DisplayName("GET /{alias} - Redirects to full URL")
 void redirect_Returns302() throws Exception {
 // Given
 String alias = "tpx";
 String fullUrl = "https://tpximpact.com";
 when(urlService.getFullUrl(alias)).thenReturn(fullUrl);

 // When & Then
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound())
 .andExpect(header().string("Location", fullUrl))
 .andExpect(content().string("")); // Asserting empty body as requested

 verify(urlService).getFullUrl(alias);
 }

 @Test
 @DisplayName("GET /{alias} - Redirects returns 404 if alias not exist")
 void redirect_Returns404_If_Alias_Not_Exist() throws Exception {
 // Given
 String aliasNotExist = "notExist";
 when(urlService.getFullUrl(aliasNotExist)).thenThrow(NotFoundException.class);

 // When & Then
 mockMvc.perform(get("/{alias}", aliasNotExist))
 .andExpect(status().isNotFound());

 verify(urlService).getFullUrl(aliasNotExist);
 }

 @Test
 @DisplayName("GET /urls - Returns list of mappings")
 void getAll_Returns200() throws Exception {
 // Given
 List<UrlListResponse> mockList = List.of(
 new UrlListResponse("alias1", "https://site1.com", "http://short/1"),
 new UrlListResponse("alias2", "https://site2.com", "http://short/2")
 );
 when(urlService.getAll()).thenReturn(mockList);

 // When & Then
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$.length()").value(2))
 .andExpect(jsonPath("$[0].alias").value("alias1"));
 }

 @Test
 @DisplayName("DELETE /{alias} - Success")
 void delete_Returns204() throws Exception {
 // When & Then
 mockMvc.perform(delete("/{alias}", "old-alias"))
 .andExpect(status().isNoContent());

 verify(urlService).delete("old-alias");
 }

 @Test
 @DisplayName("POST /shorten - Fails on invalid input")
 void shortenUrl_BlankUrl_Returns400() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "alias");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());

 verifyNoInteractions(urlService);
 }
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Feature/add url shortener api tests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

upendrakumbham
merged 16 commits into

from

Apr 26, 2026
 Merged


Feature/add url shortener api tests
#3
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
8c06bcd

Added H2 data files


upendrakumbham Apr 22, 2026
80c7fb8

Added springboot starter test dependency


upendrakumbham Apr 22, 2026
ce085ed

Added service layer unit tests


upendrakumbham Apr 23, 2026
f24f104

Updated H2 Db as part of testing


upendrakumbham Apr 24, 2026
762d07f

Upgraded parent starter dependency to 4.0.1 from 3.2.0, 3.0.2 is in …


upendrakumbham Apr 24, 2026
ff2cd29

Upgraded parent starter dependency to 4.0.5 from 4.0.1 to remove vuln…


upendrakumbham Apr 24, 2026
0c396fd

Moved back to 3.5.0 to avoid modularised tech saperation package issues


upendrakumbham Apr 24, 2026
0a1f68d

Added web integration(E2E) tests


upendrakumbham Apr 24, 2026
d631bdf

Added controller unit tests


upendrakumbham Apr 24, 2026
795d1bb

Added controller integration Mockmvc tests to verify API flow, especi…


upendrakumbham Apr 24, 2026
b6b0f67

Removed unused variable


upendrakumbham Apr 24, 2026
3823260

Rename DB and added more capabilities


upendrakumbham Apr 24, 2026
dd903e8

We don't need @Transactional, data jpa handles that.


upendrakumbham Apr 26, 2026
518d3ca

Remove unused import


upendrakumbham Apr 26, 2026
9bbc0ee

Commit DB data


upendrakumbham Apr 26, 2026
f0b4bab

Added test properties file


upendrakumbham Apr 26, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view

Binary file addeddata/mydb.mv.db

View file


Open in desktop


Binary file not shown.


73 changes: 73 additions & 0 deletions
data/mydb.trace.db

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
2026-04-21 19:51:51.423293+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 05:55:04.822844+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:09:33.475810+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:16:11.292904+01:00 jdbc[16]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:23.617910+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:30.987650+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:33.627303+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 16:38:46.730818Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:38:53.145271Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:39:21.684624Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-24 05:52:19.361391+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]

10 changes: 9 additions & 1 deletion
pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 <parent>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-parent</artifactId>
 <version>3.2.0</version>
 <version>3.5.0</version>
 </parent>

 <properties>
Expand DownExpand Up@@ -53,5 +53,13 @@
 <artifactId>lombok</artifactId>
 <optional>true</optional>
 </dependency>

 <!-- api testing-->
 <dependency>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-test</artifactId>
 <scope>test</scope>
 </dependency>

 </dependencies>
</project>

2 changes: 1 addition & 1 deletion
src/main/resources/application-dev.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
spring:
 datasource:
 url: jdbc:h2:file:./data/mydb
 url: jdbc:h2:file:./data/url-shorten-db;AUTO_SERVER=TRUE;DB_CLOSE_ON_EXIT=FALSE
 driver-class-name: org.h2.Driver
 username: sa
 password:
Expand Down

76 changes: 76 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerIntegrationTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@SpringBootTest
@AutoConfigureMockMvc
class UrlControllerIntegrationTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @Test
 @DisplayName("Full integration flow: Create, Redirect, List, and Delete")
 void testUrlLifecycle() throws Exception {
 String longUrl = "https://www.tpximpact.com";
 String alias = "tpx";
 UrlRequest request = new UrlRequest(longUrl, alias);

 // 1. POST /shorten - Create a new mapping
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").exists());

 // 2. GET /{alias} - Test redirection logic
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound()) // 302
 .andExpect(header().string("Location", longUrl))
 .andExpect(content().string(""));

 // 3. GET /urls - Verify the alias appears in the list
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$").isArray())
 .andExpect(jsonPath("$[?(@.alias == '" + alias + "')]").exists());

 // 4. DELETE /{alias} - Remove the mapping
 mockMvc.perform(delete("/{alias}", alias))
 .andExpect(status().isNoContent());

 // 5. GET /{alias} - Verify it no longer exists (assuming service throws 404)
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isNotFound());
 }

 @Test
 @DisplayName("POST /shorten - Should return 400 when fullUrl is blank")
 void shouldReturn400ForInvalidInput() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "short");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());
 }
}

125 changes: 125 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlListResponse;
import com.tpximpact.urlshortener.dto.UrlRequest;
import com.tpximpact.urlshortener.dto.UrlResponse;
import com.tpximpact.urlshortener.exception.NotFoundException;
import com.tpximpact.urlshortener.service.UrlService;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.test.context.bean.override.mockito.MockitoBean; // SB 4.0 standard
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import java.util.List;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(UrlController.class)
class UrlControllerTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @MockitoBean
 private UrlService urlService;

 @Test
 @DisplayName("POST /shorten - Success")
 void shortenUrl_Returns201() throws Exception {
 // Given
 UrlRequest request = new UrlRequest("https://example.com", "my-alias");
 UrlResponse response = new UrlResponse("http://localhost:8080/my-alias");

 when(urlService.shorten(any(UrlRequest.class))).thenReturn(response);

 // When & Then
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").value("http://localhost:8080/my-alias"));

 verify(urlService, times(1)).shorten(any(UrlRequest.class));
 }

 @Test
 @DisplayName("GET /{alias} - Redirects to full URL")
 void redirect_Returns302() throws Exception {
 // Given
 String alias = "tpx";
 String fullUrl = "https://tpximpact.com";
 when(urlService.getFullUrl(alias)).thenReturn(fullUrl);

 // When & Then
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound())
 .andExpect(header().string("Location", fullUrl))
 .andExpect(content().string("")); // Asserting empty body as requested

 verify(urlService).getFullUrl(alias);
 }

 @Test
 @DisplayName("GET /{alias} - Redirects returns 404 if alias not exist")
 void redirect_Returns404_If_Alias_Not_Exist() throws Exception {
 // Given
 String aliasNotExist = "notExist";
 when(urlService.getFullUrl(aliasNotExist)).thenThrow(NotFoundException.class);

 // When & Then
 mockMvc.perform(get("/{alias}", aliasNotExist))
 .andExpect(status().isNotFound());

 verify(urlService).getFullUrl(aliasNotExist);
 }

 @Test
 @DisplayName("GET /urls - Returns list of mappings")
 void getAll_Returns200() throws Exception {
 // Given
 List<UrlListResponse> mockList = List.of(
 new UrlListResponse("alias1", "https://site1.com", "http://short/1"),
 new UrlListResponse("alias2", "https://site2.com", "http://short/2")
 );
 when(urlService.getAll()).thenReturn(mockList);

 // When & Then
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$.length()").value(2))
 .andExpect(jsonPath("$[0].alias").value("alias1"));
 }

 @Test
 @DisplayName("DELETE /{alias} - Success")
 void delete_Returns204() throws Exception {
 // When & Then
 mockMvc.perform(delete("/{alias}", "old-alias"))
 .andExpect(status().isNoContent());

 verify(urlService).delete("old-alias");
 }

 @Test
 @DisplayName("POST /shorten - Fails on invalid input")
 void shortenUrl_BlankUrl_Returns400() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "alias");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());

 verifyNoInteractions(urlService);
 }
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Feature/add url shortener api tests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

upendrakumbham
merged 16 commits into

from

Apr 26, 2026
 Merged


Feature/add url shortener api tests
#3
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
8c06bcd

Added H2 data files


upendrakumbham Apr 22, 2026
80c7fb8

Added springboot starter test dependency


upendrakumbham Apr 22, 2026
ce085ed

Added service layer unit tests


upendrakumbham Apr 23, 2026
f24f104

Updated H2 Db as part of testing


upendrakumbham Apr 24, 2026
762d07f

Upgraded parent starter dependency to 4.0.1 from 3.2.0, 3.0.2 is in …


upendrakumbham Apr 24, 2026
ff2cd29

Upgraded parent starter dependency to 4.0.5 from 4.0.1 to remove vuln…


upendrakumbham Apr 24, 2026
0c396fd

Moved back to 3.5.0 to avoid modularised tech saperation package issues


upendrakumbham Apr 24, 2026
0a1f68d

Added web integration(E2E) tests


upendrakumbham Apr 24, 2026
d631bdf

Added controller unit tests


upendrakumbham Apr 24, 2026
795d1bb

Added controller integration Mockmvc tests to verify API flow, especi…


upendrakumbham Apr 24, 2026
b6b0f67

Removed unused variable


upendrakumbham Apr 24, 2026
3823260

Rename DB and added more capabilities


upendrakumbham Apr 24, 2026
dd903e8

We don't need @Transactional, data jpa handles that.


upendrakumbham Apr 26, 2026
518d3ca

Remove unused import


upendrakumbham Apr 26, 2026
9bbc0ee

Commit DB data


upendrakumbham Apr 26, 2026
f0b4bab

Added test properties file


upendrakumbham Apr 26, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view

Binary file addeddata/mydb.mv.db

View file


Open in desktop


Binary file not shown.


73 changes: 73 additions & 0 deletions
data/mydb.trace.db

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
2026-04-21 19:51:51.423293+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 05:55:04.822844+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:09:33.475810+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:16:11.292904+01:00 jdbc[16]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:23.617910+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:30.987650+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:33.627303+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 16:38:46.730818Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:38:53.145271Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:39:21.684624Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-24 05:52:19.361391+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]

10 changes: 9 additions & 1 deletion
pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 <parent>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-parent</artifactId>
 <version>3.2.0</version>
 <version>3.5.0</version>
 </parent>

 <properties>
Expand DownExpand Up@@ -53,5 +53,13 @@
 <artifactId>lombok</artifactId>
 <optional>true</optional>
 </dependency>

 <!-- api testing-->
 <dependency>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-test</artifactId>
 <scope>test</scope>
 </dependency>

 </dependencies>
</project>

2 changes: 1 addition & 1 deletion
src/main/resources/application-dev.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
spring:
 datasource:
 url: jdbc:h2:file:./data/mydb
 url: jdbc:h2:file:./data/url-shorten-db;AUTO_SERVER=TRUE;DB_CLOSE_ON_EXIT=FALSE
 driver-class-name: org.h2.Driver
 username: sa
 password:
Expand Down

76 changes: 76 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerIntegrationTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@SpringBootTest
@AutoConfigureMockMvc
class UrlControllerIntegrationTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @Test
 @DisplayName("Full integration flow: Create, Redirect, List, and Delete")
 void testUrlLifecycle() throws Exception {
 String longUrl = "https://www.tpximpact.com";
 String alias = "tpx";
 UrlRequest request = new UrlRequest(longUrl, alias);

 // 1. POST /shorten - Create a new mapping
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").exists());

 // 2. GET /{alias} - Test redirection logic
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound()) // 302
 .andExpect(header().string("Location", longUrl))
 .andExpect(content().string(""));

 // 3. GET /urls - Verify the alias appears in the list
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$").isArray())
 .andExpect(jsonPath("$[?(@.alias == '" + alias + "')]").exists());

 // 4. DELETE /{alias} - Remove the mapping
 mockMvc.perform(delete("/{alias}", alias))
 .andExpect(status().isNoContent());

 // 5. GET /{alias} - Verify it no longer exists (assuming service throws 404)
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isNotFound());
 }

 @Test
 @DisplayName("POST /shorten - Should return 400 when fullUrl is blank")
 void shouldReturn400ForInvalidInput() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "short");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());
 }
}

125 changes: 125 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlListResponse;
import com.tpximpact.urlshortener.dto.UrlRequest;
import com.tpximpact.urlshortener.dto.UrlResponse;
import com.tpximpact.urlshortener.exception.NotFoundException;
import com.tpximpact.urlshortener.service.UrlService;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.test.context.bean.override.mockito.MockitoBean; // SB 4.0 standard
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import java.util.List;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(UrlController.class)
class UrlControllerTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @MockitoBean
 private UrlService urlService;

 @Test
 @DisplayName("POST /shorten - Success")
 void shortenUrl_Returns201() throws Exception {
 // Given
 UrlRequest request = new UrlRequest("https://example.com", "my-alias");
 UrlResponse response = new UrlResponse("http://localhost:8080/my-alias");

 when(urlService.shorten(any(UrlRequest.class))).thenReturn(response);

 // When & Then
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").value("http://localhost:8080/my-alias"));

 verify(urlService, times(1)).shorten(any(UrlRequest.class));
 }

 @Test
 @DisplayName("GET /{alias} - Redirects to full URL")
 void redirect_Returns302() throws Exception {
 // Given
 String alias = "tpx";
 String fullUrl = "https://tpximpact.com";
 when(urlService.getFullUrl(alias)).thenReturn(fullUrl);

 // When & Then
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound())
 .andExpect(header().string("Location", fullUrl))
 .andExpect(content().string("")); // Asserting empty body as requested

 verify(urlService).getFullUrl(alias);
 }

 @Test
 @DisplayName("GET /{alias} - Redirects returns 404 if alias not exist")
 void redirect_Returns404_If_Alias_Not_Exist() throws Exception {
 // Given
 String aliasNotExist = "notExist";
 when(urlService.getFullUrl(aliasNotExist)).thenThrow(NotFoundException.class);

 // When & Then
 mockMvc.perform(get("/{alias}", aliasNotExist))
 .andExpect(status().isNotFound());

 verify(urlService).getFullUrl(aliasNotExist);
 }

 @Test
 @DisplayName("GET /urls - Returns list of mappings")
 void getAll_Returns200() throws Exception {
 // Given
 List<UrlListResponse> mockList = List.of(
 new UrlListResponse("alias1", "https://site1.com", "http://short/1"),
 new UrlListResponse("alias2", "https://site2.com", "http://short/2")
 );
 when(urlService.getAll()).thenReturn(mockList);

 // When & Then
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$.length()").value(2))
 .andExpect(jsonPath("$[0].alias").value("alias1"));
 }

 @Test
 @DisplayName("DELETE /{alias} - Success")
 void delete_Returns204() throws Exception {
 // When & Then
 mockMvc.perform(delete("/{alias}", "old-alias"))
 .andExpect(status().isNoContent());

 verify(urlService).delete("old-alias");
 }

 @Test
 @DisplayName("POST /shorten - Fails on invalid input")
 void shortenUrl_BlankUrl_Returns400() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "alias");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());

 verifyNoInteractions(urlService);
 }
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Feature/add url shortener api tests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

upendrakumbham
merged 16 commits into

from

Apr 26, 2026
 Merged


Feature/add url shortener api tests
#3
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
8c06bcd

Added H2 data files


upendrakumbham Apr 22, 2026
80c7fb8

Added springboot starter test dependency


upendrakumbham Apr 22, 2026
ce085ed

Added service layer unit tests


upendrakumbham Apr 23, 2026
f24f104

Updated H2 Db as part of testing


upendrakumbham Apr 24, 2026
762d07f

Upgraded parent starter dependency to 4.0.1 from 3.2.0, 3.0.2 is in …


upendrakumbham Apr 24, 2026
ff2cd29

Upgraded parent starter dependency to 4.0.5 from 4.0.1 to remove vuln…


upendrakumbham Apr 24, 2026
0c396fd

Moved back to 3.5.0 to avoid modularised tech saperation package issues


upendrakumbham Apr 24, 2026
0a1f68d

Added web integration(E2E) tests


upendrakumbham Apr 24, 2026
d631bdf

Added controller unit tests


upendrakumbham Apr 24, 2026
795d1bb

Added controller integration Mockmvc tests to verify API flow, especi…


upendrakumbham Apr 24, 2026
b6b0f67

Removed unused variable


upendrakumbham Apr 24, 2026
3823260

Rename DB and added more capabilities


upendrakumbham Apr 24, 2026
dd903e8

We don't need @Transactional, data jpa handles that.


upendrakumbham Apr 26, 2026
518d3ca

Remove unused import


upendrakumbham Apr 26, 2026
9bbc0ee

Commit DB data


upendrakumbham Apr 26, 2026
f0b4bab

Added test properties file


upendrakumbham Apr 26, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view

Binary file addeddata/mydb.mv.db

View file


Open in desktop


Binary file not shown.


73 changes: 73 additions & 0 deletions
data/mydb.trace.db

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
2026-04-21 19:51:51.423293+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 05:55:04.822844+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:09:33.475810+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:16:11.292904+01:00 jdbc[16]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:23.617910+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:30.987650+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:33.627303+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 16:38:46.730818Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:38:53.145271Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:39:21.684624Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-24 05:52:19.361391+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]

10 changes: 9 additions & 1 deletion
pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 <parent>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-parent</artifactId>
 <version>3.2.0</version>
 <version>3.5.0</version>
 </parent>

 <properties>
Expand DownExpand Up@@ -53,5 +53,13 @@
 <artifactId>lombok</artifactId>
 <optional>true</optional>
 </dependency>

 <!-- api testing-->
 <dependency>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-test</artifactId>
 <scope>test</scope>
 </dependency>

 </dependencies>
</project>

2 changes: 1 addition & 1 deletion
src/main/resources/application-dev.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
spring:
 datasource:
 url: jdbc:h2:file:./data/mydb
 url: jdbc:h2:file:./data/url-shorten-db;AUTO_SERVER=TRUE;DB_CLOSE_ON_EXIT=FALSE
 driver-class-name: org.h2.Driver
 username: sa
 password:
Expand Down

76 changes: 76 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerIntegrationTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@SpringBootTest
@AutoConfigureMockMvc
class UrlControllerIntegrationTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @Test
 @DisplayName("Full integration flow: Create, Redirect, List, and Delete")
 void testUrlLifecycle() throws Exception {
 String longUrl = "https://www.tpximpact.com";
 String alias = "tpx";
 UrlRequest request = new UrlRequest(longUrl, alias);

 // 1. POST /shorten - Create a new mapping
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").exists());

 // 2. GET /{alias} - Test redirection logic
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound()) // 302
 .andExpect(header().string("Location", longUrl))
 .andExpect(content().string(""));

 // 3. GET /urls - Verify the alias appears in the list
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$").isArray())
 .andExpect(jsonPath("$[?(@.alias == '" + alias + "')]").exists());

 // 4. DELETE /{alias} - Remove the mapping
 mockMvc.perform(delete("/{alias}", alias))
 .andExpect(status().isNoContent());

 // 5. GET /{alias} - Verify it no longer exists (assuming service throws 404)
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isNotFound());
 }

 @Test
 @DisplayName("POST /shorten - Should return 400 when fullUrl is blank")
 void shouldReturn400ForInvalidInput() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "short");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());
 }
}

125 changes: 125 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlListResponse;
import com.tpximpact.urlshortener.dto.UrlRequest;
import com.tpximpact.urlshortener.dto.UrlResponse;
import com.tpximpact.urlshortener.exception.NotFoundException;
import com.tpximpact.urlshortener.service.UrlService;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.test.context.bean.override.mockito.MockitoBean; // SB 4.0 standard
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import java.util.List;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(UrlController.class)
class UrlControllerTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @MockitoBean
 private UrlService urlService;

 @Test
 @DisplayName("POST /shorten - Success")
 void shortenUrl_Returns201() throws Exception {
 // Given
 UrlRequest request = new UrlRequest("https://example.com", "my-alias");
 UrlResponse response = new UrlResponse("http://localhost:8080/my-alias");

 when(urlService.shorten(any(UrlRequest.class))).thenReturn(response);

 // When & Then
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").value("http://localhost:8080/my-alias"));

 verify(urlService, times(1)).shorten(any(UrlRequest.class));
 }

 @Test
 @DisplayName("GET /{alias} - Redirects to full URL")
 void redirect_Returns302() throws Exception {
 // Given
 String alias = "tpx";
 String fullUrl = "https://tpximpact.com";
 when(urlService.getFullUrl(alias)).thenReturn(fullUrl);

 // When & Then
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound())
 .andExpect(header().string("Location", fullUrl))
 .andExpect(content().string("")); // Asserting empty body as requested

 verify(urlService).getFullUrl(alias);
 }

 @Test
 @DisplayName("GET /{alias} - Redirects returns 404 if alias not exist")
 void redirect_Returns404_If_Alias_Not_Exist() throws Exception {
 // Given
 String aliasNotExist = "notExist";
 when(urlService.getFullUrl(aliasNotExist)).thenThrow(NotFoundException.class);

 // When & Then
 mockMvc.perform(get("/{alias}", aliasNotExist))
 .andExpect(status().isNotFound());

 verify(urlService).getFullUrl(aliasNotExist);
 }

 @Test
 @DisplayName("GET /urls - Returns list of mappings")
 void getAll_Returns200() throws Exception {
 // Given
 List<UrlListResponse> mockList = List.of(
 new UrlListResponse("alias1", "https://site1.com", "http://short/1"),
 new UrlListResponse("alias2", "https://site2.com", "http://short/2")
 );
 when(urlService.getAll()).thenReturn(mockList);

 // When & Then
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$.length()").value(2))
 .andExpect(jsonPath("$[0].alias").value("alias1"));
 }

 @Test
 @DisplayName("DELETE /{alias} - Success")
 void delete_Returns204() throws Exception {
 // When & Then
 mockMvc.perform(delete("/{alias}", "old-alias"))
 .andExpect(status().isNoContent());

 verify(urlService).delete("old-alias");
 }

 @Test
 @DisplayName("POST /shorten - Fails on invalid input")
 void shortenUrl_BlankUrl_Returns400() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "alias");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());

 verifyNoInteractions(urlService);
 }
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Feature/add url shortener api tests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

upendrakumbham
merged 16 commits into

from

Apr 26, 2026
 Merged


Feature/add url shortener api tests
#3
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
8c06bcd

Added H2 data files


upendrakumbham Apr 22, 2026
80c7fb8

Added springboot starter test dependency


upendrakumbham Apr 22, 2026
ce085ed

Added service layer unit tests


upendrakumbham Apr 23, 2026
f24f104

Updated H2 Db as part of testing


upendrakumbham Apr 24, 2026
762d07f

Upgraded parent starter dependency to 4.0.1 from 3.2.0, 3.0.2 is in …


upendrakumbham Apr 24, 2026
ff2cd29

Upgraded parent starter dependency to 4.0.5 from 4.0.1 to remove vuln…


upendrakumbham Apr 24, 2026
0c396fd

Moved back to 3.5.0 to avoid modularised tech saperation package issues


upendrakumbham Apr 24, 2026
0a1f68d

Added web integration(E2E) tests


upendrakumbham Apr 24, 2026
d631bdf

Added controller unit tests


upendrakumbham Apr 24, 2026
795d1bb

Added controller integration Mockmvc tests to verify API flow, especi…


upendrakumbham Apr 24, 2026
b6b0f67

Removed unused variable


upendrakumbham Apr 24, 2026
3823260

Rename DB and added more capabilities


upendrakumbham Apr 24, 2026
dd903e8

We don't need @Transactional, data jpa handles that.


upendrakumbham Apr 26, 2026
518d3ca

Remove unused import


upendrakumbham Apr 26, 2026
9bbc0ee

Commit DB data


upendrakumbham Apr 26, 2026
f0b4bab

Added test properties file


upendrakumbham Apr 26, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view

Binary file addeddata/mydb.mv.db

View file


Open in desktop


Binary file not shown.


73 changes: 73 additions & 0 deletions
data/mydb.trace.db

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
2026-04-21 19:51:51.423293+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 05:55:04.822844+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:09:33.475810+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:16:11.292904+01:00 jdbc[16]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:23.617910+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:30.987650+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:33.627303+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 16:38:46.730818Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:38:53.145271Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:39:21.684624Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-24 05:52:19.361391+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]

10 changes: 9 additions & 1 deletion
pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 <parent>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-parent</artifactId>
 <version>3.2.0</version>
 <version>3.5.0</version>
 </parent>

 <properties>
Expand DownExpand Up@@ -53,5 +53,13 @@
 <artifactId>lombok</artifactId>
 <optional>true</optional>
 </dependency>

 <!-- api testing-->
 <dependency>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-test</artifactId>
 <scope>test</scope>
 </dependency>

 </dependencies>
</project>

2 changes: 1 addition & 1 deletion
src/main/resources/application-dev.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
spring:
 datasource:
 url: jdbc:h2:file:./data/mydb
 url: jdbc:h2:file:./data/url-shorten-db;AUTO_SERVER=TRUE;DB_CLOSE_ON_EXIT=FALSE
 driver-class-name: org.h2.Driver
 username: sa
 password:
Expand Down

76 changes: 76 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerIntegrationTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@SpringBootTest
@AutoConfigureMockMvc
class UrlControllerIntegrationTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @Test
 @DisplayName("Full integration flow: Create, Redirect, List, and Delete")
 void testUrlLifecycle() throws Exception {
 String longUrl = "https://www.tpximpact.com";
 String alias = "tpx";
 UrlRequest request = new UrlRequest(longUrl, alias);

 // 1. POST /shorten - Create a new mapping
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").exists());

 // 2. GET /{alias} - Test redirection logic
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound()) // 302
 .andExpect(header().string("Location", longUrl))
 .andExpect(content().string(""));

 // 3. GET /urls - Verify the alias appears in the list
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$").isArray())
 .andExpect(jsonPath("$[?(@.alias == '" + alias + "')]").exists());

 // 4. DELETE /{alias} - Remove the mapping
 mockMvc.perform(delete("/{alias}", alias))
 .andExpect(status().isNoContent());

 // 5. GET /{alias} - Verify it no longer exists (assuming service throws 404)
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isNotFound());
 }

 @Test
 @DisplayName("POST /shorten - Should return 400 when fullUrl is blank")
 void shouldReturn400ForInvalidInput() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "short");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());
 }
}

125 changes: 125 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlListResponse;
import com.tpximpact.urlshortener.dto.UrlRequest;
import com.tpximpact.urlshortener.dto.UrlResponse;
import com.tpximpact.urlshortener.exception.NotFoundException;
import com.tpximpact.urlshortener.service.UrlService;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.test.context.bean.override.mockito.MockitoBean; // SB 4.0 standard
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import java.util.List;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(UrlController.class)
class UrlControllerTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @MockitoBean
 private UrlService urlService;

 @Test
 @DisplayName("POST /shorten - Success")
 void shortenUrl_Returns201() throws Exception {
 // Given
 UrlRequest request = new UrlRequest("https://example.com", "my-alias");
 UrlResponse response = new UrlResponse("http://localhost:8080/my-alias");

 when(urlService.shorten(any(UrlRequest.class))).thenReturn(response);

 // When & Then
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").value("http://localhost:8080/my-alias"));

 verify(urlService, times(1)).shorten(any(UrlRequest.class));
 }

 @Test
 @DisplayName("GET /{alias} - Redirects to full URL")
 void redirect_Returns302() throws Exception {
 // Given
 String alias = "tpx";
 String fullUrl = "https://tpximpact.com";
 when(urlService.getFullUrl(alias)).thenReturn(fullUrl);

 // When & Then
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound())
 .andExpect(header().string("Location", fullUrl))
 .andExpect(content().string("")); // Asserting empty body as requested

 verify(urlService).getFullUrl(alias);
 }

 @Test
 @DisplayName("GET /{alias} - Redirects returns 404 if alias not exist")
 void redirect_Returns404_If_Alias_Not_Exist() throws Exception {
 // Given
 String aliasNotExist = "notExist";
 when(urlService.getFullUrl(aliasNotExist)).thenThrow(NotFoundException.class);

 // When & Then
 mockMvc.perform(get("/{alias}", aliasNotExist))
 .andExpect(status().isNotFound());

 verify(urlService).getFullUrl(aliasNotExist);
 }

 @Test
 @DisplayName("GET /urls - Returns list of mappings")
 void getAll_Returns200() throws Exception {
 // Given
 List<UrlListResponse> mockList = List.of(
 new UrlListResponse("alias1", "https://site1.com", "http://short/1"),
 new UrlListResponse("alias2", "https://site2.com", "http://short/2")
 );
 when(urlService.getAll()).thenReturn(mockList);

 // When & Then
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$.length()").value(2))
 .andExpect(jsonPath("$[0].alias").value("alias1"));
 }

 @Test
 @DisplayName("DELETE /{alias} - Success")
 void delete_Returns204() throws Exception {
 // When & Then
 mockMvc.perform(delete("/{alias}", "old-alias"))
 .andExpect(status().isNoContent());

 verify(urlService).delete("old-alias");
 }

 @Test
 @DisplayName("POST /shorten - Fails on invalid input")
 void shortenUrl_BlankUrl_Returns400() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "alias");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());

 verifyNoInteractions(urlService);
 }
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Feature/add url shortener api tests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

upendrakumbham
merged 16 commits into

from

Apr 26, 2026
 Merged


Feature/add url shortener api tests
#3
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
8c06bcd

Added H2 data files


upendrakumbham Apr 22, 2026
80c7fb8

Added springboot starter test dependency


upendrakumbham Apr 22, 2026
ce085ed

Added service layer unit tests


upendrakumbham Apr 23, 2026
f24f104

Updated H2 Db as part of testing


upendrakumbham Apr 24, 2026
762d07f

Upgraded parent starter dependency to 4.0.1 from 3.2.0, 3.0.2 is in …


upendrakumbham Apr 24, 2026
ff2cd29

Upgraded parent starter dependency to 4.0.5 from 4.0.1 to remove vuln…


upendrakumbham Apr 24, 2026
0c396fd

Moved back to 3.5.0 to avoid modularised tech saperation package issues


upendrakumbham Apr 24, 2026
0a1f68d

Added web integration(E2E) tests


upendrakumbham Apr 24, 2026
d631bdf

Added controller unit tests


upendrakumbham Apr 24, 2026
795d1bb

Added controller integration Mockmvc tests to verify API flow, especi…


upendrakumbham Apr 24, 2026
b6b0f67

Removed unused variable


upendrakumbham Apr 24, 2026
3823260

Rename DB and added more capabilities


upendrakumbham Apr 24, 2026
dd903e8

We don't need @Transactional, data jpa handles that.


upendrakumbham Apr 26, 2026
518d3ca

Remove unused import


upendrakumbham Apr 26, 2026
9bbc0ee

Commit DB data


upendrakumbham Apr 26, 2026
f0b4bab

Added test properties file


upendrakumbham Apr 26, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view

Binary file addeddata/mydb.mv.db

View file


Open in desktop


Binary file not shown.


73 changes: 73 additions & 0 deletions
data/mydb.trace.db

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
2026-04-21 19:51:51.423293+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 05:55:04.822844+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:09:33.475810+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:16:11.292904+01:00 jdbc[16]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:23.617910+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:30.987650+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:33.627303+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 16:38:46.730818Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:38:53.145271Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:39:21.684624Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-24 05:52:19.361391+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]

10 changes: 9 additions & 1 deletion
pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 <parent>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-parent</artifactId>
 <version>3.2.0</version>
 <version>3.5.0</version>
 </parent>

 <properties>
Expand DownExpand Up@@ -53,5 +53,13 @@
 <artifactId>lombok</artifactId>
 <optional>true</optional>
 </dependency>

 <!-- api testing-->
 <dependency>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-test</artifactId>
 <scope>test</scope>
 </dependency>

 </dependencies>
</project>

2 changes: 1 addition & 1 deletion
src/main/resources/application-dev.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
spring:
 datasource:
 url: jdbc:h2:file:./data/mydb
 url: jdbc:h2:file:./data/url-shorten-db;AUTO_SERVER=TRUE;DB_CLOSE_ON_EXIT=FALSE
 driver-class-name: org.h2.Driver
 username: sa
 password:
Expand Down

76 changes: 76 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerIntegrationTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@SpringBootTest
@AutoConfigureMockMvc
class UrlControllerIntegrationTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @Test
 @DisplayName("Full integration flow: Create, Redirect, List, and Delete")
 void testUrlLifecycle() throws Exception {
 String longUrl = "https://www.tpximpact.com";
 String alias = "tpx";
 UrlRequest request = new UrlRequest(longUrl, alias);

 // 1. POST /shorten - Create a new mapping
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").exists());

 // 2. GET /{alias} - Test redirection logic
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound()) // 302
 .andExpect(header().string("Location", longUrl))
 .andExpect(content().string(""));

 // 3. GET /urls - Verify the alias appears in the list
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$").isArray())
 .andExpect(jsonPath("$[?(@.alias == '" + alias + "')]").exists());

 // 4. DELETE /{alias} - Remove the mapping
 mockMvc.perform(delete("/{alias}", alias))
 .andExpect(status().isNoContent());

 // 5. GET /{alias} - Verify it no longer exists (assuming service throws 404)
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isNotFound());
 }

 @Test
 @DisplayName("POST /shorten - Should return 400 when fullUrl is blank")
 void shouldReturn400ForInvalidInput() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "short");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());
 }
}

125 changes: 125 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlListResponse;
import com.tpximpact.urlshortener.dto.UrlRequest;
import com.tpximpact.urlshortener.dto.UrlResponse;
import com.tpximpact.urlshortener.exception.NotFoundException;
import com.tpximpact.urlshortener.service.UrlService;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.test.context.bean.override.mockito.MockitoBean; // SB 4.0 standard
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import java.util.List;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(UrlController.class)
class UrlControllerTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @MockitoBean
 private UrlService urlService;

 @Test
 @DisplayName("POST /shorten - Success")
 void shortenUrl_Returns201() throws Exception {
 // Given
 UrlRequest request = new UrlRequest("https://example.com", "my-alias");
 UrlResponse response = new UrlResponse("http://localhost:8080/my-alias");

 when(urlService.shorten(any(UrlRequest.class))).thenReturn(response);

 // When & Then
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").value("http://localhost:8080/my-alias"));

 verify(urlService, times(1)).shorten(any(UrlRequest.class));
 }

 @Test
 @DisplayName("GET /{alias} - Redirects to full URL")
 void redirect_Returns302() throws Exception {
 // Given
 String alias = "tpx";
 String fullUrl = "https://tpximpact.com";
 when(urlService.getFullUrl(alias)).thenReturn(fullUrl);

 // When & Then
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound())
 .andExpect(header().string("Location", fullUrl))
 .andExpect(content().string("")); // Asserting empty body as requested

 verify(urlService).getFullUrl(alias);
 }

 @Test
 @DisplayName("GET /{alias} - Redirects returns 404 if alias not exist")
 void redirect_Returns404_If_Alias_Not_Exist() throws Exception {
 // Given
 String aliasNotExist = "notExist";
 when(urlService.getFullUrl(aliasNotExist)).thenThrow(NotFoundException.class);

 // When & Then
 mockMvc.perform(get("/{alias}", aliasNotExist))
 .andExpect(status().isNotFound());

 verify(urlService).getFullUrl(aliasNotExist);
 }

 @Test
 @DisplayName("GET /urls - Returns list of mappings")
 void getAll_Returns200() throws Exception {
 // Given
 List<UrlListResponse> mockList = List.of(
 new UrlListResponse("alias1", "https://site1.com", "http://short/1"),
 new UrlListResponse("alias2", "https://site2.com", "http://short/2")
 );
 when(urlService.getAll()).thenReturn(mockList);

 // When & Then
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$.length()").value(2))
 .andExpect(jsonPath("$[0].alias").value("alias1"));
 }

 @Test
 @DisplayName("DELETE /{alias} - Success")
 void delete_Returns204() throws Exception {
 // When & Then
 mockMvc.perform(delete("/{alias}", "old-alias"))
 .andExpect(status().isNoContent());

 verify(urlService).delete("old-alias");
 }

 @Test
 @DisplayName("POST /shorten - Fails on invalid input")
 void shortenUrl_BlankUrl_Returns400() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "alias");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());

 verifyNoInteractions(urlService);
 }
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Feature/add url shortener api tests#3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

upendrakumbham
merged 16 commits into

from

Apr 26, 2026
 Merged


Feature/add url shortener api tests
#3
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


16 commits


Select commit
Hold shift + click to select a range
8c06bcd

Added H2 data files


upendrakumbham Apr 22, 2026
80c7fb8

Added springboot starter test dependency


upendrakumbham Apr 22, 2026
ce085ed

Added service layer unit tests


upendrakumbham Apr 23, 2026
f24f104

Updated H2 Db as part of testing


upendrakumbham Apr 24, 2026
762d07f

Upgraded parent starter dependency to 4.0.1 from 3.2.0, 3.0.2 is in …


upendrakumbham Apr 24, 2026
ff2cd29

Upgraded parent starter dependency to 4.0.5 from 4.0.1 to remove vuln…


upendrakumbham Apr 24, 2026
0c396fd

Moved back to 3.5.0 to avoid modularised tech saperation package issues


upendrakumbham Apr 24, 2026
0a1f68d

Added web integration(E2E) tests


upendrakumbham Apr 24, 2026
d631bdf

Added controller unit tests


upendrakumbham Apr 24, 2026
795d1bb

Added controller integration Mockmvc tests to verify API flow, especi…


upendrakumbham Apr 24, 2026
b6b0f67

Removed unused variable


upendrakumbham Apr 24, 2026
3823260

Rename DB and added more capabilities


upendrakumbham Apr 24, 2026
dd903e8

We don't need @Transactional, data jpa handles that.


upendrakumbham Apr 26, 2026
518d3ca

Remove unused import


upendrakumbham Apr 26, 2026
9bbc0ee

Commit DB data


upendrakumbham Apr 26, 2026
f0b4bab

Added test properties file


upendrakumbham Apr 26, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view

Binary file addeddata/mydb.mv.db

View file


Open in desktop


Binary file not shown.


73 changes: 73 additions & 0 deletions
data/mydb.trace.db

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
2026-04-21 19:51:51.423293+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 05:55:04.822844+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:09:33.475810+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 06:16:11.292904+01:00 jdbc[16]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:23.617910+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:30.987650+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 12:24:33.627303+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]
2026-04-22 16:38:46.730818Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:38:53.145271Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-22 16:39:21.684624Z jdbc[3]: exception
java.sql.SQLClientInfoException: Client info name 'ApplicationName' not supported.
	at org.h2.jdbc.JdbcConnection.setClientInfo(JdbcConnection.java:1624)
	at com.intellij.database.remote.jdbc.impl.RemoteConnectionImpl.setClientInfo(RemoteConnectionImpl.java:468)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:360)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:598)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:844)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:721)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:720)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
2026-04-24 05:52:19.361391+01:00 jdbc[3]: exception
org.h2.jdbc.JdbcSQLNonTransientException: The object is already closed [90007-224]

10 changes: 9 additions & 1 deletion
pom.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 <parent>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-parent</artifactId>
 <version>3.2.0</version>
 <version>3.5.0</version>
 </parent>

 <properties>
Expand DownExpand Up@@ -53,5 +53,13 @@
 <artifactId>lombok</artifactId>
 <optional>true</optional>
 </dependency>

 <!-- api testing-->
 <dependency>
 <groupId>org.springframework.boot</groupId>
 <artifactId>spring-boot-starter-test</artifactId>
 <scope>test</scope>
 </dependency>

 </dependencies>
</project>

2 changes: 1 addition & 1 deletion
src/main/resources/application-dev.yaml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
spring:
 datasource:
 url: jdbc:h2:file:./data/mydb
 url: jdbc:h2:file:./data/url-shorten-db;AUTO_SERVER=TRUE;DB_CLOSE_ON_EXIT=FALSE
 driver-class-name: org.h2.Driver
 username: sa
 password:
Expand Down

76 changes: 76 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerIntegrationTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlRequest;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.content;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.header;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;

@SpringBootTest
@AutoConfigureMockMvc
class UrlControllerIntegrationTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @Test
 @DisplayName("Full integration flow: Create, Redirect, List, and Delete")
 void testUrlLifecycle() throws Exception {
 String longUrl = "https://www.tpximpact.com";
 String alias = "tpx";
 UrlRequest request = new UrlRequest(longUrl, alias);

 // 1. POST /shorten - Create a new mapping
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").exists());

 // 2. GET /{alias} - Test redirection logic
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound()) // 302
 .andExpect(header().string("Location", longUrl))
 .andExpect(content().string(""));

 // 3. GET /urls - Verify the alias appears in the list
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$").isArray())
 .andExpect(jsonPath("$[?(@.alias == '" + alias + "')]").exists());

 // 4. DELETE /{alias} - Remove the mapping
 mockMvc.perform(delete("/{alias}", alias))
 .andExpect(status().isNoContent());

 // 5. GET /{alias} - Verify it no longer exists (assuming service throws 404)
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isNotFound());
 }

 @Test
 @DisplayName("POST /shorten - Should return 400 when fullUrl is blank")
 void shouldReturn400ForInvalidInput() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "short");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());
 }
}

125 changes: 125 additions & 0 deletions
src/test/java/com/tpximpact/urlshortener/controller/UrlControllerTest.java

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,125 @@
package com.tpximpact.urlshortener.controller;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.tpximpact.urlshortener.dto.UrlListResponse;
import com.tpximpact.urlshortener.dto.UrlRequest;
import com.tpximpact.urlshortener.dto.UrlResponse;
import com.tpximpact.urlshortener.exception.NotFoundException;
import com.tpximpact.urlshortener.service.UrlService;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
import org.springframework.test.context.bean.override.mockito.MockitoBean; // SB 4.0 standard
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MockMvc;

import java.util.List;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@WebMvcTest(UrlController.class)
class UrlControllerTest {

 @Autowired
 private MockMvc mockMvc;

 @Autowired
 private ObjectMapper objectMapper;

 @MockitoBean
 private UrlService urlService;

 @Test
 @DisplayName("POST /shorten - Success")
 void shortenUrl_Returns201() throws Exception {
 // Given
 UrlRequest request = new UrlRequest("https://example.com", "my-alias");
 UrlResponse response = new UrlResponse("http://localhost:8080/my-alias");

 when(urlService.shorten(any(UrlRequest.class))).thenReturn(response);

 // When & Then
 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(request)))
 .andExpect(status().isCreated())
 .andExpect(jsonPath("$.shortUrl").value("http://localhost:8080/my-alias"));

 verify(urlService, times(1)).shorten(any(UrlRequest.class));
 }

 @Test
 @DisplayName("GET /{alias} - Redirects to full URL")
 void redirect_Returns302() throws Exception {
 // Given
 String alias = "tpx";
 String fullUrl = "https://tpximpact.com";
 when(urlService.getFullUrl(alias)).thenReturn(fullUrl);

 // When & Then
 mockMvc.perform(get("/{alias}", alias))
 .andExpect(status().isFound())
 .andExpect(header().string("Location", fullUrl))
 .andExpect(content().string("")); // Asserting empty body as requested

 verify(urlService).getFullUrl(alias);
 }

 @Test
 @DisplayName("GET /{alias} - Redirects returns 404 if alias not exist")
 void redirect_Returns404_If_Alias_Not_Exist() throws Exception {
 // Given
 String aliasNotExist = "notExist";
 when(urlService.getFullUrl(aliasNotExist)).thenThrow(NotFoundException.class);

 // When & Then
 mockMvc.perform(get("/{alias}", aliasNotExist))
 .andExpect(status().isNotFound());

 verify(urlService).getFullUrl(aliasNotExist);
 }

 @Test
 @DisplayName("GET /urls - Returns list of mappings")
 void getAll_Returns200() throws Exception {
 // Given
 List<UrlListResponse> mockList = List.of(
 new UrlListResponse("alias1", "https://site1.com", "http://short/1"),
 new UrlListResponse("alias2", "https://site2.com", "http://short/2")
 );
 when(urlService.getAll()).thenReturn(mockList);

 // When & Then
 mockMvc.perform(get("/urls"))
 .andExpect(status().isOk())
 .andExpect(jsonPath("$.length()").value(2))
 .andExpect(jsonPath("$[0].alias").value("alias1"));
 }

 @Test
 @DisplayName("DELETE /{alias} - Success")
 void delete_Returns204() throws Exception {
 // When & Then
 mockMvc.perform(delete("/{alias}", "old-alias"))
 .andExpect(status().isNoContent());

 verify(urlService).delete("old-alias");
 }

 @Test
 @DisplayName("POST /shorten - Fails on invalid input")
 void shortenUrl_BlankUrl_Returns400() throws Exception {
 UrlRequest invalidRequest = new UrlRequest("", "alias");

 mockMvc.perform(post("/shorten")
 .contentType(MediaType.APPLICATION_JSON)
 .content(objectMapper.writeValueAsString(invalidRequest)))
 .andExpect(status().isBadRequest());

 verifyNoInteractions(urlService);
 }
}
Loading