Uh oh!
There was an error while loading. Please reload this page.
.: Implement WithStack2 - #17
Merged
Merged
Conversation
| if input < 0 { | ||
| return Result{}, fmt.Errorf("negative input not allowed") | ||
| } | ||
| return Result{Value: input * 2}, nil |
There was a problem hiding this comment.
🚫 [golangci]reported by reviewdog 🐶
return with no blank line before (nlreturn)
Sypheos
approved these changes
Nov 24, 2025
tgallice
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I am getting tired of the linter errors:
error returned from interface method should be wrapped: sig: func (github.com/upfluence/xyz.MyType).MyFuction([]any) (any, error) (wrapcheck)It ask to explicitly add some lines of codes in order in order to add to the code minimal value to the author.
A good tradeoff is to add a small function in order to inline this, similar to
regexp.MustCompile.PS: the name is drown from a parralel of
iter.Seqanditer.Seq2What are the observable changes?
Good PR checklist
Additional Notes