Skip to content

discovery/*: Revamping the discovery stack - #85

Merged
AlexisMontagne merged 8 commits into
masterfrom
am-discovery-update
Apr 16, 2026
Merged

discovery/*: Revamping the discovery stack#85
AlexisMontagne merged 8 commits into
masterfrom
am-discovery-update

Conversation

@AlexisMontagne

@AlexisMontagneAlexisMontagne commented Apr 14, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This PR is a major refactor, bug fix and improvement of the discovery stack.

The goal is to help leveraging UDS runtime updates in a better way.

What are the observable changes?

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

Additional Notes

@AlexisMontagneAlexisMontagne self-assigned this Apr 14, 2026
@AlexisMontagne
AlexisMontagne requested a review from a team as a code ownerApril 14, 2026 20:07
@AlexisMontagne
AlexisMontagne requested review from pauloestrella1994 and xgoffin and removed request for a teamApril 14, 2026 20:07
xgoffin
xgoffin reviewed Apr 15, 2026
View reviewed changes

@xgoffinxgoffin left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a lot of this code doesn't respect our usual coding guidelines in terms of linebreaks before/after blocks. Could you give it a style cleanup please? 🙏 Listed a few examples

Comment threaddiscovery/balancer/roundrobin/balancer_test.go Outdated
Comment threaddiscovery/balancer/simple/policy.go
Comment threaddiscovery/balancer/simple/policy.go
@AlexisMontagne
AlexisMontagne merged commit f13adac into masterApr 16, 2026
4 checks passed
@AlexisMontagne
AlexisMontagne deleted the am-discovery-update branch April 16, 2026 17:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xgoffinxgoffinxgoffin left review comments
@pauloestrella1994pauloestrella1994Awaiting requested review from pauloestrella1994pauloestrella1994 is a code owner automatically assigned from upfluence/golang

Assignees

@AlexisMontagneAlexisMontagne

Labels

reviewed/needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexisMontagne@xgoffin@upfluence-bot