Uh oh!
There was an error while loading. Please reload this page.
country/code_fetcher.go: implement Search function - #86
Merged
Conversation
xgoffin
requested review from
karitham and pauloestrella1994
and removed request for
a teamApril 29, 2026 15:03
Sypheos
approved these changes
Apr 29, 2026
FlorianRichardUPF
approved these changes
Apr 29, 2026
| lint: | ||
| uses: upfluence/actions/.github/workflows/lint.yml@master | ||
| secrets: inherit | ||
| name: runner / golangci-lint |
There was a problem hiding this comment.
what is the issue w the factorized flow?
can we simply update it instead
ContributorAuthor
There was a problem hiding this comment.
Simply: it is not a factorized workflow 🙂 A factorized workflow has an on_call trigger, and that isn't the case of the lint file in actions (since it's a workflow that runs on actions too)
I'd need to take a look into the possibility to combine them and honestly this was not my first prio
ContributorAuthor
There was a problem hiding this comment.
And to my extreme surprise, github somehow allows this without exploding.
AlexisMontagne
commented
Apr 29, 2026
Member
Besides my gh workflow comment, the code looks good 👌🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #
What are the observable changes?
Good PR checklist
Additional Notes