Uh oh!
There was an error while loading. Please reload this page.
instrument.go: let ExecInstrument2 return the exec error to avoid swallowing errors - #8
Merged
Merged
Conversation
| var res T | ||
| i.Exec(func() error { | ||
| return res, i.Exec(func() error { |
There was a problem hiding this comment.
🚫 [golangci]reported by reviewdog 🐶
error returned from interface method should be wrapped: sig: func (github.com/upfluence/stats.Instrument).Exec(func() error) error (wrapcheck)
tgallice
approved these changes
Jan 23, 2026
Sypheos
approved these changes
Jan 23, 2026
Sypheos
left a comment
Member
There was a problem hiding this comment.
Won't that break a lot of upstream deps?
xgoffin
commented
Jan 23, 2026
ContributorAuthor
Thankfully it's not used much  |
AlexisMontagne
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to : #
What are the observable changes?
Good PR checklist
Impacted components
Additional Notes