Uh oh!
There was an error while loading. Please reload this page.
Add ability to pass extra options on each request - #12
Conversation
36be370 to
fe8ad94Compare| request(url, body, headers = {}, options = {}) { | ||
| const { method = 'get' } = options; | ||
| const requestOptions = { | ||
| ...options, |
There was a problem hiding this comment.
Are you destructuring the options object before the declaration of the other properties to prevent anyone from overriding those specific properties?
| .then(() => { | ||
| expect(sdk.client.request).toBeCalledWith( | ||
| 'https://api.uphold.com/v0/foo', | ||
| 'get', |
There was a problem hiding this comment.
Why did we removed the get assert?
There was a problem hiding this comment.
The request method is not an argument anymore. It is now provided by the options object.
There was a problem hiding this comment.
So, we need to create new tests to cover this scenario.
7375b76 to
a08e949Compare| export default class FetchClient extends Client { | ||
| request(url, method = 'get', body, headers = {}) { | ||
| const options = { | ||
| request(url, body, headers = {}, options = {}) { |
There was a problem hiding this comment.
Why did you removed the method and moved it to the options? Shouldn't the option only be an extra parameter to override all the other parameters?
There was a problem hiding this comment.
The method is passed to sdk as an option and then we chose to separate it into a different variable. This way and to avoid increase the argument size on this method, I opt to remove it and start using the one on the options object
c4f313d to
dc423acCompare| fetchMock.mock('foo', {}); | ||
| return client.request('foo', 'post', 'bar', { 'Biz-Baz': 'buz' }) | ||
| return client.request('foo', 'get', 'bar', { 'Biz-Baz': 'buz' }) |
| undefined, | ||
| { authorization: 'foo' } | ||
| { authorization: 'foo' }, | ||
| { headers: { authorization: 'foo' } } |
There was a problem hiding this comment.
According to the test name, this shouldn't be added, right?
There was a problem hiding this comment.
The test name was wrong and confusing. Updated.
dc423ac to
a8a2b8aComparepgom
commented
Apr 9, 2018
@SandroMachado updated |
a8a2b8a to
b04e9eaCompareb04e9ea to
6c08470Compare
Description
This PR updates the request client making it to possible to pass additional options on each request
Related issues