Uh oh!
There was an error while loading. Please reload this page.
Allow for passing body that is already stringified - #7
Merged
Conversation
ruipenso
commented
Sep 19, 2017
Contributor
@evq Thanks for the PR. The PR looks good - let's just wait for travis to merge and release a new version. |
ruipenso
commented
Sep 19, 2017
Contributor
@evq Can you please add a test to cover this? |
evq
commented
Sep 19, 2017
ContributorAuthor
done, thanks @ruipenso |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows passing a body that already had
JSON.stringifyrun on it. This enables use cases where a digest header needs to be sent as it is important to ensure that the body sent matches up exactly with the body used to generate the digest header.