Skip to content

Refactor tests - #34

Open
xiam wants to merge 2 commits into
masterfrom
feature/refactor-tests
Open

Refactor tests#34
xiam wants to merge 2 commits into
masterfrom
feature/refactor-tests

Conversation

@xiam

@xiamxiam commented Feb 18, 2020

Copy link
Copy Markdown
Member
  • move tests under internal/tests
  • use docker-compose to spin up a server and run tests

@xiam
xiamforce-pushed the feature/refactor-tests branch from 215fc69 to 82e86fcCompareFebruary 19, 2020 04:33
@xiam
xiam requested a review from pkieltykaFebruary 19, 2020 04:43
@xiam
xiamforce-pushed the feature/refactor-tests branch from f888490 to ba8fc2dCompareFebruary 19, 2020 04:56
@xiam

xiam commented Feb 19, 2020

Copy link
Copy Markdown
MemberAuthor

Hello @pkieltyka,

What do you think about moving tests to a directory?

@pkieltyka

Copy link
Copy Markdown
Member

Neat to see some clean up here :) By putting into internal folder, does that change go.mod behaviour I wonder? Looks good either way though

@xiam

xiam commented Feb 19, 2020 via email

Copy link
Copy Markdown
MemberAuthor

@xiam

xiam commented Feb 19, 2020

Copy link
Copy Markdown
MemberAuthor

I tried this out with https://github.com/upper/bond-example-project and didn't find anything odd with the directory change. I simulated a v0.11.0 tag.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@xiam@pkieltyka