Skip to content

fix: rename resources:get column title to Container - #147

Merged
bojanz merged 3 commits into
mainfrom
rename-resources-get-container
Aug 11, 2026
Merged

fix: rename resources:get column title to Container#147
bojanz merged 3 commits into
mainfrom
rename-resources-get-container

Conversation

@vitolkachova

Copy link
Copy Markdown
Contributor

No description provided.

CopilotAI lite review requested due to automatic review settings August 11, 2026 11:13
@upsun-dispatch

upsun-dispatchBot commented Aug 11, 2026

Copy link
Copy Markdown

📋 PR Summary

Renames the user-facing "App or service" label to "Container" in two legacy PHP commands: the resources:get table column header and a "not found" error message in resources:set. Only display strings change; the underlying 'service' column key and all logic are untouched.

Changes
Layer / File(s)Summary
resources label rename
legacy/src/Command/Resources/ResourcesGetCommand.phpChanges the service column header title from 'App or service' to 'Container'.
legacy/src/Command/Resources/ResourcesSetCommand.phpUpdates the service-not-found error message wording from 'App or service' to 'Container'.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the legacy PHP resources:get command’s table output to use “Container” as the column header for the service column, aligning the displayed terminology with container-profile/resource sizing concepts used by the command.

Changes:

  • Renamed the resources:get table header label for the service column from “App or service” to “Container”.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bojanz
bojanz self-requested a review August 11, 2026 11:26
@bojanz

Copy link
Copy Markdown
Collaborator

@vitolkachovaresources:set uses the error message 'App or service %s not found.', do we want to convert that as well?

@upsun-dispatchupsun-dispatchBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Reviewed — No new blocking findings · 1 minor point

🔍 Full review · 2 files reviewed

🔵 Minor points

Not blocking, and no threads opened for these.

  • general — This rename to 'Container' is applied to resources:get and resources:set, but the closely related autoscaling:get command (legacy/src/Command/Autoscaling/AutoscalingSettingsGetCommand.php:25) still labels the same column 'App or service'. Users comparing output across these commands will see inconsistent terminology for the same concept.
Review details
  • Commit:163fb39
  • Model: claude-opus-4-8
  • Panel: none

@bojanz
bojanz merged commit c0e6e56 into mainAug 11, 2026
5 checks passed
@bojanz
bojanz deleted the rename-resources-get-container branch August 11, 2026 14:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vitolkachova@bojanz