Uh oh!
There was an error while loading. Please reload this page.
fix: fall back to config file api_url when CLI flag/env var not set - #217
Merged
Conversation
Both `Cli::create_client()` and the auth login handler only checked the `--api-url` CLI flag / `DETAIL_API_URL` env var, ignoring the `api_url` field in config.toml. Added `effective_api_url()` that checks the CLI arg first, then falls back to the config file value. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sachiniyertemporarily deployed
to
integration-tests
March 24, 2026 03:02 — with 
GitHub Actions
Inactive
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sachiniyertemporarily deployed
to
integration-tests
March 24, 2026 03:10 — with GitHub Actions
Inactive
ContributorAuthor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cli::create_client()and the auth login handler only checked the--api-urlCLI flag /DETAIL_API_URLenv var, completely ignoring theapi_urlfield inconfig.tomleffective_api_url()method that resolves with precedence: CLI flag/env var → config file →None(production default)create_clientand auth login) now useeffective_api_url()Test plan
effective_api_url_uses_cli_flag— CLI flag is returned when seteffective_api_url_none_without_cli_flag—api_urlfield isNonewhen flag omitted, exercising the fallback pathconfig_api_url_is_used_when_no_flag— valid token + bogus configapi_url→ command fails (proves config was read)cli_flag_overrides_config_api_url— bogus configapi_url+ real--api-urlflag → command succeeds (proves flag wins)🤖 Generated with Claude Code