Skip to content

style: ban inline imports and hoist all use statements to module level#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sachiniyer merged 2 commits into from
May 19, 2026
Merged

style: ban inline imports and hoist all use statements to module level #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40bd85f
style: ban inline imports and hoist all use statements to module level
devin-ai-integration[bot] May 19, 2026
d68246a
style: hoist mid-file imports to top of src/api/client.rs
devin-ai-integration[bot] May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions REVIEW.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ Conventions that require human judgment during review. Lint-enforced rules

## Conventions

- Place all `use` imports at the top of the file or module — never inside function
bodies. For test modules, place imports at the top of the `mod tests` block.
- Do not use `pub(super)`. Use `pub(crate)` or `pub` instead.
- Prefer the narrowest visibility that compiles — plain `fn` over `pub(crate)`
when the function is only used within its own module.
Expand Down
23 changes: 9 additions & 14 deletions src/api/client.rs
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing non-top-of-file imports in src/api/client.rs

Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.

(Refers to lines 52-58)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
use std::fmt::Debug;
use std::num::NonZeroU64;
use std::time::Duration;

use anyhow::{Context, Result};
Expand All@@ -7,6 +8,14 @@ use serde::{Deserialize, Serialize};

use progenitor::progenitor_client::{Error as ProgenitorError, ResponseValue};

use super::generated::types::CreateRuleBody;
use super::types::{
Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

/// Convert a progenitor client error into a concise anyhow error.
///
/// progenitor's own `Display` for `ErrorResponse` dumps headers and the typed
Expand DownExpand Up@@ -48,14 +57,6 @@ fn api_error<E: Debug + Serialize>(e: ProgenitorError<E>) -> anyhow::Error {
anyhow::anyhow!("API error: {e}")
}

use super::generated::types::CreateRuleBody;
use super::types::{
Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

fn base_http_client() -> reqwest::ClientBuilder {
reqwest::Client::builder()
.user_agent(format!("detail-cli/{}", env!("CARGO_PKG_VERSION")))
Expand DownExpand Up@@ -105,8 +106,6 @@ impl ApiClient {
offset: u32,
scan_id: Option<&ListPublicBugsWorkflowRequestId>,
) -> Result<BugsResponse> {
use std::num::NonZeroU64;

self.inner
.list_public_bugs(
NonZeroU64::new(limit.into()),
Expand DownExpand Up@@ -154,8 +153,6 @@ impl ApiClient {
limit: u32,
offset: u32,
) -> Result<ScansResponse> {
use std::num::NonZeroU64;

self.inner
.list_public_scans(NonZeroU64::new(limit.into()), Some(offset.into()), repo_id)
.await
Expand All@@ -164,8 +161,6 @@ impl ApiClient {
}

pub async fn list_repos(&self, limit: u32, offset: u32) -> Result<ReposResponse> {
use std::num::NonZeroU64;

self.inner
.list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
.await
Expand Down
3 changes: 1 addition & 2 deletions src/config/storage.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -172,6 +172,7 @@ pub fn acquire_update_lock() -> Result<File> {
mod tests {
use std::process;
use std::sync::Mutex;
use std::thread;

use super::*;

Expand DownExpand Up@@ -461,8 +462,6 @@ api_token = \"old_token\"

#[test]
fn concurrent_update_config_does_not_corrupt() {
use std::thread;

with_temp_config(|| {
// Initialize config
update_config(|_| {}).unwrap();
Expand Down
4 changes: 1 addition & 3 deletions src/lib.rs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -223,6 +223,7 @@ enum Commands {
#[cfg(test)]
mod tests {
use super::*;
use crate::api::types::BugReviewState;

#[test]
fn silent_when_bugs_list_json() {
Expand DownExpand Up@@ -460,7 +461,6 @@ mod tests {

#[test]
fn bugs_list_status_default_is_pending() {
use crate::api::types::BugReviewState;
let cli = Cli::try_parse_from(["detail", "bugs", "list", "owner/repo"]).unwrap();
if let Commands::Bugs {
command: commands::bugs::BugCommands::List { status, .. },
Expand All@@ -475,7 +475,6 @@ mod tests {

#[test]
fn bugs_list_status_comma_separated_parses() {
use crate::api::types::BugReviewState;
let cli = Cli::try_parse_from([
"detail",
"bugs",
Expand All@@ -499,7 +498,6 @@ mod tests {

#[test]
fn bugs_list_status_repeated_flag_parses() {
use crate::api::types::BugReviewState;
let cli = Cli::try_parse_from([
"detail",
"bugs",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
style: ban inline imports and hoist all use statements to module level by devin-ai-integration[bot] · Pull Request #299 · usedetail/cli · GitHub
Skip to content
style: ban inline imports and hoist all use statements to module level#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

sachiniyer
merged 2 commits into

from

May 19, 2026
 Merged


style: ban inline imports and hoist all use statements to module level
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
40bd85f

style: ban inline imports and hoist all use statements to module level


devin-ai-integration[bot] May 19, 2026
d68246a

style: hoist mid-file imports to top of src/api/client.rs


devin-ai-integration[bot] May 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
REVIEW.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ Conventions that require human judgment during review. Lint-enforced rules

## Conventions

- Place all `use` imports at the top of the file or module — never inside function
 bodies. For test modules, place imports at the top of the `mod tests` block.
- Do not use `pub(super)`. Use `pub(crate)` or `pub` instead.
- Prefer the narrowest visibility that compiles — plain `fn` over `pub(crate)`
 when the function is only used within its own module.
Expand Down

23 changes: 9 additions & 14 deletions
src/api/client.rs

View file


Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing non-top-of-file imports in src/api/client.rs
Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.
(Refers to lines 52-58)
Open in Devin Review
Was this helpful? React with 👍 or 👎 to provide feedback.
@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
use std::fmt::Debug;
use std::num::NonZeroU64;
use std::time::Duration;

use anyhow::{Context, Result};
Expand All@@ -7,6 +8,14 @@ use serde::{Deserialize, Serialize};

use progenitor::progenitor_client::{Error as ProgenitorError, ResponseValue};

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

/// Convert a progenitor client error into a concise anyhow error.
///
/// progenitor's own `Display` for `ErrorResponse` dumps headers and the typed
Expand DownExpand Up@@ -48,14 +57,6 @@ fn api_error<E: Debug + Serialize>(e: ProgenitorError<E>) -> anyhow::Error {
 anyhow::anyhow!("API error: {e}")
}

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

fn base_http_client() -> reqwest::ClientBuilder {
 reqwest::Client::builder()
 .user_agent(format!("detail-cli/{}", env!("CARGO_PKG_VERSION")))
Expand DownExpand Up@@ -105,8 +106,6 @@ impl ApiClient {
 offset: u32,
 scan_id: Option<&ListPublicBugsWorkflowRequestId>,
 ) -> Result<BugsResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_bugs(
 NonZeroU64::new(limit.into()),
Expand DownExpand Up@@ -154,8 +153,6 @@ impl ApiClient {
 limit: u32,
 offset: u32,
 ) -> Result<ScansResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_scans(NonZeroU64::new(limit.into()), Some(offset.into()), repo_id)
 .await
Expand All@@ -164,8 +161,6 @@ impl ApiClient {
 }

 pub async fn list_repos(&self, limit: u32, offset: u32) -> Result<ReposResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
 .await
Expand Down

3 changes: 1 addition & 2 deletions
src/config/storage.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -172,6 +172,7 @@ pub fn acquire_update_lock() -> Result<File> {
mod tests {
 use std::process;
 use std::sync::Mutex;
 use std::thread;

 use super::*;

Expand DownExpand Up@@ -461,8 +462,6 @@ api_token = \"old_token\"

 #[test]
 fn concurrent_update_config_does_not_corrupt() {
 use std::thread;

 with_temp_config(|| {
 // Initialize config
 update_config(|_| {}).unwrap();
Expand Down

4 changes: 1 addition & 3 deletions
src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -223,6 +223,7 @@ enum Commands {
#[cfg(test)]
mod tests {
 use super::*;
 use crate::api::types::BugReviewState;

 #[test]
 fn silent_when_bugs_list_json() {
Expand DownExpand Up@@ -460,7 +461,6 @@ mod tests {

 #[test]
 fn bugs_list_status_default_is_pending() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from(["detail", "bugs", "list", "owner/repo"]).unwrap();
 if let Commands::Bugs {
 command: commands::bugs::BugCommands::List { status, .. },
Expand All@@ -475,7 +475,6 @@ mod tests {

 #[test]
 fn bugs_list_status_comma_separated_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand All@@ -499,7 +498,6 @@ mod tests {

 #[test]
 fn bugs_list_status_repeated_flag_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
style: ban inline imports and hoist all use statements to module level by devin-ai-integration[bot] · Pull Request #299 · usedetail/cli · GitHub
Skip to content
style: ban inline imports and hoist all use statements to module level#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

sachiniyer
merged 2 commits into

from

May 19, 2026
 Merged


style: ban inline imports and hoist all use statements to module level
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
40bd85f

style: ban inline imports and hoist all use statements to module level


devin-ai-integration[bot] May 19, 2026
d68246a

style: hoist mid-file imports to top of src/api/client.rs


devin-ai-integration[bot] May 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
REVIEW.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ Conventions that require human judgment during review. Lint-enforced rules

## Conventions

- Place all `use` imports at the top of the file or module — never inside function
 bodies. For test modules, place imports at the top of the `mod tests` block.
- Do not use `pub(super)`. Use `pub(crate)` or `pub` instead.
- Prefer the narrowest visibility that compiles — plain `fn` over `pub(crate)`
 when the function is only used within its own module.
Expand Down

23 changes: 9 additions & 14 deletions
src/api/client.rs

View file


Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing non-top-of-file imports in src/api/client.rs
Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.
(Refers to lines 52-58)
Open in Devin Review
Was this helpful? React with 👍 or 👎 to provide feedback.
@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
use std::fmt::Debug;
use std::num::NonZeroU64;
use std::time::Duration;

use anyhow::{Context, Result};
Expand All@@ -7,6 +8,14 @@ use serde::{Deserialize, Serialize};

use progenitor::progenitor_client::{Error as ProgenitorError, ResponseValue};

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

/// Convert a progenitor client error into a concise anyhow error.
///
/// progenitor's own `Display` for `ErrorResponse` dumps headers and the typed
Expand DownExpand Up@@ -48,14 +57,6 @@ fn api_error<E: Debug + Serialize>(e: ProgenitorError<E>) -> anyhow::Error {
 anyhow::anyhow!("API error: {e}")
}

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

fn base_http_client() -> reqwest::ClientBuilder {
 reqwest::Client::builder()
 .user_agent(format!("detail-cli/{}", env!("CARGO_PKG_VERSION")))
Expand DownExpand Up@@ -105,8 +106,6 @@ impl ApiClient {
 offset: u32,
 scan_id: Option<&ListPublicBugsWorkflowRequestId>,
 ) -> Result<BugsResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_bugs(
 NonZeroU64::new(limit.into()),
Expand DownExpand Up@@ -154,8 +153,6 @@ impl ApiClient {
 limit: u32,
 offset: u32,
 ) -> Result<ScansResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_scans(NonZeroU64::new(limit.into()), Some(offset.into()), repo_id)
 .await
Expand All@@ -164,8 +161,6 @@ impl ApiClient {
 }

 pub async fn list_repos(&self, limit: u32, offset: u32) -> Result<ReposResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
 .await
Expand Down

3 changes: 1 addition & 2 deletions
src/config/storage.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -172,6 +172,7 @@ pub fn acquire_update_lock() -> Result<File> {
mod tests {
 use std::process;
 use std::sync::Mutex;
 use std::thread;

 use super::*;

Expand DownExpand Up@@ -461,8 +462,6 @@ api_token = \"old_token\"

 #[test]
 fn concurrent_update_config_does_not_corrupt() {
 use std::thread;

 with_temp_config(|| {
 // Initialize config
 update_config(|_| {}).unwrap();
Expand Down

4 changes: 1 addition & 3 deletions
src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -223,6 +223,7 @@ enum Commands {
#[cfg(test)]
mod tests {
 use super::*;
 use crate::api::types::BugReviewState;

 #[test]
 fn silent_when_bugs_list_json() {
Expand DownExpand Up@@ -460,7 +461,6 @@ mod tests {

 #[test]
 fn bugs_list_status_default_is_pending() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from(["detail", "bugs", "list", "owner/repo"]).unwrap();
 if let Commands::Bugs {
 command: commands::bugs::BugCommands::List { status, .. },
Expand All@@ -475,7 +475,6 @@ mod tests {

 #[test]
 fn bugs_list_status_comma_separated_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand All@@ -499,7 +498,6 @@ mod tests {

 #[test]
 fn bugs_list_status_repeated_flag_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
style: ban inline imports and hoist all use statements to module level by devin-ai-integration[bot] · Pull Request #299 · usedetail/cli · GitHub
Skip to content
style: ban inline imports and hoist all use statements to module level#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

sachiniyer
merged 2 commits into

from

May 19, 2026
 Merged


style: ban inline imports and hoist all use statements to module level
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
40bd85f

style: ban inline imports and hoist all use statements to module level


devin-ai-integration[bot] May 19, 2026
d68246a

style: hoist mid-file imports to top of src/api/client.rs


devin-ai-integration[bot] May 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
REVIEW.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ Conventions that require human judgment during review. Lint-enforced rules

## Conventions

- Place all `use` imports at the top of the file or module — never inside function
 bodies. For test modules, place imports at the top of the `mod tests` block.
- Do not use `pub(super)`. Use `pub(crate)` or `pub` instead.
- Prefer the narrowest visibility that compiles — plain `fn` over `pub(crate)`
 when the function is only used within its own module.
Expand Down

23 changes: 9 additions & 14 deletions
src/api/client.rs

View file


Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing non-top-of-file imports in src/api/client.rs
Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.
(Refers to lines 52-58)
Open in Devin Review
Was this helpful? React with 👍 or 👎 to provide feedback.
@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
use std::fmt::Debug;
use std::num::NonZeroU64;
use std::time::Duration;

use anyhow::{Context, Result};
Expand All@@ -7,6 +8,14 @@ use serde::{Deserialize, Serialize};

use progenitor::progenitor_client::{Error as ProgenitorError, ResponseValue};

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

/// Convert a progenitor client error into a concise anyhow error.
///
/// progenitor's own `Display` for `ErrorResponse` dumps headers and the typed
Expand DownExpand Up@@ -48,14 +57,6 @@ fn api_error<E: Debug + Serialize>(e: ProgenitorError<E>) -> anyhow::Error {
 anyhow::anyhow!("API error: {e}")
}

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

fn base_http_client() -> reqwest::ClientBuilder {
 reqwest::Client::builder()
 .user_agent(format!("detail-cli/{}", env!("CARGO_PKG_VERSION")))
Expand DownExpand Up@@ -105,8 +106,6 @@ impl ApiClient {
 offset: u32,
 scan_id: Option<&ListPublicBugsWorkflowRequestId>,
 ) -> Result<BugsResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_bugs(
 NonZeroU64::new(limit.into()),
Expand DownExpand Up@@ -154,8 +153,6 @@ impl ApiClient {
 limit: u32,
 offset: u32,
 ) -> Result<ScansResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_scans(NonZeroU64::new(limit.into()), Some(offset.into()), repo_id)
 .await
Expand All@@ -164,8 +161,6 @@ impl ApiClient {
 }

 pub async fn list_repos(&self, limit: u32, offset: u32) -> Result<ReposResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
 .await
Expand Down

3 changes: 1 addition & 2 deletions
src/config/storage.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -172,6 +172,7 @@ pub fn acquire_update_lock() -> Result<File> {
mod tests {
 use std::process;
 use std::sync::Mutex;
 use std::thread;

 use super::*;

Expand DownExpand Up@@ -461,8 +462,6 @@ api_token = \"old_token\"

 #[test]
 fn concurrent_update_config_does_not_corrupt() {
 use std::thread;

 with_temp_config(|| {
 // Initialize config
 update_config(|_| {}).unwrap();
Expand Down

4 changes: 1 addition & 3 deletions
src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -223,6 +223,7 @@ enum Commands {
#[cfg(test)]
mod tests {
 use super::*;
 use crate::api::types::BugReviewState;

 #[test]
 fn silent_when_bugs_list_json() {
Expand DownExpand Up@@ -460,7 +461,6 @@ mod tests {

 #[test]
 fn bugs_list_status_default_is_pending() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from(["detail", "bugs", "list", "owner/repo"]).unwrap();
 if let Commands::Bugs {
 command: commands::bugs::BugCommands::List { status, .. },
Expand All@@ -475,7 +475,6 @@ mod tests {

 #[test]
 fn bugs_list_status_comma_separated_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand All@@ -499,7 +498,6 @@ mod tests {

 #[test]
 fn bugs_list_status_repeated_flag_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
style: ban inline imports and hoist all use statements to module level by devin-ai-integration[bot] · Pull Request #299 · usedetail/cli · GitHub
Skip to content
style: ban inline imports and hoist all use statements to module level#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

sachiniyer
merged 2 commits into

from

May 19, 2026
 Merged


style: ban inline imports and hoist all use statements to module level
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
40bd85f

style: ban inline imports and hoist all use statements to module level


devin-ai-integration[bot] May 19, 2026
d68246a

style: hoist mid-file imports to top of src/api/client.rs


devin-ai-integration[bot] May 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
REVIEW.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ Conventions that require human judgment during review. Lint-enforced rules

## Conventions

- Place all `use` imports at the top of the file or module — never inside function
 bodies. For test modules, place imports at the top of the `mod tests` block.
- Do not use `pub(super)`. Use `pub(crate)` or `pub` instead.
- Prefer the narrowest visibility that compiles — plain `fn` over `pub(crate)`
 when the function is only used within its own module.
Expand Down

23 changes: 9 additions & 14 deletions
src/api/client.rs

View file


Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing non-top-of-file imports in src/api/client.rs
Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.
(Refers to lines 52-58)
Open in Devin Review
Was this helpful? React with 👍 or 👎 to provide feedback.
@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
use std::fmt::Debug;
use std::num::NonZeroU64;
use std::time::Duration;

use anyhow::{Context, Result};
Expand All@@ -7,6 +8,14 @@ use serde::{Deserialize, Serialize};

use progenitor::progenitor_client::{Error as ProgenitorError, ResponseValue};

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

/// Convert a progenitor client error into a concise anyhow error.
///
/// progenitor's own `Display` for `ErrorResponse` dumps headers and the typed
Expand DownExpand Up@@ -48,14 +57,6 @@ fn api_error<E: Debug + Serialize>(e: ProgenitorError<E>) -> anyhow::Error {
 anyhow::anyhow!("API error: {e}")
}

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

fn base_http_client() -> reqwest::ClientBuilder {
 reqwest::Client::builder()
 .user_agent(format!("detail-cli/{}", env!("CARGO_PKG_VERSION")))
Expand DownExpand Up@@ -105,8 +106,6 @@ impl ApiClient {
 offset: u32,
 scan_id: Option<&ListPublicBugsWorkflowRequestId>,
 ) -> Result<BugsResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_bugs(
 NonZeroU64::new(limit.into()),
Expand DownExpand Up@@ -154,8 +153,6 @@ impl ApiClient {
 limit: u32,
 offset: u32,
 ) -> Result<ScansResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_scans(NonZeroU64::new(limit.into()), Some(offset.into()), repo_id)
 .await
Expand All@@ -164,8 +161,6 @@ impl ApiClient {
 }

 pub async fn list_repos(&self, limit: u32, offset: u32) -> Result<ReposResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
 .await
Expand Down

3 changes: 1 addition & 2 deletions
src/config/storage.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -172,6 +172,7 @@ pub fn acquire_update_lock() -> Result<File> {
mod tests {
 use std::process;
 use std::sync::Mutex;
 use std::thread;

 use super::*;

Expand DownExpand Up@@ -461,8 +462,6 @@ api_token = \"old_token\"

 #[test]
 fn concurrent_update_config_does_not_corrupt() {
 use std::thread;

 with_temp_config(|| {
 // Initialize config
 update_config(|_| {}).unwrap();
Expand Down

4 changes: 1 addition & 3 deletions
src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -223,6 +223,7 @@ enum Commands {
#[cfg(test)]
mod tests {
 use super::*;
 use crate::api::types::BugReviewState;

 #[test]
 fn silent_when_bugs_list_json() {
Expand DownExpand Up@@ -460,7 +461,6 @@ mod tests {

 #[test]
 fn bugs_list_status_default_is_pending() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from(["detail", "bugs", "list", "owner/repo"]).unwrap();
 if let Commands::Bugs {
 command: commands::bugs::BugCommands::List { status, .. },
Expand All@@ -475,7 +475,6 @@ mod tests {

 #[test]
 fn bugs_list_status_comma_separated_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand All@@ -499,7 +498,6 @@ mod tests {

 #[test]
 fn bugs_list_status_repeated_flag_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
style: ban inline imports and hoist all use statements to module level by devin-ai-integration[bot] · Pull Request #299 · usedetail/cli · GitHub
Skip to content
style: ban inline imports and hoist all use statements to module level#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

sachiniyer
merged 2 commits into

from

May 19, 2026
 Merged


style: ban inline imports and hoist all use statements to module level
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
40bd85f

style: ban inline imports and hoist all use statements to module level


devin-ai-integration[bot] May 19, 2026
d68246a

style: hoist mid-file imports to top of src/api/client.rs


devin-ai-integration[bot] May 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
REVIEW.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ Conventions that require human judgment during review. Lint-enforced rules

## Conventions

- Place all `use` imports at the top of the file or module — never inside function
 bodies. For test modules, place imports at the top of the `mod tests` block.
- Do not use `pub(super)`. Use `pub(crate)` or `pub` instead.
- Prefer the narrowest visibility that compiles — plain `fn` over `pub(crate)`
 when the function is only used within its own module.
Expand Down

23 changes: 9 additions & 14 deletions
src/api/client.rs

View file


Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing non-top-of-file imports in src/api/client.rs
Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.
(Refers to lines 52-58)
Open in Devin Review
Was this helpful? React with 👍 or 👎 to provide feedback.
@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
use std::fmt::Debug;
use std::num::NonZeroU64;
use std::time::Duration;

use anyhow::{Context, Result};
Expand All@@ -7,6 +8,14 @@ use serde::{Deserialize, Serialize};

use progenitor::progenitor_client::{Error as ProgenitorError, ResponseValue};

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

/// Convert a progenitor client error into a concise anyhow error.
///
/// progenitor's own `Display` for `ErrorResponse` dumps headers and the typed
Expand DownExpand Up@@ -48,14 +57,6 @@ fn api_error<E: Debug + Serialize>(e: ProgenitorError<E>) -> anyhow::Error {
 anyhow::anyhow!("API error: {e}")
}

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

fn base_http_client() -> reqwest::ClientBuilder {
 reqwest::Client::builder()
 .user_agent(format!("detail-cli/{}", env!("CARGO_PKG_VERSION")))
Expand DownExpand Up@@ -105,8 +106,6 @@ impl ApiClient {
 offset: u32,
 scan_id: Option<&ListPublicBugsWorkflowRequestId>,
 ) -> Result<BugsResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_bugs(
 NonZeroU64::new(limit.into()),
Expand DownExpand Up@@ -154,8 +153,6 @@ impl ApiClient {
 limit: u32,
 offset: u32,
 ) -> Result<ScansResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_scans(NonZeroU64::new(limit.into()), Some(offset.into()), repo_id)
 .await
Expand All@@ -164,8 +161,6 @@ impl ApiClient {
 }

 pub async fn list_repos(&self, limit: u32, offset: u32) -> Result<ReposResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
 .await
Expand Down

3 changes: 1 addition & 2 deletions
src/config/storage.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -172,6 +172,7 @@ pub fn acquire_update_lock() -> Result<File> {
mod tests {
 use std::process;
 use std::sync::Mutex;
 use std::thread;

 use super::*;

Expand DownExpand Up@@ -461,8 +462,6 @@ api_token = \"old_token\"

 #[test]
 fn concurrent_update_config_does_not_corrupt() {
 use std::thread;

 with_temp_config(|| {
 // Initialize config
 update_config(|_| {}).unwrap();
Expand Down

4 changes: 1 addition & 3 deletions
src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -223,6 +223,7 @@ enum Commands {
#[cfg(test)]
mod tests {
 use super::*;
 use crate::api::types::BugReviewState;

 #[test]
 fn silent_when_bugs_list_json() {
Expand DownExpand Up@@ -460,7 +461,6 @@ mod tests {

 #[test]
 fn bugs_list_status_default_is_pending() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from(["detail", "bugs", "list", "owner/repo"]).unwrap();
 if let Commands::Bugs {
 command: commands::bugs::BugCommands::List { status, .. },
Expand All@@ -475,7 +475,6 @@ mod tests {

 #[test]
 fn bugs_list_status_comma_separated_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand All@@ -499,7 +498,6 @@ mod tests {

 #[test]
 fn bugs_list_status_repeated_flag_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
style: ban inline imports and hoist all use statements to module level by devin-ai-integration[bot] · Pull Request #299 · usedetail/cli · GitHub
Skip to content
style: ban inline imports and hoist all use statements to module level#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

sachiniyer
merged 2 commits into

from

May 19, 2026
 Merged


style: ban inline imports and hoist all use statements to module level
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
40bd85f

style: ban inline imports and hoist all use statements to module level


devin-ai-integration[bot] May 19, 2026
d68246a

style: hoist mid-file imports to top of src/api/client.rs


devin-ai-integration[bot] May 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
REVIEW.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ Conventions that require human judgment during review. Lint-enforced rules

## Conventions

- Place all `use` imports at the top of the file or module — never inside function
 bodies. For test modules, place imports at the top of the `mod tests` block.
- Do not use `pub(super)`. Use `pub(crate)` or `pub` instead.
- Prefer the narrowest visibility that compiles — plain `fn` over `pub(crate)`
 when the function is only used within its own module.
Expand Down

23 changes: 9 additions & 14 deletions
src/api/client.rs

View file


Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing non-top-of-file imports in src/api/client.rs
Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.
(Refers to lines 52-58)
Open in Devin Review
Was this helpful? React with 👍 or 👎 to provide feedback.
@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
use std::fmt::Debug;
use std::num::NonZeroU64;
use std::time::Duration;

use anyhow::{Context, Result};
Expand All@@ -7,6 +8,14 @@ use serde::{Deserialize, Serialize};

use progenitor::progenitor_client::{Error as ProgenitorError, ResponseValue};

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

/// Convert a progenitor client error into a concise anyhow error.
///
/// progenitor's own `Display` for `ErrorResponse` dumps headers and the typed
Expand DownExpand Up@@ -48,14 +57,6 @@ fn api_error<E: Debug + Serialize>(e: ProgenitorError<E>) -> anyhow::Error {
 anyhow::anyhow!("API error: {e}")
}

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

fn base_http_client() -> reqwest::ClientBuilder {
 reqwest::Client::builder()
 .user_agent(format!("detail-cli/{}", env!("CARGO_PKG_VERSION")))
Expand DownExpand Up@@ -105,8 +106,6 @@ impl ApiClient {
 offset: u32,
 scan_id: Option<&ListPublicBugsWorkflowRequestId>,
 ) -> Result<BugsResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_bugs(
 NonZeroU64::new(limit.into()),
Expand DownExpand Up@@ -154,8 +153,6 @@ impl ApiClient {
 limit: u32,
 offset: u32,
 ) -> Result<ScansResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_scans(NonZeroU64::new(limit.into()), Some(offset.into()), repo_id)
 .await
Expand All@@ -164,8 +161,6 @@ impl ApiClient {
 }

 pub async fn list_repos(&self, limit: u32, offset: u32) -> Result<ReposResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
 .await
Expand Down

3 changes: 1 addition & 2 deletions
src/config/storage.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -172,6 +172,7 @@ pub fn acquire_update_lock() -> Result<File> {
mod tests {
 use std::process;
 use std::sync::Mutex;
 use std::thread;

 use super::*;

Expand DownExpand Up@@ -461,8 +462,6 @@ api_token = \"old_token\"

 #[test]
 fn concurrent_update_config_does_not_corrupt() {
 use std::thread;

 with_temp_config(|| {
 // Initialize config
 update_config(|_| {}).unwrap();
Expand Down

4 changes: 1 addition & 3 deletions
src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -223,6 +223,7 @@ enum Commands {
#[cfg(test)]
mod tests {
 use super::*;
 use crate::api::types::BugReviewState;

 #[test]
 fn silent_when_bugs_list_json() {
Expand DownExpand Up@@ -460,7 +461,6 @@ mod tests {

 #[test]
 fn bugs_list_status_default_is_pending() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from(["detail", "bugs", "list", "owner/repo"]).unwrap();
 if let Commands::Bugs {
 command: commands::bugs::BugCommands::List { status, .. },
Expand All@@ -475,7 +475,6 @@ mod tests {

 #[test]
 fn bugs_list_status_comma_separated_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand All@@ -499,7 +498,6 @@ mod tests {

 #[test]
 fn bugs_list_status_repeated_flag_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
style: ban inline imports and hoist all use statements to module level by devin-ai-integration[bot] · Pull Request #299 · usedetail/cli · GitHub
Skip to content
style: ban inline imports and hoist all use statements to module level#299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

sachiniyer
merged 2 commits into

from

May 19, 2026
 Merged


style: ban inline imports and hoist all use statements to module level
#299
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
40bd85f

style: ban inline imports and hoist all use statements to module level


devin-ai-integration[bot] May 19, 2026
d68246a

style: hoist mid-file imports to top of src/api/client.rs


devin-ai-integration[bot] May 19, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
REVIEW.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,8 @@ Conventions that require human judgment during review. Lint-enforced rules

## Conventions

- Place all `use` imports at the top of the file or module — never inside function
 bodies. For test modules, place imports at the top of the `mod tests` block.
- Do not use `pub(super)`. Use `pub(crate)` or `pub` instead.
- Prefer the narrowest visibility that compiles — plain `fn` over `pub(crate)`
 when the function is only used within its own module.
Expand Down

23 changes: 9 additions & 14 deletions
src/api/client.rs

View file


Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing non-top-of-file imports in src/api/client.rs
Lines 52-58 of src/api/client.rs contain use statements placed after the api_error function definition (lines 22-50), rather than grouped with the other imports at lines 1-9. The new REVIEW.md rule states 'Place all use imports at the top of the file or module.' While the PR correctly moves NonZeroU64 to line 2, these other imports remain in their mid-file position. This is a pre-existing pattern that predates this PR and is outside the diff hunks, but it's arguably inconsistent with the rule being introduced here.
(Refers to lines 52-58)
Open in Devin Review
Was this helpful? React with 👍 or 👎 to provide feedback.
@devin-ai-integrationdevin-ai-integrationBotMay 19, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — moved these super:: imports up to the top of the file alongside the other imports. Fixed in the latest commit.
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
use std::fmt::Debug;
use std::num::NonZeroU64;
use std::time::Duration;

use anyhow::{Context, Result};
Expand All@@ -7,6 +8,14 @@ use serde::{Deserialize, Serialize};

use progenitor::progenitor_client::{Error as ProgenitorError, ResponseValue};

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

/// Convert a progenitor client error into a concise anyhow error.
///
/// progenitor's own `Display` for `ErrorResponse` dumps headers and the typed
Expand DownExpand Up@@ -48,14 +57,6 @@ fn api_error<E: Debug + Serialize>(e: ProgenitorError<E>) -> anyhow::Error {
 anyhow::anyhow!("API error: {e}")
}

use super::generated::types::CreateRuleBody;
use super::types::{
 Bug, BugDismissalReason, BugId, BugReview, BugReviewState, BugsResponse,
 CreatePublicBugReviewBody, CreateRuleInput, CreateRuleResponse,
 ListPublicBugsWorkflowRequestId, RepoId, ReposResponse, Rule, RuleCreationRequestId, RuleId,
 RuleRequestStatus, RuleRequestsResponse, RulesResponse, ScansResponse, UserInfo,
};

fn base_http_client() -> reqwest::ClientBuilder {
 reqwest::Client::builder()
 .user_agent(format!("detail-cli/{}", env!("CARGO_PKG_VERSION")))
Expand DownExpand Up@@ -105,8 +106,6 @@ impl ApiClient {
 offset: u32,
 scan_id: Option<&ListPublicBugsWorkflowRequestId>,
 ) -> Result<BugsResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_bugs(
 NonZeroU64::new(limit.into()),
Expand DownExpand Up@@ -154,8 +153,6 @@ impl ApiClient {
 limit: u32,
 offset: u32,
 ) -> Result<ScansResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_scans(NonZeroU64::new(limit.into()), Some(offset.into()), repo_id)
 .await
Expand All@@ -164,8 +161,6 @@ impl ApiClient {
 }

 pub async fn list_repos(&self, limit: u32, offset: u32) -> Result<ReposResponse> {
 use std::num::NonZeroU64;

 self.inner
 .list_public_repos(NonZeroU64::new(limit.into()), Some(offset.into()))
 .await
Expand Down

3 changes: 1 addition & 2 deletions
src/config/storage.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -172,6 +172,7 @@ pub fn acquire_update_lock() -> Result<File> {
mod tests {
 use std::process;
 use std::sync::Mutex;
 use std::thread;

 use super::*;

Expand DownExpand Up@@ -461,8 +462,6 @@ api_token = \"old_token\"

 #[test]
 fn concurrent_update_config_does_not_corrupt() {
 use std::thread;

 with_temp_config(|| {
 // Initialize config
 update_config(|_| {}).unwrap();
Expand Down

4 changes: 1 addition & 3 deletions
src/lib.rs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -223,6 +223,7 @@ enum Commands {
#[cfg(test)]
mod tests {
 use super::*;
 use crate::api::types::BugReviewState;

 #[test]
 fn silent_when_bugs_list_json() {
Expand DownExpand Up@@ -460,7 +461,6 @@ mod tests {

 #[test]
 fn bugs_list_status_default_is_pending() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from(["detail", "bugs", "list", "owner/repo"]).unwrap();
 if let Commands::Bugs {
 command: commands::bugs::BugCommands::List { status, .. },
Expand All@@ -475,7 +475,6 @@ mod tests {

 #[test]
 fn bugs_list_status_comma_separated_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand All@@ -499,7 +498,6 @@ mod tests {

 #[test]
 fn bugs_list_status_repeated_flag_parses() {
 use crate::api::types::BugReviewState;
 let cli = Cli::try_parse_from([
 "detail",
 "bugs",
Expand Down
Loading